From 00314aabc00b2d8da16e8116ac090c076a1b3ee0 Mon Sep 17 00:00:00 2001 From: Alex Andreev Date: Thu, 3 Feb 2022 14:57:55 +0300 Subject: [PATCH] Fix unresponsive kubectl download binaries switch (#4807) * Add observer wrapper to KubectlBinaries Signed-off-by: Alex Andreev * Add missing terminal title Signed-off-by: Alex Andreev --- src/renderer/components/+preferences/kubectl-binaries.tsx | 3 ++- src/renderer/components/+preferences/terminal.tsx | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/renderer/components/+preferences/kubectl-binaries.tsx b/src/renderer/components/+preferences/kubectl-binaries.tsx index fdd0ab4131..c39dd333c3 100644 --- a/src/renderer/components/+preferences/kubectl-binaries.tsx +++ b/src/renderer/components/+preferences/kubectl-binaries.tsx @@ -4,6 +4,7 @@ */ import React, { useState } from "react"; +import { observer } from "mobx-react"; import { Input, InputValidators } from "../input"; import { SubTitle } from "../layout/sub-title"; import { UserStore } from "../../../common/user-store"; @@ -19,7 +20,7 @@ interface Dependencies { defaultPathForKubectlBinaries: string } -const NonInjectedKubectlBinaries: React.FC = (({ defaultPathForKubectlBinaries }) => { +const NonInjectedKubectlBinaries: React.FC = observer(({ defaultPathForKubectlBinaries }) => { const userStore = UserStore.getInstance(); const [downloadPath, setDownloadPath] = useState(userStore.downloadBinariesPath || ""); const [binariesPath, setBinariesPath] = useState(userStore.kubectlBinariesPath || ""); diff --git a/src/renderer/components/+preferences/terminal.tsx b/src/renderer/components/+preferences/terminal.tsx index b76f2ba567..f9f1226609 100644 --- a/src/renderer/components/+preferences/terminal.tsx +++ b/src/renderer/components/+preferences/terminal.tsx @@ -24,7 +24,9 @@ export const Terminal = observer(() => { : "System default shell" ); - return (
+ return (
+

Terminal

+
{ onChange={(value) => userStore.terminalConfig.fontFamily=value} />
-
); + ); });