From 005b993933cff83a7ebaad35d135674e56df650b Mon Sep 17 00:00:00 2001 From: Jim Ehrismann Date: Fri, 22 Oct 2021 17:38:57 -0400 Subject: [PATCH] address review comments Signed-off-by: Jim Ehrismann --- src/main/routes/port-forward-route.ts | 10 ++++------ src/renderer/port-forward/port-forward-dialog.tsx | 2 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/main/routes/port-forward-route.ts b/src/main/routes/port-forward-route.ts index 70f6b70261..56934628dd 100644 --- a/src/main/routes/port-forward-route.ts +++ b/src/main/routes/port-forward-route.ts @@ -134,12 +134,10 @@ export class PortForwardRoute { if (!portForward) { logger.info(`Creating a new port-forward ${namespace}/${resourceType}/${resourceName}:${port}`); - let thePort = 0; - - if (forwardPort > 0 && forwardPort < 65536) { - thePort = forwardPort; - } - + const thePort = 0 < forwardPort && forwardPort < 65536 + ? forwardPort + : 0; + portForward = new PortForward(await cluster.getProxyKubeconfigPath(), { clusterId: cluster.id, kind: resourceType, diff --git a/src/renderer/port-forward/port-forward-dialog.tsx b/src/renderer/port-forward/port-forward-dialog.tsx index cf7442ceea..b577e99e71 100644 --- a/src/renderer/port-forward/port-forward-dialog.tsx +++ b/src/renderer/port-forward/port-forward-dialog.tsx @@ -61,7 +61,7 @@ export class PortForwardDialog extends Component { static open(portForward: ForwardedPort, options: PortForwardDialogOpenOptions = { openInBrowser: false }) { dialogState.isOpen = true; dialogState.data = portForward; - dialogState.useHttps = Boolean(portForward.protocol === "https"); + dialogState.useHttps = portForward.protocol === "https"; dialogState.openInBrowser = options.openInBrowser; }