From 026de5185eb0010536a01942e29c07418eab4209 Mon Sep 17 00:00:00 2001 From: Alex Andreev Date: Mon, 19 Jul 2021 10:23:22 +0300 Subject: [PATCH] Moving TopBar components out of Routes Signed-off-by: Alex Andreev --- .../components/cluster-manager/cluster-manager.scss | 6 +----- src/renderer/components/cluster-manager/cluster-manager.tsx | 4 ---- src/renderer/components/cluster-manager/cluster-view.tsx | 2 ++ src/renderer/components/input/input.scss | 1 - src/renderer/components/menu/menu.tsx | 2 ++ 5 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/renderer/components/cluster-manager/cluster-manager.scss b/src/renderer/components/cluster-manager/cluster-manager.scss index dddbb1a5e5..e82c0d3aca 100644 --- a/src/renderer/components/cluster-manager/cluster-manager.scss +++ b/src/renderer/components/cluster-manager/cluster-manager.scss @@ -35,10 +35,6 @@ position: relative; display: flex; flex-direction: column; - - > * { - z-index: 1; - } } .HotbarMenu { @@ -52,7 +48,7 @@ #lens-views { position: absolute; left: 0; - top: 0; + top: 40px; // Move below top bar right: 0; bottom: 0; display: flex; diff --git a/src/renderer/components/cluster-manager/cluster-manager.tsx b/src/renderer/components/cluster-manager/cluster-manager.tsx index df5ae5d486..4bd14e7805 100644 --- a/src/renderer/components/cluster-manager/cluster-manager.tsx +++ b/src/renderer/components/cluster-manager/cluster-manager.tsx @@ -34,8 +34,6 @@ import { Extensions } from "../+extensions"; import { HotbarMenu } from "../hotbar/hotbar-menu"; import { EntitySettings } from "../+entity-settings"; import { Welcome } from "../+welcome"; -import { ClusterTopbar } from "./cluster-topbar"; -import { CatalogTopbar } from "./catalog-topbar"; import * as routes from "../../../common/routes"; @observer @@ -43,8 +41,6 @@ export class ClusterManager extends React.Component { render() { return (
- -
diff --git a/src/renderer/components/cluster-manager/cluster-view.tsx b/src/renderer/components/cluster-manager/cluster-view.tsx index db48e051c8..3d0fea8e55 100644 --- a/src/renderer/components/cluster-manager/cluster-view.tsx +++ b/src/renderer/components/cluster-manager/cluster-view.tsx @@ -34,6 +34,7 @@ import { catalogEntityRegistry } from "../../api/catalog-entity-registry"; import { navigate } from "../../navigation"; import { catalogURL, ClusterViewRouteParams } from "../../../common/routes"; import { previousActiveTab } from "../+catalog"; +import { ClusterTopbar } from "./cluster-topbar"; interface Props extends RouteComponentProps { } @@ -104,6 +105,7 @@ export class ClusterView extends React.Component { render() { return (
+ {this.renderStatus()}
); diff --git a/src/renderer/components/input/input.scss b/src/renderer/components/input/input.scss index b683f46d3a..33369694a3 100644 --- a/src/renderer/components/input/input.scss +++ b/src/renderer/components/input/input.scss @@ -61,7 +61,6 @@ width: 0; height: 2px; background: $primary; - transition: width 250ms; } } diff --git a/src/renderer/components/menu/menu.tsx b/src/renderer/components/menu/menu.tsx index 228db7ceb4..9fa05a1e3a 100644 --- a/src/renderer/components/menu/menu.tsx +++ b/src/renderer/components/menu/menu.tsx @@ -260,6 +260,8 @@ export class Menu extends React.Component { } onBlur() { + if (!this.isOpen) return; + if (document.activeElement?.tagName == "IFRAME") { this.close(); }