mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
Check object instanceof on all detail panels (#4054)
* Check object instanceof on all detail panels Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix unit tests - Remove prettier as snapShot testing is too tight of a bound Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
1 parent
dabfce3609
commit
052d12fc19
32 files changed
+392
-168
No files matched your search
@@ -40,6 +40,7 @@ import { ClusterMetricsResourceType } from "../../../common/cluster-types";
|
||||
import { NodeDetailsResources } from "./node-details-resources";
|
||||
import { DrawerTitle } from "../drawer/drawer-title";
|
||||
import { boundMethod } from "../../utils";
|
||||
import logger from "../../../common/logger";
|
||||
|
||||
interface Props extends KubeObjectDetailsProps<Node> {
|
||||
}
|
||||
@@ -72,7 +73,16 @@ export class NodeDetails extends React.Component<Props> {
|
||||
render() {
|
||||
const { object: node } = this.props;
|
||||
|
||||
if (!node) return null;
|
||||
if (!node) {
|
||||
return null;
|
||||
}
|
||||
|
||||
if (!(node instanceof Node)) {
|
||||
logger.error("[NodeDetails]: passed object that is not an instanceof Node", node);
|
||||
|
||||
return null;
|
||||
}
|
||||
|
||||
const { status } = node;
|
||||
const { nodeInfo, addresses } = status;
|
||||
const conditions = node.getActiveConditions();
|
||||
|
||||
Reference in new issue
Block a user