Check object instanceof on all detail panels (#4054)

* Check object instanceof on all detail panels

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix unit tests

- Remove prettier as snapShot testing is too tight of a bound

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton authored and GitHub committed 2021-10-15 12:11:46 -04:00
1 parent dabfce3609
commit 052d12fc19
32 files changed
+392 -168

No files matched your search

@@ -44,6 +44,7 @@ import { ResourceMetrics } from "../resource-metrics";
import { boundMethod } from "autobind-decorator";
import { getDetailsUrl } from "../kube-detail-params";
import { apiManager } from "../../../common/k8s-api/api-manager";
import logger from "../../../common/logger";
interface Props extends KubeObjectDetailsProps<Job> {
}
@@ -71,7 +72,16 @@ export class JobDetails extends React.Component<Props> {
render() {
const { object: job } = this.props;
if (!job) return null;
if (!job) {
return null;
}
if (!(job instanceof Job)) {
logger.error("[JobDetails]: passed object that is not an instanceof Job", job);
return null;
}
const selectors = job.getSelectors();
const nodeSelector = job.getNodeSelectors();
const images = job.getImages();