Check object instanceof on all detail panels (#4054)

* Check object instanceof on all detail panels

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix unit tests

- Remove prettier as snapShot testing is too tight of a bound

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton authored and GitHub committed 2021-10-15 12:11:46 -04:00
1 parent dabfce3609
commit 052d12fc19
32 files changed
+392 -168

No files matched your search

@@ -39,6 +39,7 @@ import { KubeObjectMeta } from "../kube-object-meta";
import { getActiveClusterEntity } from "../../api/catalog-entity-registry";
import { ClusterMetricsResourceType } from "../../../common/cluster-types";
import { boundMethod } from "../../utils";
import logger from "../../../common/logger";
interface Props extends KubeObjectDetailsProps<ReplicaSet> {
}
@@ -71,7 +72,16 @@ export class ReplicaSetDetails extends React.Component<Props> {
render() {
const { object: replicaSet } = this.props;
if (!replicaSet) return null;
if (!replicaSet) {
return null;
}
if (!(replicaSet instanceof ReplicaSet)) {
logger.error("[ReplicaSetDetails]: passed object that is not an instanceof ReplicaSet", replicaSet);
return null;
}
const { metrics } = this;
const { status } = replicaSet;
const { availableReplicas, replicas } = status;