From 05ab0a3f551e93591283a1ea619483b6b8d8ca3f Mon Sep 17 00:00:00 2001
From: Sebastian Malton <sebastian@malton.name>
Date: Wed, 16 Nov 2022 04:34:34 -0800
Subject: [PATCH] Remove hyperlink of Helm Maintainers (#6579)

- Instead just show the name and email

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Signed-off-by: Sebastian Malton <sebastian@malton.name>
---
 ...tab-for-installing-helm-chart.test.ts.snap | 24 +++++++++++++++----
 ...dock-tab-for-installing-helm-chart.test.ts | 20 ++++++++++++----
 .../+helm-charts/helm-chart-details.tsx       | 14 ++++-------
 3 files changed, 40 insertions(+), 18 deletions(-)

diff --git a/src/features/helm-charts/installing-chart/__snapshots__/opening-dock-tab-for-installing-helm-chart.test.ts.snap b/src/features/helm-charts/installing-chart/__snapshots__/opening-dock-tab-for-installing-helm-chart.test.ts.snap
index dcd2bb5dd1..8acd19726f 100644
--- a/src/features/helm-charts/installing-chart/__snapshots__/opening-dock-tab-for-installing-helm-chart.test.ts.snap
+++ b/src/features/helm-charts/installing-chart/__snapshots__/opening-dock-tab-for-installing-helm-chart.test.ts.snap
@@ -2773,7 +2773,11 @@ exports[`opening dock tab for installing helm chart given application is started
                 </span>
                 <span
                   class="value"
-                />
+                >
+                  <li>
+                    Some Foo&lt;some@foo.com&gt;
+                  </li>
+                </span>
               </div>
             </div>
           </div>
@@ -3676,7 +3680,11 @@ exports[`opening dock tab for installing helm chart given application is started
                 </span>
                 <span
                   class="value"
-                />
+                >
+                  <li>
+                    Some Foo&lt;some@foo.com&gt;
+                  </li>
+                </span>
               </div>
             </div>
           </div>
@@ -4589,7 +4597,11 @@ exports[`opening dock tab for installing helm chart given application is started
                 </span>
                 <span
                   class="value"
-                />
+                >
+                  <li>
+                    Some Foo&lt;some@foo.com&gt;
+                  </li>
+                </span>
               </div>
             </div>
           </div>
@@ -5492,7 +5504,11 @@ exports[`opening dock tab for installing helm chart given application is started
                 </span>
                 <span
                   class="value"
-                />
+                >
+                  <li>
+                    Some Foo&lt;some@foo.com&gt;
+                  </li>
+                </span>
               </div>
             </div>
           </div>
diff --git a/src/features/helm-charts/installing-chart/opening-dock-tab-for-installing-helm-chart.test.ts b/src/features/helm-charts/installing-chart/opening-dock-tab-for-installing-helm-chart.test.ts
index fa37f5d97f..c41a7f14ad 100644
--- a/src/features/helm-charts/installing-chart/opening-dock-tab-for-installing-helm-chart.test.ts
+++ b/src/features/helm-charts/installing-chart/opening-dock-tab-for-installing-helm-chart.test.ts
@@ -95,7 +95,10 @@ describe("opening dock tab for installing helm chart", () => {
             urls: [],
             annotations: {},
             dependencies: [],
-            maintainers: [],
+            maintainers: [{
+              email: "some@foo.com",
+              name: "Some Foo",
+            }],
             deprecated: false,
           }),
 
@@ -111,7 +114,10 @@ describe("opening dock tab for installing helm chart", () => {
             urls: [],
             annotations: {},
             dependencies: [],
-            maintainers: [],
+            maintainers: [{
+              email: "other@bar.com",
+              name: "Other Bar",
+            }],
             deprecated: false,
           }),
         ]);
@@ -162,7 +168,10 @@ describe("opening dock tab for installing helm chart", () => {
                 urls: [],
                 annotations: {},
                 dependencies: [],
-                maintainers: [],
+                maintainers: [{
+                  email: "some@foo.com",
+                  name: "Some Foo",
+                }],
                 deprecated: false,
               }),
 
@@ -178,7 +187,10 @@ describe("opening dock tab for installing helm chart", () => {
                 urls: [],
                 annotations: {},
                 dependencies: [],
-                maintainers: [],
+                maintainers: [{
+                  email: "other@bar.com",
+                  name: "Other Bar",
+                }],
                 deprecated: false,
               }),
             ]);
diff --git a/src/renderer/components/+helm-charts/helm-chart-details.tsx b/src/renderer/components/+helm-charts/helm-chart-details.tsx
index d15552dedb..cf2b781e66 100644
--- a/src/renderer/components/+helm-charts/helm-chart-details.tsx
+++ b/src/renderer/components/+helm-charts/helm-chart-details.tsx
@@ -117,16 +117,10 @@ class NonInjectedHelmChartDetails extends Component<HelmChartDetailsProps & Depe
             </a>
           </DrawerItem>
           <DrawerItem name="Maintainers" className="maintainers">
-            {selectedChart.getMaintainers().map(({ name, email, url }) => (
-              <a
-                key={name}
-                href={url || `mailto:${email}`}
-                target="_blank"
-                rel="noreferrer"
-              >
-                {name}
-              </a>
-            ))}
+            {selectedChart.getMaintainers()
+              .map(({ name, email }) => (
+                <li key={name}>{`${name}<${email}>`}</li>
+              ))}
           </DrawerItem>
           {selectedChart.getKeywords().length > 0 && (
             <DrawerItem name="Keywords" labelsOnly>