diff --git a/src/features/helm-charts/__snapshots__/add-custom-helm-repository-in-preferences.test.ts.snap b/src/features/helm-charts/__snapshots__/add-custom-helm-repository-in-preferences.test.ts.snap index a0bbe1e42f..5f2785c71f 100644 --- a/src/features/helm-charts/__snapshots__/add-custom-helm-repository-in-preferences.test.ts.snap +++ b/src/features/helm-charts/__snapshots__/add-custom-helm-repository-in-preferences.test.ts.snap @@ -154,13 +154,6 @@ exports[`add custom helm repository in preferences when navigating to preference -
-
-
@@ -803,13 +796,6 @@ exports[`add custom helm repository in preferences when navigating to preference -
-
-
@@ -1463,13 +1449,6 @@ exports[`add custom helm repository in preferences when navigating to preference -
-
-
@@ -2234,13 +2213,6 @@ exports[`add custom helm repository in preferences when navigating to preference -
-
-
@@ -2902,13 +2874,6 @@ exports[`add custom helm repository in preferences when navigating to preference -
-
-
@@ -3673,13 +3638,6 @@ exports[`add custom helm repository in preferences when navigating to preference -
-
-
@@ -4626,13 +4584,6 @@ exports[`add custom helm repository in preferences when navigating to preference -
-
-
@@ -5397,13 +5348,6 @@ exports[`add custom helm repository in preferences when navigating to preference -
-
-
@@ -6350,13 +6294,6 @@ exports[`add custom helm repository in preferences when navigating to preference -
-
-
@@ -7122,13 +7059,6 @@ exports[`add custom helm repository in preferences when navigating to preference -
-
-
@@ -7790,13 +7720,6 @@ exports[`add custom helm repository in preferences when navigating to preference -
-
-
@@ -8447,13 +8370,6 @@ exports[`add custom helm repository in preferences when navigating to preference -
-
-
diff --git a/src/features/helm-charts/__snapshots__/add-helm-repository-from-list-in-preferences.test.ts.snap b/src/features/helm-charts/__snapshots__/add-helm-repository-from-list-in-preferences.test.ts.snap index cf23e1226f..6eb612a968 100644 --- a/src/features/helm-charts/__snapshots__/add-helm-repository-from-list-in-preferences.test.ts.snap +++ b/src/features/helm-charts/__snapshots__/add-helm-repository-from-list-in-preferences.test.ts.snap @@ -154,13 +154,6 @@ exports[`add helm repository from list in preferences when navigating to prefere -
-
-
@@ -803,13 +796,6 @@ exports[`add helm repository from list in preferences when navigating to prefere -
-
-
@@ -1463,13 +1449,6 @@ exports[`add helm repository from list in preferences when navigating to prefere -
-
-
@@ -1969,7 +1948,7 @@ exports[`add helm repository from list in preferences when navigating to prefere />
-
-
-
@@ -2836,13 +2808,6 @@ exports[`add helm repository from list in preferences when navigating to prefere -
-
-
@@ -3496,13 +3461,6 @@ exports[`add helm repository from list in preferences when navigating to prefere -
-
-
@@ -4145,13 +4103,6 @@ exports[`add helm repository from list in preferences when navigating to prefere -
-
-
@@ -4839,13 +4790,6 @@ exports[`add helm repository from list in preferences when navigating to prefere -
-
-
@@ -5379,7 +5323,7 @@ exports[`add helm repository from list in preferences when navigating to prefere />
-
-
-
@@ -6290,13 +6227,6 @@ exports[`add helm repository from list in preferences when navigating to prefere -
-
-
diff --git a/src/features/helm-charts/__snapshots__/listing-active-helm-repositories-in-preferences.test.ts.snap b/src/features/helm-charts/__snapshots__/listing-active-helm-repositories-in-preferences.test.ts.snap index 43ba686edc..79c164ca99 100644 --- a/src/features/helm-charts/__snapshots__/listing-active-helm-repositories-in-preferences.test.ts.snap +++ b/src/features/helm-charts/__snapshots__/listing-active-helm-repositories-in-preferences.test.ts.snap @@ -154,13 +154,6 @@ exports[`listing active helm repositories in preferences when navigating to pref -
-
-
@@ -803,13 +796,6 @@ exports[`listing active helm repositories in preferences when navigating to pref -
-
-
@@ -1452,13 +1438,6 @@ exports[`listing active helm repositories in preferences when navigating to pref -
-
-
@@ -1993,13 +1972,6 @@ exports[`listing active helm repositories in preferences when navigating to pref -
-
-
@@ -2642,13 +2614,6 @@ exports[`listing active helm repositories in preferences when navigating to pref -
-
-
@@ -3183,13 +3148,6 @@ exports[`listing active helm repositories in preferences when navigating to pref -
-
-
@@ -3832,13 +3790,6 @@ exports[`listing active helm repositories in preferences when navigating to pref -
-
-
@@ -4526,13 +4477,6 @@ exports[`listing active helm repositories in preferences when navigating to pref -
-
-
@@ -5067,13 +5011,6 @@ exports[`listing active helm repositories in preferences when navigating to pref -
-
-
@@ -5608,13 +5545,6 @@ exports[`listing active helm repositories in preferences when navigating to pref -
-
-
diff --git a/src/features/helm-charts/__snapshots__/remove-helm-repository-from-list-of-active-repository-in-preferences.test.ts.snap b/src/features/helm-charts/__snapshots__/remove-helm-repository-from-list-of-active-repository-in-preferences.test.ts.snap index c8e42cc657..18e0054c7b 100644 --- a/src/features/helm-charts/__snapshots__/remove-helm-repository-from-list-of-active-repository-in-preferences.test.ts.snap +++ b/src/features/helm-charts/__snapshots__/remove-helm-repository-from-list-of-active-repository-in-preferences.test.ts.snap @@ -154,13 +154,6 @@ exports[`remove helm repository from list of active repositories in preferences -
-
-
@@ -803,13 +796,6 @@ exports[`remove helm repository from list of active repositories in preferences -
-
-
@@ -1463,13 +1449,6 @@ exports[`remove helm repository from list of active repositories in preferences -
-
-
@@ -2123,13 +2102,6 @@ exports[`remove helm repository from list of active repositories in preferences -
-
-
diff --git a/src/features/preferences/__snapshots__/closing-preferences.test.tsx.snap b/src/features/preferences/__snapshots__/closing-preferences.test.tsx.snap index 3debc25802..f87feb798c 100644 --- a/src/features/preferences/__snapshots__/closing-preferences.test.tsx.snap +++ b/src/features/preferences/__snapshots__/closing-preferences.test.tsx.snap @@ -165,13 +165,6 @@ exports[`preferences - closing-preferences given accessing preferences directly -
-
-
@@ -873,13 +866,6 @@ exports[`preferences - closing-preferences given accessing preferences directly -
-
-
@@ -1445,13 +1431,6 @@ exports[`preferences - closing-preferences given already in a page and then navi -
-
-
@@ -2153,13 +2132,6 @@ exports[`preferences - closing-preferences given already in a page and then navi -
-
-
diff --git a/src/features/preferences/__snapshots__/extension-adding-preference-tabs.test.tsx.snap b/src/features/preferences/__snapshots__/extension-adding-preference-tabs.test.tsx.snap index b54aded228..bffec4ec93 100644 --- a/src/features/preferences/__snapshots__/extension-adding-preference-tabs.test.tsx.snap +++ b/src/features/preferences/__snapshots__/extension-adding-preference-tabs.test.tsx.snap @@ -178,13 +178,6 @@ exports[`preferences: extension adding preference tabs given in preferences, whe -
-
-
diff --git a/src/features/preferences/__snapshots__/hiding-of-empty-branches.test.tsx.snap b/src/features/preferences/__snapshots__/hiding-of-empty-branches.test.tsx.snap index abd29f03bf..cb0752a608 100644 --- a/src/features/preferences/__snapshots__/hiding-of-empty-branches.test.tsx.snap +++ b/src/features/preferences/__snapshots__/hiding-of-empty-branches.test.tsx.snap @@ -153,20 +153,6 @@ exports[`preferences - hiding-of-empty-branches, given in preferences page given -
-
-
-
-
-
@@ -884,13 +870,6 @@ exports[`preferences - hiding-of-empty-branches, given in preferences page given -
-
-
@@ -1620,13 +1599,6 @@ exports[`preferences - hiding-of-empty-branches, given in preferences page given -
-
-
diff --git a/src/features/preferences/__snapshots__/navigation-to-application-preferences.test.ts.snap b/src/features/preferences/__snapshots__/navigation-to-application-preferences.test.ts.snap index 547102fcb4..fc951ae75a 100644 --- a/src/features/preferences/__snapshots__/navigation-to-application-preferences.test.ts.snap +++ b/src/features/preferences/__snapshots__/navigation-to-application-preferences.test.ts.snap @@ -153,13 +153,6 @@ exports[`preferences - navigation to application preferences given in some child -
-
-
@@ -501,13 +494,6 @@ exports[`preferences - navigation to application preferences given in some child -
-
-
@@ -1198,13 +1184,6 @@ exports[`preferences - navigation to application preferences given in some child -
-
-
diff --git a/src/features/preferences/__snapshots__/navigation-to-editor-preferences.test.ts.snap b/src/features/preferences/__snapshots__/navigation-to-editor-preferences.test.ts.snap index 23391e74a6..a21e6662c3 100644 --- a/src/features/preferences/__snapshots__/navigation-to-editor-preferences.test.ts.snap +++ b/src/features/preferences/__snapshots__/navigation-to-editor-preferences.test.ts.snap @@ -153,13 +153,6 @@ exports[`preferences - navigation to editor preferences given in preferences, wh -
-
-
@@ -849,13 +842,6 @@ exports[`preferences - navigation to editor preferences given in preferences, wh -
-
-
diff --git a/src/features/preferences/__snapshots__/navigation-to-extension-specific-preferences.test.tsx.snap b/src/features/preferences/__snapshots__/navigation-to-extension-specific-preferences.test.tsx.snap index 8365fb7a24..c10f9254eb 100644 --- a/src/features/preferences/__snapshots__/navigation-to-extension-specific-preferences.test.tsx.snap +++ b/src/features/preferences/__snapshots__/navigation-to-extension-specific-preferences.test.tsx.snap @@ -166,13 +166,6 @@ exports[`preferences - navigation to extension specific preferences given in pre -
-
-
@@ -875,13 +868,6 @@ exports[`preferences - navigation to extension specific preferences given in pre -
-
-
@@ -1208,13 +1194,6 @@ exports[`preferences - navigation to extension specific preferences given in pre -
-
-
@@ -1541,13 +1520,6 @@ exports[`preferences - navigation to extension specific preferences given in pre -
-
-
@@ -2202,13 +2174,6 @@ exports[`preferences - navigation to extension specific preferences given in pre -
-
-
@@ -3966,13 +3931,6 @@ exports[`preferences - navigation to extension specific preferences given in pre -
-
-
diff --git a/src/features/preferences/__snapshots__/navigation-to-kubernetes-preferences.test.ts.snap b/src/features/preferences/__snapshots__/navigation-to-kubernetes-preferences.test.ts.snap index ff95cc524a..9f7766f027 100644 --- a/src/features/preferences/__snapshots__/navigation-to-kubernetes-preferences.test.ts.snap +++ b/src/features/preferences/__snapshots__/navigation-to-kubernetes-preferences.test.ts.snap @@ -153,13 +153,6 @@ exports[`preferences - navigation to kubernetes preferences given in preferences -
-
-
@@ -849,13 +842,6 @@ exports[`preferences - navigation to kubernetes preferences given in preferences -
-
-
diff --git a/src/features/preferences/__snapshots__/navigation-to-proxy-preferences.test.ts.snap b/src/features/preferences/__snapshots__/navigation-to-proxy-preferences.test.ts.snap index 1c44934841..6661463ff4 100644 --- a/src/features/preferences/__snapshots__/navigation-to-proxy-preferences.test.ts.snap +++ b/src/features/preferences/__snapshots__/navigation-to-proxy-preferences.test.ts.snap @@ -153,13 +153,6 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe -
-
-
@@ -849,13 +842,6 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe -
-
-
diff --git a/src/features/preferences/__snapshots__/navigation-to-telemetry-preferences.test.tsx.snap b/src/features/preferences/__snapshots__/navigation-to-telemetry-preferences.test.tsx.snap index ec0afed8ff..3db1201033 100644 --- a/src/features/preferences/__snapshots__/navigation-to-telemetry-preferences.test.tsx.snap +++ b/src/features/preferences/__snapshots__/navigation-to-telemetry-preferences.test.tsx.snap @@ -165,13 +165,6 @@ exports[`preferences - navigation to telemetry preferences given URL for Sentry -
-
-
@@ -484,13 +477,6 @@ exports[`preferences - navigation to telemetry preferences given in preferences, -
-
-
@@ -1192,13 +1178,6 @@ exports[`preferences - navigation to telemetry preferences given in preferences, -
-
-
@@ -1900,13 +1879,6 @@ exports[`preferences - navigation to telemetry preferences given in preferences, -
-
-
@@ -2209,13 +2181,6 @@ exports[`preferences - navigation to telemetry preferences given no URL for Sent -
-
-
diff --git a/src/features/preferences/__snapshots__/navigation-to-terminal-preferences.test.ts.snap b/src/features/preferences/__snapshots__/navigation-to-terminal-preferences.test.ts.snap index 8ad4a3ea09..3af3331e05 100644 --- a/src/features/preferences/__snapshots__/navigation-to-terminal-preferences.test.ts.snap +++ b/src/features/preferences/__snapshots__/navigation-to-terminal-preferences.test.ts.snap @@ -153,13 +153,6 @@ exports[`preferences - navigation to terminal preferences given in preferences, -
-
-
@@ -849,13 +842,6 @@ exports[`preferences - navigation to terminal preferences given in preferences, -
-
-
diff --git a/src/features/preferences/__snapshots__/navigation-using-application-menu.test.ts.snap b/src/features/preferences/__snapshots__/navigation-using-application-menu.test.ts.snap index c80cd4abe3..815796b7cc 100644 --- a/src/features/preferences/__snapshots__/navigation-using-application-menu.test.ts.snap +++ b/src/features/preferences/__snapshots__/navigation-using-application-menu.test.ts.snap @@ -371,13 +371,6 @@ exports[`preferences - navigation using application menu when navigating to pref -
-
-
diff --git a/src/features/preferences/__snapshots__/navigation-using-tray.test.ts.snap b/src/features/preferences/__snapshots__/navigation-using-tray.test.ts.snap index ae29839693..731137c5e4 100644 --- a/src/features/preferences/__snapshots__/navigation-using-tray.test.ts.snap +++ b/src/features/preferences/__snapshots__/navigation-using-tray.test.ts.snap @@ -374,13 +374,6 @@ exports[`show-about-using-tray when navigating using tray renders 1`] = ` -
-
-
diff --git a/src/features/preferences/renderer/preference-navigation/preferences-navigation.tsx b/src/features/preferences/renderer/preference-navigation/preferences-navigation.tsx index d92ef030dd..82d49e2e47 100644 --- a/src/features/preferences/renderer/preference-navigation/preferences-navigation.tsx +++ b/src/features/preferences/renderer/preference-navigation/preferences-navigation.tsx @@ -38,11 +38,6 @@ export const PreferencesNavigation = withInjectables( ); const toNavigationHierarchy = (composite: Composite) => { - // Note: This makes tab groups and tabs without content not render anything in navigation. - if (!hasContent(composite)) { - return emptyRender; - } - const value = composite.value; switch (value.kind) { @@ -65,13 +60,14 @@ const toNavigationHierarchy = (composite: Composite + className="mr-3" /> )} {value.label} - {toNavigationHierarchy} + + {toNavigationHierarchy} + ); } @@ -84,7 +80,7 @@ const toNavigationHierarchy = (composite: Composite[]} + items={composite.children.filter(hasContent) as Composite[]} getSeparator={value.childSeparator} > {toNavigationHierarchy}