hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

address review comments for hotbarDisplayLabel()

Browse Source 
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
This commit is contained in:
Jim Ehrismann 2021-05-14 10:26:40 -04:00
parent 87f583cbb4
commit 06ca020c61
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/renderer/components/hotbar/hotbar-display-label.ts
View File

@ -21,14 +21,14 @@
import { HotbarStore } from "../../../common/hotbar-store"; import { HotbarStore } from "../../../common/hotbar-store";
export function hotbarDisplayLabel(id: string, withName = false) : string { export function hotbarDisplayLabel(id: string, withName = true) : string {
const hotbarStore = HotbarStore.getInstance(); const hotbarStore = HotbarStore.getInstance();
const index = hotbarStore.hotbarIndex(id) + 1; const index = hotbarStore.hotbarIndex(id) + 1;
if (withName) { if (withName) {
const hotbar = hotbarStore.getById(id); const hotbar = hotbarStore.getById(id);
return [ index, ": ", hotbar.name ].join(""); return `${index}: ${hotbar.name}`;
} }
return index.toString(); return index.toString();

2
src/renderer/components/hotbar/hotbar-remove-command.tsx
View File

@ -32,7 +32,7 @@ import { ConfirmDialog } from "../confirm-dialog";
export class HotbarRemoveCommand extends React.Component { export class HotbarRemoveCommand extends React.Component {
@computed get options() { @computed get options() {
return HotbarStore.getInstance().hotbars.map((hotbar) => { return HotbarStore.getInstance().hotbars.map((hotbar) => {
return { value: hotbar.id, label: hotbarDisplayLabel(hotbar.id, true) }; return { value: hotbar.id, label: hotbarDisplayLabel(hotbar.id) };
}); });
} }

2
src/renderer/components/hotbar/hotbar-selector.tsx
View File

@ -44,7 +44,7 @@ export function HotbarSelector({ hotbar }: Props) {
<Badge <Badge
id="hotbarIndex" id="hotbarIndex"
small small
label={hotbarDisplayLabel(store.activeHotbarId)} label={hotbarDisplayLabel(store.activeHotbarId, false)}
onClick={() => CommandOverlay.open(<HotbarSwitchCommand />)} onClick={() => CommandOverlay.open(<HotbarSwitchCommand />)}
/> />
</MaterialTooltip> </MaterialTooltip>

2
src/renderer/components/hotbar/hotbar-switch-command.tsx
View File

@ -37,7 +37,7 @@ export class HotbarSwitchCommand extends React.Component {
@computed get options() { @computed get options() {
const hotbarStore = HotbarStore.getInstance(); const hotbarStore = HotbarStore.getInstance();
const options = hotbarStore.hotbars.map((hotbar) => { const options = hotbarStore.hotbars.map((hotbar) => {
return { value: hotbar.id, label: hotbarDisplayLabel(hotbar.id, true) }; return { value: hotbar.id, label: hotbarDisplayLabel(hotbar.id) };
}); });
options.push({ value: HotbarSwitchCommand.addActionId, label: "Add hotbar ..." }); options.push({ value: HotbarSwitchCommand.addActionId, label: "Add hotbar ..." });