Fix Cluster.refresh sometimes taking upwards of 20s (#4826)

- Only read and parse the proxy config once

- Reuse the AuthorizationV1Api instance for the entire refresh instead
  of recreating it between 32 and 302 times, this should allow for
  reusing sockets

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/main/__test__/cluster.test.ts

@@ -39,6 +39,8 @@ import { Kubectl } from "../kubectl/kubectl";
 import { getDiForUnitTesting } from "../getDiForUnitTesting";
 import type { ClusterModel } from "../../common/cluster-types";
 import { createClusterInjectionToken } from "../../common/cluster/create-cluster-injection-token";
+import authorizationReviewInjectable from "../../common/cluster/authorization-review.injectable";
+import listNamespacesInjectable from "../../common/cluster/list-namespaces.injectable";
 
 console = new Console(process.stdout, process.stderr); // fix mockFS
 
@@ -77,6 +79,9 @@ describe("create clusters", () => {
 
     await di.runSetups();
 
+    di.override(authorizationReviewInjectable, () => () => () => Promise.resolve(true));
+    di.override(listNamespacesInjectable, () => () => () => Promise.resolve([ "default" ]));
+
     createCluster = di.inject(createClusterInjectionToken);
 
     jest.spyOn(Kubectl.prototype, "ensureKubectl").mockReturnValue(Promise.resolve(true));
@@ -117,7 +122,6 @@ describe("create clusters", () => {
     } as any;
 
     jest.spyOn(cluster, "reconnect");
-    jest.spyOn(cluster, "canI");
     jest.spyOn(cluster, "refreshConnectionStatus");
 
     await cluster.activate();

src/main/create-cluster/create-cluster.injectable.ts

@@ -3,24 +3,27 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 import { getInjectable, lifecycleEnum } from "@ogre-tools/injectable";
-import type { ClusterModel } from "../../common/cluster-types";
-import { Cluster } from "../../common/cluster/cluster";
+import { Cluster, ClusterDependencies } from "../../common/cluster/cluster";
 import directoryForKubeConfigsInjectable from "../../common/app-paths/directory-for-kube-configs/directory-for-kube-configs.injectable";
 import createKubeconfigManagerInjectable from "../kubeconfig-manager/create-kubeconfig-manager.injectable";
 import createKubectlInjectable from "../kubectl/create-kubectl.injectable";
 import createContextHandlerInjectable from "../context-handler/create-context-handler.injectable";
 import { createClusterInjectionToken } from "../../common/cluster/create-cluster-injection-token";
+import authorizationReviewInjectable from "../../common/cluster/authorization-review.injectable";
+import listNamespacesInjectable from "../../common/cluster/list-namespaces.injectable";
 
 const createClusterInjectable = getInjectable({
   instantiate: (di) => {
-    const dependencies = {
+    const dependencies: ClusterDependencies = {
       directoryForKubeConfigs: di.inject(directoryForKubeConfigsInjectable),
       createKubeconfigManager: di.inject(createKubeconfigManagerInjectable),
       createKubectl: di.inject(createKubectlInjectable),
       createContextHandler: di.inject(createContextHandlerInjectable),
+      createAuthorizationReview: di.inject(authorizationReviewInjectable),
+      createListNamespaces: di.inject(listNamespacesInjectable),
     };
 
-    return (model: ClusterModel) => new Cluster(dependencies, model);
+    return (model) => new Cluster(dependencies, model);
   },
 
   injectionToken: createClusterInjectionToken,