From 0759b804350271b4b8368f619e37b2b65adb56a2 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Mon, 1 Nov 2021 08:37:49 -0400 Subject: [PATCH] Lint: space-before-function-paren (error) (#4199) --- .eslintrc.js | 17 +++++++++++++++++ src/common/utils/buildUrl.ts | 2 +- .../+service-accounts/details.tsx | 2 +- src/renderer/components/dock/terminal.store.ts | 2 +- src/renderer/utils/interval.ts | 6 +++--- 5 files changed, 23 insertions(+), 6 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 8351d1b973..3c4e5a23b7 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -59,6 +59,11 @@ module.exports = { "SwitchCase": 1, }], "no-unused-vars": "off", + "space-before-function-paren": ["error", { + "anonymous": "always", + "named": "never", + "asyncArrow": "always", + }], "unused-imports/no-unused-imports": "error", "unused-imports/no-unused-vars": [ "warn", { @@ -117,6 +122,12 @@ module.exports = { "@typescript-eslint/ban-ts-comment": "off", "@typescript-eslint/no-empty-interface": "off", "@typescript-eslint/no-unused-vars": "off", + "space-before-function-paren": "off", + "@typescript-eslint/space-before-function-paren": ["error", { + "anonymous": "always", + "named": "never", + "asyncArrow": "always", + }], "unused-imports/no-unused-imports-ts": process.env.PROD === "true" ? "error" : "warn", "unused-imports/no-unused-vars-ts": [ "warn", { @@ -188,6 +199,12 @@ module.exports = { "@typescript-eslint/no-empty-function": "off", "react/display-name": "off", "@typescript-eslint/no-unused-vars": "off", + "space-before-function-paren": "off", + "@typescript-eslint/space-before-function-paren": ["error", { + "anonymous": "always", + "named": "never", + "asyncArrow": "always", + }], "unused-imports/no-unused-imports-ts": process.env.PROD === "true" ? "error" : "warn", "unused-imports/no-unused-vars-ts": [ "warn", { diff --git a/src/common/utils/buildUrl.ts b/src/common/utils/buildUrl.ts index 20e6e7e861..03909917eb 100644 --- a/src/common/utils/buildUrl.ts +++ b/src/common/utils/buildUrl.ts @@ -45,7 +45,7 @@ export function buildURL

(path: str export function buildURLPositional

(path: string | any) { const builder = buildURL(path); - return function(params?: P, query?: Q, fragment?: string): string { + return function (params?: P, query?: Q, fragment?: string): string { return builder({ params, query, fragment }); }; } diff --git a/src/renderer/components/+user-management/+service-accounts/details.tsx b/src/renderer/components/+user-management/+service-accounts/details.tsx index ee19079c40..ce1352f705 100644 --- a/src/renderer/components/+user-management/+service-accounts/details.tsx +++ b/src/renderer/components/+user-management/+service-accounts/details.tsx @@ -59,7 +59,7 @@ export class ServiceAccountsDetails extends React.Component { }); this.secrets = await Promise.all(secrets); - const imagePullSecrets = serviceAccount.getImagePullSecrets().map(async({ name }) => { + const imagePullSecrets = serviceAccount.getImagePullSecrets().map(async ({ name }) => { return secretsStore.load({ name, namespace }).catch(() => this.generateDummySecretObject(name)); }); diff --git a/src/renderer/components/dock/terminal.store.ts b/src/renderer/components/dock/terminal.store.ts index b5116a94e8..0f4ec7e8ba 100644 --- a/src/renderer/components/dock/terminal.store.ts +++ b/src/renderer/components/dock/terminal.store.ts @@ -165,7 +165,7 @@ export const terminalStore = new Proxy({}, { const res = (ts as any)?.[p]; if (typeof res === "function") { - return function(...args: any[]) { + return function (...args: any[]) { return res.apply(ts, args); }; } diff --git a/src/renderer/utils/interval.ts b/src/renderer/utils/interval.ts index bd33131a67..65c000fe4e 100644 --- a/src/renderer/utils/interval.ts +++ b/src/renderer/utils/interval.ts @@ -28,7 +28,7 @@ export function interval(timeSec = 1, callback: IntervalCallback, autoRun = fals let timer = -1; let isRunning = false; const intervalManager = { - start (runImmediately = false) { + start(runImmediately = false) { if (isRunning) return; const tick = () => callback(++count); @@ -36,12 +36,12 @@ export function interval(timeSec = 1, callback: IntervalCallback, autoRun = fals timer = window.setInterval(tick, 1000 * timeSec); if (runImmediately) tick(); }, - stop () { + stop() { count = 0; isRunning = false; clearInterval(timer); }, - restart (runImmediately = false) { + restart(runImmediately = false) { this.stop(); this.start(runImmediately); },