Show extension preferences in separate page (#5284)

Co-authored-by: Alex Andreev <alex.andreev.email@gmail.com>
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

src/common/front-end-routing/routes/preferences/extension/extension-preferences-route.injectable.ts

@@ -5,12 +5,18 @@
 import { getInjectable } from "@ogre-tools/injectable";
 import { computed } from "mobx";
 import { frontEndRouteInjectionToken } from "../../../front-end-route-injection-token";
+import type { Route } from "../../../front-end-route-injection-token";
+
+interface ExtensionPreferenceRouteParams {
+  extensionId: string;
+  tabId?: string;
+}
 
 const extensionPreferencesRouteInjectable = getInjectable({
   id: "extension-preferences-route",
 
-  instantiate: () => ({
-    path: "/preferences/extensions",
+  instantiate: (): Route<ExtensionPreferenceRouteParams> => ({
+    path: "/preferences/extension/:extensionId/:tabId?",
     clusterFrame: false,
     isEnabled: computed(() => true),
   }),

src/common/front-end-routing/routes/preferences/extension/navigate-to-extension-preferences.injectable.ts

@@ -13,7 +13,10 @@ const navigateToExtensionPreferencesInjectable = getInjectable({
     const navigateToRoute = di.inject(navigateToRouteInjectionToken);
     const route = di.inject(extensionPreferencesRouteInjectable);
 
-    return () => navigateToRoute(route);
+    return (extensionId: string, tabId?: string) => navigateToRoute(route, { parameters: {
+      extensionId,
+      tabId,
+    }});
   },
 });
 

src/common/runnable/run-many-for.test.ts

@@ -15,7 +15,7 @@ describe("runManyFor", () => {
     let actualPromise: Promise<void>;
 
     beforeEach(() => {
-      const rootDi = createContainer();
+      const rootDi = createContainer("irrelevant");
 
       runMock = asyncFn();
 
@@ -67,7 +67,7 @@ describe("runManyFor", () => {
     let actualPromise: Promise<void>;
 
     beforeEach(() => {
-      const di = createContainer();
+      const di = createContainer("irrelevant");
 
       runMock = asyncFn();
 
@@ -170,7 +170,7 @@ describe("runManyFor", () => {
   });
 
   it("given invalid hierarchy, when running runnables, throws", () => {
-    const rootDi = createContainer();
+    const rootDi = createContainer("irrelevant");
 
     const runMock = asyncFn<(...args: unknown[]) => void>();
 
@@ -218,7 +218,7 @@ describe("runManyFor", () => {
     let runMock: AsyncFnMock<(...args: unknown[]) => Promise<void>>;
 
     beforeEach(() => {
-      const rootDi = createContainer();
+      const rootDi = createContainer("irrelevant");
 
       runMock = asyncFn();
 

src/common/runnable/run-many-sync-for.test.ts

@@ -11,7 +11,7 @@ describe("runManySyncFor", () => {
     let runMock: jest.Mock;
 
     beforeEach(() => {
-      const rootDi = createContainer();
+      const rootDi = createContainer("irrelevant");
 
       runMock = jest.fn();
 
@@ -50,7 +50,7 @@ describe("runManySyncFor", () => {
     let runMock: jest.Mock<(arg: string) => void>;
 
     beforeEach(() => {
-      const di = createContainer();
+      const di = createContainer("irrelevant");
 
       runMock = jest.fn();
 
@@ -99,7 +99,7 @@ describe("runManySyncFor", () => {
   });
 
   it("given invalid hierarchy, when running runnables, throws", () => {
-    const rootDi = createContainer();
+    const rootDi = createContainer("irrelevant");
 
     const runMock = jest.fn();
 
@@ -147,7 +147,7 @@ describe("runManySyncFor", () => {
     let runMock: jest.Mock<(arg: string, arg2: string) => void>;
 
     beforeEach(() => {
-      const rootDi = createContainer();
+      const rootDi = createContainer("irrelevant");
 
       runMock = jest.fn();