hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Add comment

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2023-03-01 08:09:33 -05:00
parent 64b53e606c
commit 087bac5149
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/core/src/extensions/install-extension/install-extension.injectable.ts
View File

@ -65,6 +65,16 @@ const installExtensionInjectable = getInjectable({
const packageJsonPath = joinPaths(extensionPackageRootDirectory, "package.json"); const packageJsonPath = joinPaths(extensionPackageRootDirectory, "package.json");
/**
* NOTES:
* - We have to keep the `package.json` because `npm install` removes files from `node_modules`
* if they are no longer in the `package.json`
* - In v6.2.X we saved bundled extensions as `"dependencies"` and external extensions as
* `"optionalDependencies"` at startup. This was done because `"optionalDependencies"` can
* fail to install and that is OK.
* - We continue to maintain this behavior here by only installing new dependencies as
* `"optionalDependencies"`
*/
const fixupPackageJson = once(async () => { const fixupPackageJson = once(async () => {
try { try {
const packageJson = await readJsonFile(packageJsonPath) as PackageJson; const packageJson = await readJsonFile(packageJsonPath) as PackageJson;