From 0928d4c2b12f93af74c24078a672dd32f483d40a Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Thu, 2 Jun 2022 09:09:28 -0400 Subject: [PATCH] Remove renderToDOM and inline the single use Signed-off-by: Sebastian Malton --- src/renderer/components/tooltip/tooltip.tsx | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/renderer/components/tooltip/tooltip.tsx b/src/renderer/components/tooltip/tooltip.tsx index f8a4898efc..e13e8d3680 100644 --- a/src/renderer/components/tooltip/tooltip.tsx +++ b/src/renderer/components/tooltip/tooltip.tsx @@ -10,7 +10,7 @@ import { createPortal } from "react-dom"; import { observer } from "mobx-react"; import type { IClassName } from "../../utils"; import { cssNames, autoBind } from "../../utils"; -import { observable, makeObservable, action, computed } from "mobx"; +import { observable, makeObservable, action } from "mobx"; export enum TooltipPosition { TOP = "top", @@ -64,10 +64,6 @@ export class Tooltip extends React.Component { autoBind(this); } - @computed get renderToDOM() { - return this.props.visible ?? this.isVisible; - } - get targetElem(): HTMLElement | null { return document.getElementById(this.props.targetId); } @@ -221,11 +217,12 @@ export class Tooltip extends React.Component { } render() { - if (!this.renderToDOM) { + const { style, formatters, usePortal, children, visible = this.isVisible } = this.props; + + if (!visible) { return null; } - const { style, formatters, usePortal, children } = this.props; const className = cssNames("Tooltip", this.props.className, formatters, this.activePosition, { visible: this.isContentVisible || this.props.visible, formatter: !!formatters,