mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
Prevent creation of dynamic components where withInjectables use type parameters to make React not re-mount because of dynamic components being different (#4808)
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
1 parent
6ebfd76644
commit
09824a6e01
3 files changed
+44
-42
No files matched your search
@@ -246,18 +246,18 @@ class NonInjectedTable<Item> extends React.Component<TableProps<Item> & Dependen
|
||||
}
|
||||
}
|
||||
|
||||
const InjectedTable = withInjectables<Dependencies, TableProps<any>>(
|
||||
NonInjectedTable,
|
||||
|
||||
{
|
||||
getProps: (di, props) => ({
|
||||
model: di.inject(tableModelInjectable),
|
||||
...props,
|
||||
}),
|
||||
},
|
||||
);
|
||||
|
||||
export function Table<Item>(props: TableProps<Item>) {
|
||||
const InjectedTable = withInjectables<Dependencies, TableProps<Item>>(
|
||||
NonInjectedTable,
|
||||
|
||||
{
|
||||
getProps: (di, props) => ({
|
||||
model: di.inject(tableModelInjectable),
|
||||
...props,
|
||||
}),
|
||||
},
|
||||
);
|
||||
|
||||
return <InjectedTable {...props} />;
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user