diff --git a/src/extensions/__tests__/extension-compatibility.test.ts b/src/extensions/__tests__/extension-compatibility.test.ts index d8e789a9d9..89938a1cd3 100644 --- a/src/extensions/__tests__/extension-compatibility.test.ts +++ b/src/extensions/__tests__/extension-compatibility.test.ts @@ -39,9 +39,9 @@ describe("extension compatibility", () => { it("has no extension comparator", () => { const manifest = { name: "extensionName", version: "0.0.1"}; - expect(isCompatibleExtension(manifest,)).toBe(false); + expect(isCompatibleExtension(manifest, false)).toBe(false); }); - + it.each([ { comparator: "", @@ -78,7 +78,7 @@ describe("extension compatibility", () => { ])("extension comparator test: %p", ({ comparator, expected }) => { const manifest: LensExtensionManifest = { name: "extensionName", version: "0.0.1", engines: { lens: comparator}}; - expect(isCompatibleExtension(manifest,)).toBe(expected); + expect(isCompatibleExtension(manifest, false)).toBe(expected); }); }); @@ -89,13 +89,13 @@ describe("extension compatibility", () => { appSemVer.patch = 3; appSemVer.prerelease = ["beta", 3]; }); - + it("has no extension comparator", () => { const manifest = { name: "extensionName", version: "0.0.1"}; - expect(isCompatibleExtension(manifest,)).toBe(false); + expect(isCompatibleExtension(manifest, false)).toBe(false); }); - + it.each([ { comparator: "", @@ -132,7 +132,7 @@ describe("extension compatibility", () => { ])("extension comparator test: %p", ({ comparator, expected }) => { const manifest: LensExtensionManifest = { name: "extensionName", version: "0.0.1", engines: { lens: comparator}}; - expect(isCompatibleExtension(manifest,)).toBe(expected); + expect(isCompatibleExtension(manifest, false)).toBe(expected); }); }); }); diff --git a/src/extensions/extension-compatibility.ts b/src/extensions/extension-compatibility.ts index adc5f054e3..9208f4ab9e 100644 --- a/src/extensions/extension-compatibility.ts +++ b/src/extensions/extension-compatibility.ts @@ -25,6 +25,7 @@ import type { LensExtensionManifest } from "./lens-extension"; export function isCompatibleExtension(manifest: LensExtensionManifest, isBundled: boolean): boolean { if (manifest.engines?.lens) { + // We only started having bundled extensions specify the engine in v5 if (isBundled) { return true; }