From 09eee8179759b0d122e33c06be91f314a9be86e2 Mon Sep 17 00:00:00 2001 From: Jim Ehrismann Date: Fri, 4 Mar 2022 11:46:28 -0500 Subject: [PATCH] Disconnect cluster in onbeforeunload() Signed-off-by: Jim Ehrismann --- .../cluster-frame/init-cluster-frame/init-cluster-frame.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/renderer/frames/cluster-frame/init-cluster-frame/init-cluster-frame.ts b/src/renderer/frames/cluster-frame/init-cluster-frame/init-cluster-frame.ts index 97f2f40565..41c76527d7 100644 --- a/src/renderer/frames/cluster-frame/init-cluster-frame/init-cluster-frame.ts +++ b/src/renderer/frames/cluster-frame/init-cluster-frame/init-cluster-frame.ts @@ -10,10 +10,9 @@ import { Notifications } from "../../../components/notifications"; import type { AppEvent } from "../../../../common/app-event-bus/event-bus"; import type { CatalogEntity } from "../../../../common/catalog"; import { when } from "mobx"; -import { unmountComponentAtNode } from "react-dom"; import type { ClusterFrameContext } from "../../../cluster-frame-context/cluster-frame-context"; import { KubeObjectStore } from "../../../../common/k8s-api/kube-object.store"; -import { requestSetClusterFrameId } from "../../../ipc"; +import { requestClusterDisconnection, requestSetClusterFrameId } from "../../../ipc"; interface Dependencies { hostedCluster: Cluster; @@ -30,7 +29,7 @@ const logPrefix = "[CLUSTER-FRAME]:"; export const initClusterFrame = ({ hostedCluster, loadExtensions, catalogEntityRegistry, frameRoutingId, emitEvent, clusterFrameContext }: Dependencies) => - async (rootElem: HTMLElement) => { + async () => { // TODO: Make catalogEntityRegistry already initialized when passed as dependency catalogEntityRegistry.init(); @@ -84,7 +83,7 @@ export const initClusterFrame = `${logPrefix} Unload dashboard, clusterId=${(hostedCluster.id)}, frameId=${frameRoutingId}`, ); - unmountComponentAtNode(rootElem); + requestClusterDisconnection(hostedCluster.id); }; // TODO: Make context dependency of KubeObjectStore