Remove usage of deprecated xtermjs's registerLinkMatcher API (#5996)

* Make openBrowser->openLinkInBrowser injectable

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Remove use of deprecated link matcher API from XtermJS

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix type errors

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/common/utils/index.ts

@@ -22,7 +22,6 @@ export * from "./hash-set";
 export * from "./n-fircate";
 export * from "./noop";
 export * from "./observable-crate/impl";
-export * from "./openBrowser";
 export * from "./paths";
 export * from "./promise-exec";
 export * from "./readonly";

src/common/utils/open-link-in-browser.global-override-for-injectable.ts

@@ -0,0 +1,9 @@
+/**
+ * Copyright (c) OpenLens Authors. All rights reserved.
+ * Licensed under MIT License. See LICENSE in root directory for more information.
+ */
+
+import { getGlobalOverride } from "../test-utils/get-global-override";
+import openLinkInBrowserInjectable from "./open-link-in-browser.injectable";
+
+export default getGlobalOverride(openLinkInBrowserInjectable, () => async () => {});

src/common/utils/open-link-in-browser.injectable.ts

@@ -0,0 +1,28 @@
+/**
+ * Copyright (c) OpenLens Authors. All rights reserved.
+ * Licensed under MIT License. See LICENSE in root directory for more information.
+ */
+import { getInjectable } from "@ogre-tools/injectable";
+import { shell } from "electron";
+
+const allowedProtocols =  new Set(["http:", "https:"]);
+
+export type OpenLinkInBrowser = (url: string) => Promise<void>;
+
+const openLinkInBrowserInjectable = getInjectable({
+  id: "open-link-in-browser",
+  instantiate: (): OpenLinkInBrowser => (
+    async (url) => {
+      const { protocol } = new URL(url);
+
+      if (!allowedProtocols.has(protocol)) {
+        throw new TypeError("not an http(s) URL");
+      }
+
+      await shell.openExternal(url);
+    }
+  ),
+  causesSideEffects: true,
+});
+
+export default openLinkInBrowserInjectable;

src/common/utils/openBrowser.ts

@@ -1,29 +0,0 @@
-/**
- * Copyright (c) OpenLens Authors. All rights reserved.
- * Licensed under MIT License. See LICENSE in root directory for more information.
- */
-
-import { shell } from "electron";
-
-const allowedProtocols =  new Set(["http:", "https:"]);
-
-/**
- * Opens a link using the program configured as the default browser
- * on the target platform. Will reject URLs with a scheme other than
- * http or https to prevent programs other than the default browser
- * running.
- *
- * @param url The URL to open
- */
-export function openBrowser(url: string): Promise<void> {
-  if (allowedProtocols.has(new URL(url).protocol)) {
-    return shell.openExternal(url);
-  }
-
-  return Promise.reject(new TypeError("not an http(s) URL"));
-}
-
-/**
- * @deprecated use openBrowser
- */
-export const openExternal = openBrowser;