Remove usage of deprecated xtermjs's registerLinkMatcher API (#5996)

* Make openBrowser->openLinkInBrowser injectable

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Remove use of deprecated link matcher API from XtermJS

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix type errors

Signed-off-by: Sebastian Malton <sebastian@malton.name>

src/renderer/port-forward/open-port-forward.injectable.ts

@@ -0,0 +1,38 @@
+/**
+ * Copyright (c) OpenLens Authors. All rights reserved.
+ * Licensed under MIT License. See LICENSE in root directory for more information.
+ */
+import { getInjectable } from "@ogre-tools/injectable";
+import loggerInjectable from "../../common/logger.injectable";
+import openLinkInBrowserInjectable from "../../common/utils/open-link-in-browser.injectable";
+import showErrorNotificationInjectable from "../components/notifications/show-error-notification.injectable";
+import type { ForwardedPort } from "./port-forward-item";
+import { portForwardAddress } from "./port-forward-utils";
+
+export type OpenPortForward = (portForward: ForwardedPort) => void;
+
+const openPortForwardInjectable = getInjectable({
+  id: "open-port-forward",
+  instantiate: (di): OpenPortForward => {
+    const openLinkInBrowser = di.inject(openLinkInBrowserInjectable);
+    const showErrorNotification = di.inject(showErrorNotificationInjectable);
+    const logger = di.inject(loggerInjectable);
+
+    return (portForward) => {
+      const browseTo = portForwardAddress(portForward);
+
+      openLinkInBrowser(browseTo)
+        .catch(error => {
+          logger.error(`failed to open in browser: ${error}`, {
+            port: portForward.port,
+            kind: portForward.kind,
+            namespace: portForward.namespace,
+            name: portForward.name,
+          });
+          showErrorNotification(`Failed to open ${browseTo} in browser`);
+        });
+    };
+  },
+});
+
+export default openPortForwardInjectable;

src/renderer/port-forward/port-forward-dialog.tsx

@@ -14,7 +14,6 @@ import { Wizard, WizardStep } from "../components/wizard";
 import { Input } from "../components/input";
 import { cssNames } from "../utils";
 import type { PortForwardStore } from "./port-forward-store/port-forward-store";
-import { openPortForward } from "./port-forward-utils";
 import { Checkbox } from "../components/checkbox";
 import { withInjectables } from "@ogre-tools/injectable-react";
 import type { PortForwardDialogData, PortForwardDialogModel } from "./port-forward-dialog-model/port-forward-dialog-model";
@@ -23,6 +22,8 @@ import logger from "../../common/logger";
 import portForwardStoreInjectable from "./port-forward-store/port-forward-store.injectable";
 import aboutPortForwardingInjectable from "./about-port-forwarding.injectable";
 import notifyErrorPortForwardingInjectable from "./notify-error-port-forwarding.injectable";
+import type { OpenPortForward } from "./open-port-forward.injectable";
+import openPortForwardInjectable from "./open-port-forward.injectable";
 
 export interface PortForwardDialogProps extends Partial<DialogProps> {}
 
@@ -31,6 +32,7 @@ interface Dependencies {
   model: PortForwardDialogModel;
   aboutPortForwarding: () => void;
   notifyErrorPortForwarding: (message: string) => void;
+  openPortForward: OpenPortForward;
 }
 
 @observer
@@ -89,7 +91,7 @@ class NonInjectedPortForwardDialog extends Component<PortForwardDialogProps & De
       }
 
       if (portForward.status === "Active" && data.openInBrowser) {
-        openPortForward(portForward);
+        this.props.openPortForward(portForward);
       }
     } catch (error) {
       logger.error(`[PORT-FORWARD-DIALOG]: ${error}`, portForward);
@@ -177,6 +179,7 @@ export const PortForwardDialog = withInjectables<Dependencies, PortForwardDialog
       model: di.inject(portForwardDialogModelInjectable),
       aboutPortForwarding: di.inject(aboutPortForwardingInjectable),
       notifyErrorPortForwarding: di.inject(notifyErrorPortForwardingInjectable),
+      openPortForward: di.inject(openPortForwardInjectable),
       ...props,
     }),
   },

src/renderer/port-forward/port-forward-utils.ts

@@ -3,34 +3,12 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 
-
-import { openBrowser } from "../utils";
-import { Notifications } from "../components/notifications";
 import type { ForwardedPort } from "./port-forward-item";
-import logger from "../../common/logger";
 
 export function portForwardAddress(portForward: ForwardedPort) {
   return `${portForward.protocol ?? "http"}://localhost:${portForward.forwardPort}`;
 }
 
-export function openPortForward(portForward: ForwardedPort) {
-  const browseTo = portForwardAddress(portForward);
-
-  openBrowser(browseTo)
-    .catch(error => {
-      logger.error(`failed to open in browser: ${error}`, {
-        port: portForward.port,
-        kind: portForward.kind,
-        namespace: portForward.namespace,
-        name: portForward.name,
-      });
-      Notifications.error(`Failed to open ${browseTo} in browser`);
-    },
-    );
-
-}
-
 export function predictProtocol(name: string | undefined) {
   return name === "https" ? "https" : "http";
 }
-