From 0a7aacd3f25cd73be1cc7d5a4d974034cb086f12 Mon Sep 17 00:00:00 2001 From: Janne Savolainen Date: Wed, 6 Jul 2022 11:15:36 +0300 Subject: [PATCH] Make MenuActions deterministic in unit tests Signed-off-by: Janne Savolainen --- .../order-of-sidebar-items.test.tsx.snap | 14 ++--- ...-and-tab-navigation-for-core.test.tsx.snap | 54 +++++++++---------- ...ab-navigation-for-extensions.test.tsx.snap | 16 +++--- .../visibility-of-sidebar-items.test.tsx.snap | 14 ++--- .../navigation-to-helm-charts.test.ts.snap | 8 +-- .../+catalog/catalog-entity-drawer-menu.tsx | 1 + src/renderer/components/+catalog/catalog.tsx | 2 +- .../+extensions/installed-extensions.tsx | 5 +- .../+helm-releases/release-menu.tsx | 1 + .../port-forward-menu.tsx | 9 ++-- .../components/cluster-icon-settings.tsx | 1 + src/renderer/components/dock/dock.tsx | 1 + .../components/item-object-list/content.tsx | 1 + .../kube-object-menu.test.tsx.snap | 7 +++ .../kube-object-menu/kube-object-menu.tsx | 1 + src/renderer/components/menu/menu-actions.tsx | 15 +++--- .../__snapshots__/cluster-frame.test.tsx.snap | 22 ++++---- 17 files changed, 94 insertions(+), 78 deletions(-) diff --git a/src/behaviours/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap b/src/behaviours/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap index e1db29fca1..1d2b889363 100644 --- a/src/behaviours/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap +++ b/src/behaviours/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap @@ -524,7 +524,7 @@ exports[`cluster - order of sidebar items when rendered renders 1`] = ` > @@ -1028,7 +1028,7 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit > @@ -1604,7 +1604,7 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit > @@ -2103,7 +2103,7 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit > @@ -2602,7 +2602,7 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit > @@ -3060,7 +3060,7 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit > @@ -3636,7 +3636,7 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit > @@ -4172,7 +4172,7 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit > diff --git a/src/behaviours/cluster/__snapshots__/visibility-of-sidebar-items.test.tsx.snap b/src/behaviours/cluster/__snapshots__/visibility-of-sidebar-items.test.tsx.snap index 48ce69934a..cd7e67604d 100644 --- a/src/behaviours/cluster/__snapshots__/visibility-of-sidebar-items.test.tsx.snap +++ b/src/behaviours/cluster/__snapshots__/visibility-of-sidebar-items.test.tsx.snap @@ -463,7 +463,7 @@ exports[`cluster - visibility of sidebar items given kube resource for route is > extends React. return ( { }; return ( - + this.props.catalogEntityStore.selectedItemId.set(entity.getId())} diff --git a/src/renderer/components/+extensions/installed-extensions.tsx b/src/renderer/components/+extensions/installed-extensions.tsx index 2de88642e2..e69c7c7205 100644 --- a/src/renderer/components/+extensions/installed-extensions.tsx +++ b/src/renderer/components/+extensions/installed-extensions.tsx @@ -102,7 +102,10 @@ const NonInjectedInstalledExtensions = observer(({ extensionDiscovery, extension ), actions: ( - + {isCompatible && ( <> {isEnabled ? ( diff --git a/src/renderer/components/+helm-releases/release-menu.tsx b/src/renderer/components/+helm-releases/release-menu.tsx index 511b104600..c0366624c8 100644 --- a/src/renderer/components/+helm-releases/release-menu.tsx +++ b/src/renderer/components/+helm-releases/release-menu.tsx @@ -78,6 +78,7 @@ class NonInjectedHelmReleaseMenu extends React.Component Stop @@ -79,7 +79,7 @@ class NonInjectedPortForwardMenu Start @@ -98,7 +98,7 @@ class NonInjectedPortForwardMenu Open @@ -107,7 +107,7 @@ class NonInjectedPortForwardMenu Edit @@ -121,6 +121,7 @@ class NonInjectedPortForwardMenu /> {