Enforce some naming conventions (#4813)

src/common/__tests__/kube-helpers.test.ts

@@ -43,7 +43,7 @@ users:
       command: foo
 `;
 
-interface kubeconfig {
+interface Kubeconfig {
   apiVersion: string;
   clusters: [{
     name: string;
@@ -66,7 +66,7 @@ interface kubeconfig {
   preferences: {};
 }
 
-let mockKubeConfig: kubeconfig;
+let mockKubeConfig: Kubeconfig;
 
 describe("kube helpers", () => {
   describe("validateKubeconfig", () => {

src/common/app-event-bus/event-bus.ts

@@ -5,10 +5,10 @@
 
 import { EventEmitter } from "../event-emitter";
 
-export type AppEvent = {
+export interface AppEvent {
   name: string;
   action: string;
   params?: object;
-};
+}
 
 export const appEventBus = new EventEmitter<[AppEvent]>();

src/common/catalog-entities/web-link.ts

@@ -14,9 +14,9 @@ export interface WebLinkStatus extends CatalogEntityStatus {
   phase: WebLinkStatusPhase;
 }
 
-export type WebLinkSpec = {
+export interface WebLinkSpec {
   url: string;
-};
+}
 
 export class WebLink extends CatalogEntity<CatalogEntityMetadata, WebLinkStatus, WebLinkSpec> {
   public static readonly apiVersion = "entity.k8slens.dev/v1alpha1";

src/common/k8s-api/endpoints/crd.api.ts

@@ -9,12 +9,12 @@ import { crdResourcesURL } from "../../routes";
 import { isClusterPageContext } from "../../utils/cluster-id-url-parsing";
 import type { KubeJsonApiData } from "../kube-json-api";
 
-type AdditionalPrinterColumnsCommon = {
+interface AdditionalPrinterColumnsCommon {
   name: string;
   type: "integer" | "number" | "string" | "boolean" | "date";
   priority: number;
   description: string;
-};
+}
 
 export type AdditionalPrinterColumnsV1 = AdditionalPrinterColumnsCommon & {
   jsonPath: string;

src/common/k8s-api/kube-api.ts

@@ -216,7 +216,7 @@ export function ensureObjectSelfLink(api: KubeApi<KubeObject>, object: KubeJsonA
 
 export type KubeApiWatchCallback = (data: IKubeWatchEvent<KubeJsonApiData>, error: any) => void;
 
-export type KubeApiWatchOptions = {
+export interface KubeApiWatchOptions {
   namespace: string;
   callback?: KubeApiWatchCallback;
   abortController?: AbortController;
@@ -225,7 +225,7 @@ export type KubeApiWatchOptions = {
 
   // timeout in seconds
   timeout?: number;
-};
+}
 
 export type KubeApiPatchType = "merge" | "json" | "strategic";
 

src/common/utils/index.ts

@@ -40,9 +40,10 @@ export * from "./splitArray";
 export * from "./tar";
 export * from "./toJS";
 export * from "./type-narrowing";
-export * from "./types";
 export * from "./wait-for-path";
 
+export type { Tuple } from "./tuple";
+
 import * as iter from "./iter";
 import * as array from "./array";
 import * as tuple from "./tuple";

src/common/utils/singleton.ts

@@ -3,7 +3,7 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 
-type StaticThis<T, R extends any[]> = { new(...args: R): T };
+interface StaticThis<T, R extends any[]> { new(...args: R): T }
 
 export class Singleton {
   private static instances = new WeakMap<object, Singleton>();

src/common/utils/tuple.ts

@@ -8,8 +8,14 @@ import * as array from "../utils/array";
 /**
  * A strict N-tuple of type T
  */
-export type Tuple<T, N extends number> = N extends N ? number extends N ? T[] : _TupleOf<T, N, []> : never;
-type _TupleOf<T, N extends number, R extends unknown[]> = R["length"] extends N ? R : _TupleOf<T, N, [T, ...R]>;
+export type Tuple<T, N extends number> = N extends N
+  ? number extends N
+    ? T[]
+    : TupleOfImpl<T, N, []>
+  : never;
+type TupleOfImpl<T, N extends number, R extends unknown[]> = R["length"] extends N
+  ? R
+  : TupleOfImpl<T, N, [T, ...R]>;
 
 /**
  * Iterates over `sources` yielding full tuples until one of the tuple arrays

src/common/utils/types.ts

@@ -1,10 +0,0 @@
-/**
- * Copyright (c) OpenLens Authors. All rights reserved.
- * Licensed under MIT License. See LICENSE in root directory for more information.
- */
-
-/**
- * An N length tuple of T
- */
-export type Tuple<T, N extends number> = N extends N ? number extends N ? T[] : _TupleOf<T, N, []> : never;
-type _TupleOf<T, N extends number, R extends unknown[]> = R["length"] extends N ? R : _TupleOf<T, N, [T, ...R]>;