Enforce some naming conventions (#4813)

This commit is contained in:
Sebastian Malton authored and GitHub committed 2022-03-01 13:06:53 -05:00
1 parent dc6615f98f
commit 0b32775d40
197 files changed
+630 -634

No files matched your search

@@ -34,7 +34,7 @@ import releaseDetailsInjectable from "./release-details.injectable";
import releaseValuesInjectable from "./release-values.injectable";
import userSuppliedValuesAreShownInjectable from "./user-supplied-values-are-shown.injectable";
interface Props {
export interface ReleaseDetailsProps {
hideDetails(): void;
}
@@ -48,12 +48,12 @@ interface Dependencies {
}
@observer
class NonInjectedReleaseDetails extends Component<Props & Dependencies> {
class NonInjectedReleaseDetails extends Component<ReleaseDetailsProps & Dependencies> {
@observable saving = false;
private nonSavedValues: string;
constructor(props: Props & Dependencies) {
constructor(props: ReleaseDetailsProps & Dependencies) {
super(props);
makeObservable(this);
}
@@ -261,7 +261,7 @@ class NonInjectedReleaseDetails extends Component<Props & Dependencies> {
}
}
export const ReleaseDetails = withInjectables<Dependencies, Props>(
export const ReleaseDetails = withInjectables<Dependencies, ReleaseDetailsProps>(
NonInjectedReleaseDetails,
{
@@ -14,7 +14,7 @@ import createUpgradeChartTabInjectable from "../dock/upgrade-chart/create-upgrad
import releaseRollbackDialogModelInjectable from "./release-rollback-dialog-model/release-rollback-dialog-model.injectable";
import deleteReleaseInjectable from "./delete-release/delete-release.injectable";
interface Props extends MenuActionsProps {
export interface HelmReleaseMenuProps extends MenuActionsProps {
release: HelmRelease;
hideDetails?(): void;
}
@@ -25,7 +25,7 @@ interface Dependencies {
openRollbackDialog: (release: HelmRelease) => void;
}
class NonInjectedHelmReleaseMenu extends React.Component<Props & Dependencies> {
class NonInjectedHelmReleaseMenu extends React.Component<HelmReleaseMenuProps & Dependencies> {
remove = () => {
return this.props.deleteRelease(this.props.release);
};
@@ -79,7 +79,7 @@ class NonInjectedHelmReleaseMenu extends React.Component<Props & Dependencies> {
}
}
export const HelmReleaseMenu = withInjectables<Dependencies, Props>(
export const HelmReleaseMenu = withInjectables<Dependencies, HelmReleaseMenuProps>(
NonInjectedHelmReleaseMenu,
{
@@ -20,7 +20,7 @@ import releaseRollbackDialogModelInjectable
import type { ReleaseRollbackDialogModel } from "./release-rollback-dialog-model/release-rollback-dialog-model";
import rollbackReleaseInjectable from "./rollback-release/rollback-release.injectable";
interface Props extends DialogProps {
export interface ReleaseRollbackDialogProps extends DialogProps {
}
interface Dependencies {
@@ -29,12 +29,12 @@ interface Dependencies {
}
@observer
class NonInjectedReleaseRollbackDialog extends React.Component<Props & Dependencies> {
class NonInjectedReleaseRollbackDialog extends React.Component<ReleaseRollbackDialogProps & Dependencies> {
@observable isLoading = false;
@observable revision: IReleaseRevision;
@observable revisions = observable.array<IReleaseRevision>();
constructor(props: Props & Dependencies) {
constructor(props: ReleaseRollbackDialogProps & Dependencies) {
super(props);
makeObservable(this);
}
@@ -114,7 +114,7 @@ class NonInjectedReleaseRollbackDialog extends React.Component<Props & Dependenc
}
}
export const ReleaseRollbackDialog = withInjectables<Dependencies, Props>(
export const ReleaseRollbackDialog = withInjectables<Dependencies, ReleaseRollbackDialogProps>(
NonInjectedReleaseRollbackDialog,
{
@@ -37,7 +37,7 @@ enum columnId {
updated = "update",
}
interface Props extends RouteComponentProps<ReleaseRouteParams> {
export interface HelmReleasesProps extends RouteComponentProps<ReleaseRouteParams> {
}
interface Dependencies {
@@ -46,7 +46,7 @@ interface Dependencies {
selectNamespace: (namespace: string) => void;
}
class NonInjectedHelmReleases extends Component<Dependencies & Props> {
class NonInjectedHelmReleases extends Component<Dependencies & HelmReleasesProps> {
componentDidMount() {
const { match: { params: { namespace }}} = this.props;
@@ -223,7 +223,7 @@ class NonInjectedHelmReleases extends Component<Dependencies & Props> {
}
}
export const HelmReleases = withInjectables<Dependencies, Props>(
export const HelmReleases = withInjectables<Dependencies, HelmReleasesProps>(
NonInjectedHelmReleases,
{