Enforce some naming conventions (#4813)

This commit is contained in:
Sebastian Malton authored and GitHub committed 2022-03-01 13:06:53 -05:00
1 parent dc6615f98f
commit 0b32775d40
197 files changed
+630 -634

No files matched your search

@@ -25,7 +25,7 @@ import createResourceTabStoreInjectable from "./store.injectable";
import createResourceTemplatesInjectable from "./create-resource-templates.injectable";
import { Spinner } from "../../spinner";
interface Props {
export interface CreateResourceProps {
tab: DockTab;
}
@@ -35,10 +35,10 @@ interface Dependencies {
}
@observer
class NonInjectedCreateResource extends React.Component<Props & Dependencies> {
class NonInjectedCreateResource extends React.Component<CreateResourceProps & Dependencies> {
@observable error = "";
constructor(props: Props & Dependencies) {
constructor(props: CreateResourceProps & Dependencies) {
super(props);
makeObservable(this);
}
@@ -143,7 +143,7 @@ class NonInjectedCreateResource extends React.Component<Props & Dependencies> {
}
}
export const CreateResource = withInjectables<Dependencies, Props>(NonInjectedCreateResource, {
export const CreateResource = withInjectables<Dependencies, CreateResourceProps>(NonInjectedCreateResource, {
getPlaceholder: () => <Spinner center />,
getProps: async (di, props) => ({
+2 -2
View File
@@ -12,14 +12,14 @@ import type { DockTab as DockTabModel } from "./dock/store";
import { TabKind } from "./dock/store";
import { TerminalTab } from "./terminal/dock-tab";
interface Props {
export interface DockTabsProps {
tabs: DockTabModel[];
autoFocus: boolean;
selectedTab: DockTabModel;
onChangeTab: (tab: DockTabModel) => void;
}
export const DockTabs = ({ tabs, autoFocus, selectedTab, onChangeTab }: Props) => {
export const DockTabs = ({ tabs, autoFocus, selectedTab, onChangeTab }: DockTabsProps) => {
const renderTab = (tab?: DockTabModel) => {
if (!tab) {
return null;
+3 -3
View File
@@ -27,7 +27,7 @@ import dockStoreInjectable from "./dock/store.injectable";
import createTerminalTabInjectable from "./terminal/create-terminal-tab.injectable";
import { ErrorBoundary } from "../error-boundary";
interface Props {
export interface DockProps {
className?: string;
}
@@ -38,7 +38,7 @@ interface Dependencies {
}
@observer
class NonInjectedDock extends React.Component<Props & Dependencies> {
class NonInjectedDock extends React.Component<DockProps & Dependencies> {
private element = React.createRef<HTMLDivElement>();
componentDidMount() {
@@ -169,7 +169,7 @@ class NonInjectedDock extends React.Component<Props & Dependencies> {
}
}
export const Dock = withInjectables<Dependencies, Props>(
export const Dock = withInjectables<Dependencies, DockProps>(
NonInjectedDock,
{
@@ -20,7 +20,7 @@ import editResourceTabStoreInjectable from "./store.injectable";
import { noop } from "../../../utils";
import closeDockTabInjectable from "../dock/close-dock-tab.injectable";
interface Props {
export interface EditResourceProps {
tab: DockTab;
}
@@ -30,10 +30,10 @@ interface Dependencies {
}
@observer
class NonInjectedEditResource extends React.Component<Props & Dependencies> {
class NonInjectedEditResource extends React.Component<EditResourceProps & Dependencies> {
@observable error = "";
constructor(props: Props & Dependencies) {
constructor(props: EditResourceProps & Dependencies) {
super(props);
makeObservable(this);
}
@@ -153,7 +153,7 @@ class NonInjectedEditResource extends React.Component<Props & Dependencies> {
}
}
export const EditResource = withInjectables<Dependencies, Props>(NonInjectedEditResource, {
export const EditResource = withInjectables<Dependencies, EditResourceProps>(NonInjectedEditResource, {
getProps: (di, props) => ({
editResourceStore: di.inject(editResourceTabStoreInjectable),
closeTab: di.inject(closeDockTabInjectable),
+5 -5
View File
@@ -17,12 +17,12 @@ import { Notifications } from "../notifications";
import { withInjectables } from "@ogre-tools/injectable-react";
import dockStoreInjectable from "./dock/store.injectable";
interface Props extends OptionalProps {
export interface InfoPanelProps extends OptionalProps {
tabId: TabId;
submit?: () => Promise<ReactNode | string | void>;
}
interface OptionalProps {
export interface OptionalProps {
className?: string;
error?: string;
controls?: ReactNode;
@@ -41,7 +41,7 @@ interface Dependencies {
}
@observer
class NonInjectedInfoPanel extends Component<Props & Dependencies> {
class NonInjectedInfoPanel extends Component<InfoPanelProps & Dependencies> {
static defaultProps: OptionalProps = {
submitLabel: "Submit",
submittingMessage: "Submitting..",
@@ -55,7 +55,7 @@ class NonInjectedInfoPanel extends Component<Props & Dependencies> {
@observable error = "";
@observable waiting = false;
constructor(props: Props & Dependencies) {
constructor(props: InfoPanelProps & Dependencies) {
super(props);
makeObservable(this);
}
@@ -150,7 +150,7 @@ class NonInjectedInfoPanel extends Component<Props & Dependencies> {
}
}
export const InfoPanel = withInjectables<Dependencies, Props>(
export const InfoPanel = withInjectables<Dependencies, InfoPanelProps>(
NonInjectedInfoPanel,
{
@@ -30,7 +30,7 @@ import dockStoreInjectable from "../dock/store.injectable";
import createReleaseInjectable from "../../+helm-releases/create-release/create-release.injectable";
import { Notifications } from "../../notifications";
interface Props {
export interface InstallCharProps {
tab: DockTab;
}
@@ -41,11 +41,11 @@ interface Dependencies {
}
@observer
class NonInjectedInstallChart extends Component<Props & Dependencies> {
class NonInjectedInstallChart extends Component<InstallCharProps & Dependencies> {
@observable error = "";
@observable showNotes = false;
constructor(props: Props & Dependencies) {
constructor(props: InstallCharProps & Dependencies) {
super(props);
makeObservable(this);
}
@@ -218,7 +218,7 @@ class NonInjectedInstallChart extends Component<Props & Dependencies> {
}
}
export const InstallChart = withInjectables<Dependencies, Props>(
export const InstallChart = withInjectables<Dependencies, InstallCharProps>(
NonInjectedInstallChart,
{
@@ -16,7 +16,7 @@ import { withInjectables } from "@ogre-tools/injectable-react";
import dockStoreInjectable from "../dock/store.injectable";
import terminalStoreInjectable from "./store.injectable";
interface Props extends DockTabProps {
export interface TerminalTabProps extends DockTabProps {
}
interface Dependencies {
@@ -25,7 +25,7 @@ interface Dependencies {
}
@observer
class NonInjectedTerminalTab extends React.Component<Props & Dependencies> {
class NonInjectedTerminalTab extends React.Component<TerminalTabProps & Dependencies> {
componentDidMount() {
reaction(() => this.isDisconnected === true, () => {
this.props.dockStore.closeTab(this.tabId);
@@ -72,7 +72,7 @@ class NonInjectedTerminalTab extends React.Component<Props & Dependencies> {
}
}
export const TerminalTab = withInjectables<Dependencies, Props>(NonInjectedTerminalTab, {
export const TerminalTab = withInjectables<Dependencies, TerminalTabProps>(NonInjectedTerminalTab, {
getProps: (di, props) => ({
dockStore: di.inject(dockStoreInjectable),
terminalStore: di.inject(terminalStoreInjectable),
@@ -16,7 +16,7 @@ import { withInjectables } from "@ogre-tools/injectable-react";
import dockStoreInjectable from "../dock/store.injectable";
import terminalStoreInjectable from "./store.injectable";
interface Props {
export interface TerminalWindowProps {
tab: DockTab;
}
@@ -26,7 +26,7 @@ interface Dependencies {
}
@observer
class NonInjectedTerminalWindow extends React.Component<Props & Dependencies> {
class NonInjectedTerminalWindow extends React.Component<TerminalWindowProps & Dependencies> {
public elem: HTMLElement;
public terminal: Terminal;
@@ -64,7 +64,7 @@ class NonInjectedTerminalWindow extends React.Component<Props & Dependencies> {
}
}
export const TerminalWindow = withInjectables<Dependencies, Props>(NonInjectedTerminalWindow, {
export const TerminalWindow = withInjectables<Dependencies, TerminalWindowProps>(NonInjectedTerminalWindow, {
getProps: (di, props) => ({
dockStore: di.inject(dockStoreInjectable),
terminalStore: di.inject(terminalStoreInjectable),
@@ -23,7 +23,7 @@ import upgradeChartTabStoreInjectable from "./store.injectable";
import updateReleaseInjectable from "../../+helm-releases/update-release/update-release.injectable";
import releasesInjectable from "../../+helm-releases/releases.injectable";
interface Props {
export interface UpgradeChartProps {
className?: string;
tab: DockTab;
}
@@ -35,12 +35,12 @@ interface Dependencies {
}
@observer
export class NonInjectedUpgradeChart extends React.Component<Props & Dependencies> {
export class NonInjectedUpgradeChart extends React.Component<UpgradeChartProps & Dependencies> {
@observable error: string;
@observable versions = observable.array<IChartVersion>();
@observable version: IChartVersion;
constructor(props: Props & Dependencies) {
constructor(props: UpgradeChartProps & Dependencies) {
super(props);
makeObservable(this);
}
@@ -179,7 +179,7 @@ export class NonInjectedUpgradeChart extends React.Component<Props & Dependencie
}
}
export const UpgradeChart = withInjectables<Dependencies, Props>(NonInjectedUpgradeChart, {
export const UpgradeChart = withInjectables<Dependencies, UpgradeChartProps>(NonInjectedUpgradeChart, {
getProps: (di, props) => ({
releases: di.inject(releasesInjectable),
updateRelease: di.inject(updateReleaseInjectable),