From 0bee7b6c1a035404ce34ebc5e96cb88100bd5c5d Mon Sep 17 00:00:00 2001
From: alexfront <alex.andreev.email@gmail.com>
Date: Tue, 4 Aug 2020 15:49:21 +0300
Subject: [PATCH] Install Metrics component refactoring

Using notifications for error, removed picking
button icon method, simplified button generation.

Signed-off-by: alexfront <alex.andreev.email@gmail.com>
---
 .../components/install-metrics.tsx            | 129 ++++++++----------
 1 file changed, 55 insertions(+), 74 deletions(-)

diff --git a/src/renderer/components/+cluster-settings/components/install-metrics.tsx b/src/renderer/components/+cluster-settings/components/install-metrics.tsx
index 171adc6034..9fd99ff576 100644
--- a/src/renderer/components/+cluster-settings/components/install-metrics.tsx
+++ b/src/renderer/components/+cluster-settings/components/install-metrics.tsx
@@ -1,15 +1,14 @@
 import React from "react";
 import { Cluster } from "../../../../main/cluster";
 import { Button } from "../../button";
-import { autobind } from "../../../utils";
-import { Tooltip, TooltipPosition } from "../../tooltip";
 import { MetricsFeature } from "../../../../features/metrics";
 import { Spinner } from "../../spinner";
-import { Icon } from "../../icon";
 import { clusterIpc } from "../../../../common/cluster-ipc";
 import { observable } from "mobx";
 import { ActionStatus } from "./statuses"
 import { observer } from "mobx-react";
+import { SubTitle } from "../../layout/sub-title";
+import { Notifications } from "../../notifications";
 
 interface Props {
   cluster: Cluster;
@@ -20,90 +19,72 @@ export class InstallMetrics extends React.Component<Props> {
   @observable status = ActionStatus.IDLE;
   @observable errorText?: string;
 
-  render() {
-    return <>
-      <h4>Metrics</h4>
-      <p>
-        User Mode feature enables non-admin users to see namespaces they have access to.
-        This is achieved by configuring RBAC rules so that every authenticated user is granted to list namespaces.
-      </p>
-      <div className="center">
-        {this.getActionButtons()}
-      </div>
-    </>;
-  }
-
-  getStatusIcon(): React.ReactNode {
-    switch (this.status) {
-    case ActionStatus.IDLE:
-      return null;
-    case ActionStatus.PROCESSING:
-      return <Spinner />;
-    case ActionStatus.ERROR:
-      return <Icon size="16px" material="error" title={this.errorText}></Icon>
-    }
-  }
-
-  getDisabledToolTip(id: string, action: string): React.ReactNode {
+  getActionButtons() {
     const { cluster } = this.props;
-    if (cluster.isAdmin) {
-      return null;
-    }
-
+    const features = cluster.features[MetricsFeature.id];
+    const disabled = !cluster.isAdmin || this.status === ActionStatus.PROCESSING;
+    const loadingIcon = this.status === ActionStatus.PROCESSING ? <Spinner/> : null;
+    if (!features) return null;
     return (
-      <Tooltip targetId={id} position={TooltipPosition.TOP}>
-        {action} only allowed by admins
-      </Tooltip>
+      <div className="flex gaps align-center">
+        {features.canUpgrade &&
+          <Button
+            primary
+            disabled={disabled}
+            onClick={this.runAction("upgradeFeature")}
+          >
+            Upgrade
+          </Button>
+        }
+        {features.installed &&
+          <Button
+            primary
+            disabled={disabled}
+            onClick={this.runAction("uninstallFeature")}
+          >
+            Uninstall
+          </Button>
+        }
+        {!features.installed && !features.canUpgrade &&
+          <Button
+            primary
+            disabled={disabled}
+            onClick={this.runAction("installFeature")}
+          >
+            Install
+          </Button>
+        }
+        {loadingIcon}
+        {!cluster.isAdmin && <span className='admin-note'>Actions can only be performed by admins.</span>}
+      </div>
     );
   }
 
-  getActionButtons(): React.ReactNode[] {
-    const { cluster } = this.props
-    const buttons = [];
-
-    if (cluster.features[MetricsFeature.id]?.canUpgrade) {
-      buttons.push(
-        <Button key="upgrade" id="cluster-feature-metrics-upgrade" disabled={!cluster.isAdmin} primary onClick={this.runAction("upgradeFeature")}>
-          Upgrade {this.getStatusIcon()} {this.getDisabledToolTip("cluster-feature-metrics-upgrade", "Upgrading")}
-        </Button>
-      );
-    }
-
-    if (cluster.features[MetricsFeature.id]?.installed) {
-      buttons.push(
-        <Button key="uninstall" id="cluster-feature-metrics-uninstall" disabled={!cluster.isAdmin} primary onClick={this.runAction("uninstallFeature")}>
-          Uninstall {this.getStatusIcon()} {this.getDisabledToolTip("cluster-feature-metrics-uninstall", "Uninstalling")}
-        </Button>
-      );
-    } else {
-      buttons.push(
-        <Button key="install" id="cluster-feature-metrics-install" disabled={!cluster.isAdmin} primary onClick={this.runAction("installFeature")}>
-          Install {this.getStatusIcon()} {this.getDisabledToolTip("cluster-feature-metrics-install", "Installing")}
-        </Button>
-      );
-    }
-
-    return buttons;
-  }
-
   runAction(action: keyof typeof clusterIpc): () => Promise<void> {
     return async () => {
       const { cluster } = this.props;
-      console.log(`running ${action} ${MetricsFeature.id} onto ${cluster.preferences.clusterName}`);
-  
       try {
         this.status = ActionStatus.PROCESSING
         await clusterIpc[action].invokeFromRenderer(cluster.id, MetricsFeature.id);
-        try {
-          await cluster.refresh();
-        } catch (err) {
-          console.error(err);
-        }
-        this.status = ActionStatus.IDLE
       } catch (err) {
-        this.status = ActionStatus.ERROR
-        this.errorText = err.toString()
+        Notifications.error(err.toString());
       }
+      this.status = ActionStatus.IDLE;
     };
   }
+
+  render() {
+    return (
+      <>
+        <SubTitle title="Metrics"/>
+        <p>
+          Enable timeseries data visualization (Prometheus stack) for your cluster.
+          Install this only if you don't have existing Prometheus stack installed.
+          You can see preview of manifests{" "}
+          <a href="https://github.com/lensapp/lens/tree/master/src/features/metrics" target="_blank">here</a>.
+        </p>
+        {this.getActionButtons()}
+      </>
+    );
+  }
 }
\ No newline at end of file