From 0c325f3b368aa6d81a8c933d68c02a99273b81f8 Mon Sep 17 00:00:00 2001 From: Alex Andreev Date: Fri, 1 Apr 2022 14:37:40 +0300 Subject: [PATCH] Clean up Menu DOM elements Signed-off-by: Alex Andreev --- src/renderer/components/menu/menu.tsx | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/renderer/components/menu/menu.tsx b/src/renderer/components/menu/menu.tsx index a89841c54c..1d176d0b83 100644 --- a/src/renderer/components/menu/menu.tsx +++ b/src/renderer/components/menu/menu.tsx @@ -93,7 +93,6 @@ export class Menu extends React.Component { this.opener.addEventListener(this.props.toggleEvent, this.toggle); this.opener.addEventListener("keydown", this.onKeyDown); } - this.elem.addEventListener("keydown", this.onKeyDown); window.addEventListener("resize", this.onWindowResize); window.addEventListener("click", this.onClickOutside, true); window.addEventListener("scroll", this.onScrollOutside, true); @@ -106,7 +105,6 @@ export class Menu extends React.Component { this.opener.removeEventListener(this.props.toggleEvent, this.toggle); this.opener.removeEventListener("keydown", this.onKeyDown); } - this.elem.removeEventListener("keydown", this.onKeyDown); window.removeEventListener("resize", this.onWindowResize); window.removeEventListener("click", this.onClickOutside, true); window.removeEventListener("scroll", this.onScrollOutside, true); @@ -218,7 +216,7 @@ export class Menu extends React.Component { } } - onKeyDown(evt: KeyboardEvent) { + onKeyDown(evt: React.KeyboardEvent | KeyboardEvent) { if (!this.isOpen) return; switch (evt.code) { @@ -330,6 +328,7 @@ export class Menu extends React.Component { left: this.state?.menuStyle?.left, top: this.state?.menuStyle?.top, }} + onKeyDown={this.onKeyDown} > {menuItems}