Switch to using messaging and startable stoppable from NPM package (#7368)

* Add custom jest resolver to fix requiring "uuid" module Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Update dependencies Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Introduce test utils for rendering and running with thrown mobx reactions Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Extract startable-stoppable to NPM package Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Extract messaging to NPM package Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using startable-stoppable from NPM package Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Switch to using messaging from the Feature Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove old implementation of messaging Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make setupping app paths happen earlier in renderer Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix typo Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Add kludge to make testing-library work properly from test-utils package Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix code style Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Add lint:fix -root script Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Fix unrelated failing unit tests Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Turn of no-floating-promises from typescript linting for being broken Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make linting not happen for dist -directories Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make linting failures appear as failure Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Stop running prettier twice It already gets ran as eslint-plugin. Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Make CI run unit tests for all packages by consolidating name of NPM script Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Add missing unit tests for coverage Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Skip coverage for test utils Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Remove check for coverage in packages which are not ready for it Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Stop collecting coverage from index.ts files them being indirections to the implementation Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Implement sending message to channel in main Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Add missing feature dependencies Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Add dummy implementations for requesting in main from renderer Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Re-enable communicating from main to cluster frames Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Ignore trivial files from coverage Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Update package-lock Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Extract message-bridge to separate NPM package to prevent dev dependencies being in the production bundle Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Extract computed channel to own NPM package for clear dependencies Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Consolidate electron related stuff to a directory Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Add missing publish configurations Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * Ignore test implementation from coverage being not interesting Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> --------- Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2025-05-20 05:10:56 +00:00 · 2023-03-21 11:38:43 +02:00
1 parent df49ff9b96
commit 0f1f030a06
@@ -3,12 +3,14 @@
 * Licensed under MIT License. See LICENSE in root directory for more information.
 */
 import { addHelmRepositoryChannel } from "../../../../common/helm/add-helm-repository-channel";
-import { getRequestChannelListenerInjectable } from "../../../utils/channel/channel-listeners/listener-tokens";
+import { getRequestChannelListenerInjectable } from "@k8slens/messaging";
 import addHelmRepositoryInjectable from "./add-helm-repository.injectable";

-const addHelmRepositoryChannelListenerInjectable = getRequestChannelListenerInjectable({
-  channel: addHelmRepositoryChannel,
-  handler: (di) => di.inject(addHelmRepositoryInjectable),
-});
+const addHelmRepositoryChannelListenerInjectable =
+  getRequestChannelListenerInjectable({
+    id: "add-helm-repository-channel-listener",
+    channel: addHelmRepositoryChannel,
+    getHandler: (di) => di.inject(addHelmRepositoryInjectable),
+  });

 export default addHelmRepositoryChannelListenerInjectable;
@@ -5,17 +5,16 @@
 import { getInjectable } from "@ogre-tools/injectable";
 import execHelmInjectable from "../../exec-helm/exec-helm.injectable";
 import loggerInjectable from "../../../../common/logger.injectable";
-import type { AddHelmRepositoryChannel } from "../../../../common/helm/add-helm-repository-channel";
-import type { RequestChannelHandler } from "../../../utils/channel/channel-listeners/listener-tokens";
+import type { HelmRepo } from "../../../../common/helm/helm-repo";

 const addHelmRepositoryInjectable = getInjectable({
  id: "add-helm-repository",

-  instantiate: (di): RequestChannelHandler<AddHelmRepositoryChannel> => {
+  instantiate: (di) => {
    const execHelm = di.inject(execHelmInjectable);
    const logger = di.inject(loggerInjectable);

-    return async (repo) => {
+    return async (repo: HelmRepo) => {
      const {
        name,
        url,
@@ -59,12 +58,12 @@ const addHelmRepositoryInjectable = getInjectable({

      if (result.callWasSuccessful) {
        return {
-          callWasSuccessful: true,
+          callWasSuccessful: true as const,
        };
      }

      return {
-        callWasSuccessful: false,
+        callWasSuccessful: false as const,
        error: result.error.stderr || result.error.message,
      };
    };
@@ -3,12 +3,13 @@
 * Licensed under MIT License. See LICENSE in root directory for more information.
 */
 import { getActiveHelmRepositoriesChannel } from "../../../../common/helm/get-active-helm-repositories-channel";
-import { getRequestChannelListenerInjectable } from "../../../utils/channel/channel-listeners/listener-tokens";
+import { getRequestChannelListenerInjectable } from "@k8slens/messaging";
 import getActiveHelmRepositoriesInjectable from "./get-active-helm-repositories.injectable";

 const getActiveHelmRepositoriesChannelListenerInjectable = getRequestChannelListenerInjectable({
+  id: "get-active-helm-repositories-channel-listener",
  channel: getActiveHelmRepositoriesChannel,
-  handler: (di) => di.inject(getActiveHelmRepositoriesInjectable),
+  getHandler: (di) => di.inject(getActiveHelmRepositoriesInjectable),
 });

 export default getActiveHelmRepositoriesChannelListenerInjectable;
@@ -4,11 +4,12 @@
 */
 import removeHelmRepositoryInjectable from "./remove-helm-repository.injectable";
 import { removeHelmRepositoryChannel } from "../../../../common/helm/remove-helm-repository-channel";
-import { getRequestChannelListenerInjectable } from "../../../utils/channel/channel-listeners/listener-tokens";
+import { getRequestChannelListenerInjectable } from "@k8slens/messaging";

 const removeHelmRepositoryChannelListenerInjectable = getRequestChannelListenerInjectable({
+  id: "remove-helm-repository-channel-listener",
  channel: removeHelmRepositoryChannel,
-  handler: (di) => di.inject(removeHelmRepositoryInjectable),
+  getHandler: (di) => di.inject(removeHelmRepositoryInjectable),
 });

 export default removeHelmRepositoryChannelListenerInjectable;