From 10eb95ae6784aa7891eb870a5a92646fc85c800e Mon Sep 17 00:00:00 2001
From: Janne Savolainen
Date: Wed, 3 Nov 2021 12:23:28 +0200
Subject: [PATCH] Implement breadcrumbs for deleting different kube objects
This was done in a naive way by disregarding stuff such as:
- Avoidance of shared global state (dependency inversion principle)
- Unit testing
- Minimal implementation over defensive code (elvis, just in case)
- Full understanding for use cases of all different kube objects
Signed-off-by: Janne Savolainen
---
.../kube-object-menu/kube-object-menu.tsx | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/src/renderer/components/kube-object-menu/kube-object-menu.tsx b/src/renderer/components/kube-object-menu/kube-object-menu.tsx
index 300ce67775..896eb2bac8 100644
--- a/src/renderer/components/kube-object-menu/kube-object-menu.tsx
+++ b/src/renderer/components/kube-object-menu/kube-object-menu.tsx
@@ -27,6 +27,8 @@ import { MenuActions, MenuActionsProps } from "../menu/menu-actions";
import { hideDetails } from "../kube-detail-params";
import { apiManager } from "../../../common/k8s-api/api-manager";
import { KubeObjectMenuRegistry } from "../../../extensions/registries/kube-object-menu-registry";
+import identity from "lodash/identity";
+import { catalogEntityRegistry } from "../../api/catalog-entity-registry";
export interface KubeObjectMenuProps extends MenuActionsProps {
object: T | null | undefined;
@@ -74,8 +76,17 @@ export class KubeObjectMenu extends React.ComponentRemove {object.kind} {object.getName()}?
+ Remove {breadcrumb}?
);
}