From 135a4e1e9a50706c2eeaf022b612988587184f8a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Luca=20Kr=C3=B6ger?= <l.kroeger01@gmail.com>
Date: Tue, 1 Jun 2021 08:56:47 +0200
Subject: [PATCH] rename attach shell to attach to pod
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Luca Kröger <l.kroeger01@gmail.com>
---
 extensions/pod-menu/src/attach-menu.tsx | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/extensions/pod-menu/src/attach-menu.tsx b/extensions/pod-menu/src/attach-menu.tsx
index b3520eb9a1..2e829c2b6c 100644
--- a/extensions/pod-menu/src/attach-menu.tsx
+++ b/extensions/pod-menu/src/attach-menu.tsx
@@ -45,7 +45,7 @@ export interface PodAttachMenuProps extends Renderer.Component.KubeObjectMenuPro
 }
 
 export class PodAttachMenu extends React.Component<PodAttachMenuProps> {
-  async attachShell(container?: string) {
+  async attachToPod(container?: string) {
     Navigation.hideDetails();
     const { object: pod } = this.props;
     const containerParam = container ? `-c ${container}` : "";
@@ -56,7 +56,7 @@ export class PodAttachMenu extends React.Component<PodAttachMenuProps> {
     }
 
     const shell = createTerminalTab({
-      title: `Pod: ${pod.getName()} (namespace: ${pod.getNs()}) (Attached)`
+      title: `Pod: ${pod.getName()} (namespace: ${pod.getNs()}) [Attached]`
     });
 
     terminalStore.sendCommand(command, {
@@ -72,9 +72,9 @@ export class PodAttachMenu extends React.Component<PodAttachMenuProps> {
     if (!containers.length) return null;
 
     return (
-      <MenuItem onClick={Util.prevDefault(() => this.attachShell(containers[0].name))}>
-        <Icon material="pageview" interactive={toolbar} title="Pod shell (attached)"/>
-        <span className="title">Shell (Attached)</span>
+      <MenuItem onClick={Util.prevDefault(() => this.attachToPod(containers[0].name))}>
+        <Icon material="pageview" interactive={toolbar} title="Attach to Pod"/>
+        <span className="title">Attached Pod</span>
         {containers.length > 1 && (
           <>
             <Icon className="arrow" material="keyboard_arrow_right"/>
@@ -84,7 +84,7 @@ export class PodAttachMenu extends React.Component<PodAttachMenuProps> {
                   const { name } = container;
 
                   return (
-                    <MenuItem key={name} onClick={Util.prevDefault(() => this.attachShell(name))} className="flex align-center">
+                    <MenuItem key={name} onClick={Util.prevDefault(() => this.attachToPod(name))} className="flex align-center">
                       <StatusBrick/>
                       <span>{name}</span>
                     </MenuItem>