From 13786930eb36464d852e2cf65182babc7cff72ab Mon Sep 17 00:00:00 2001 From: Roman Date: Thu, 30 Sep 2021 15:06:18 +0300 Subject: [PATCH] fix: Uncaught Error: ModelService: Cannot add model because it already exists! (how-to-reproduce: open/close dock with tabs) Signed-off-by: Roman --- src/renderer/components/monaco-editor/monaco-editor.tsx | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/renderer/components/monaco-editor/monaco-editor.tsx b/src/renderer/components/monaco-editor/monaco-editor.tsx index 165177facd..148998fa1d 100644 --- a/src/renderer/components/monaco-editor/monaco-editor.tsx +++ b/src/renderer/components/monaco-editor/monaco-editor.tsx @@ -103,6 +103,12 @@ export class MonacoEditor extends React.Component { } }; + componentWillUnmount() { + logger.info(`[MONACO]: unmounting editor..`); + MonacoEditor.models.get(this).forEach(model => model.dispose()); + MonacoEditor.models.delete(this); + } + createUri(id: string): monaco.Uri { return monaco.Uri.file(`/monaco-editor/${id}`); }