hendrik/lens
1
0 Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

chore: Turn on @typescript-eslint/strict-boolean-expressions

Browse Source 
- Fix some bugs about bad conditions

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton committed 2023-06-01 09:27:44 -04:00
1 parent d3f45bfe49
commit 1675c56e59
165 files changed
+853 -1141
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

packages/utility-features/json-api/src/json-api.ts
+5 -5
View File
@@ -13,7 +13,7 @@ import type { Logger } from "@k8slens/logger";
import type Fetch from "@k8slens/node-fetch";
import type { RequestInit, Response } from "@k8slens/node-fetch";
import type { Defaulted } from "@k8slens/utilities";
import { isArray, isObject, isString, json } from "@k8slens/utilities";
import { isDefined, isArray, isObject, isString, json } from "@k8slens/utilities";
export interface JsonApiError {
code?: number;
@@ -150,7 +150,7 @@ export class JsonApi<Data = unknown, Params extends { data?: unknown } = { data?
);
const { query } = params ?? {};
if (query && Object.keys(query).length > 0) {
if (isObject(query) && Object.keys(query).length > 0) {
const queryString = stringify(query as unknown as QueryParams);
reqUrl += (reqUrl.includes("?") ? "&" : "?") + queryString;
@@ -206,13 +206,13 @@ export class JsonApi<Data = unknown, Params extends { data?: unknown } = { data?
) {
let reqUrl = `${this.config.serverAddress}${this.config.apiBase}${path}`;
const reqInit = merge({}, this.reqInit, await this.getRequestOptions(), init);
const { data, query } = params || {};
const { data, query } = params ?? {};
if (data && !reqInit.body) {
if (isDefined(data) && reqInit.body == null) {
reqInit.body = JSON.stringify(data);
}
if (query && Object.keys(query).length > 0) {
if (isObject(query) && Object.keys(query).length > 0) {
const queryString = stringify(query as unknown as QueryParams);
reqUrl += (reqUrl.includes("?") ? "&" : "?") + queryString;