hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix test to reflect the true hotbar items behavior

Browse Source 
Signed-off-by: Juho Heikka <juho.heikka@gmail.com>
This commit is contained in:
Juho Heikka 2023-05-11 17:00:20 +03:00
parent 87f5d57441
commit 16ac25e91b
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/core/src/features/hotbar/storage/main/welcome-page-migration.test.ts
View File

@ -10,10 +10,18 @@ import type { HotbarItem } from "../common/types";
import v640HotbarStoreMigrationInjectable from "./welcome-page-migration.injectable"; import v640HotbarStoreMigrationInjectable from "./welcome-page-migration.injectable";
import { defaultHotbarCells } from "../common/types"; import { defaultHotbarCells } from "../common/types";
function fillWithEmpties(items: HotbarItem[]) {
const emptyHotBarItems = new Array(defaultHotbarCells).fill(null);
return [...items, ...emptyHotBarItems.slice(items.length)];
}
function setFirstHotbarItems(store: MigrationStore, items: HotbarItem[]) { function setFirstHotbarItems(store: MigrationStore, items: HotbarItem[]) {
const oldHotbars = store.get("hotbars") as HotbarData[]; const oldHotbars = store.get("hotbars") as HotbarData[];
// empty hotbar items are nulls
const itemsWithEmptyCells = fillWithEmpties(items);
store.set("hotbars", [{ ...oldHotbars[0], items }, ...oldHotbars.slice(1)]); store.set("hotbars", [{ ...oldHotbars[0], items: itemsWithEmptyCells }, ...oldHotbars.slice(1)]);
} }
const someItem: HotbarItem = { const someItem: HotbarItem = {
@ -64,7 +72,7 @@ describe("hotbar-welcome-page-migration", () => {
it("given first hotbar is empty, adds welcome page to first place", () => { it("given first hotbar is empty, adds welcome page to first place", () => {
migration.run(store); migration.run(store);
expect(storeModel.get("hotbars")[0].items).toEqual([welcomeHotbarItem]); expect(storeModel.get("hotbars")[0].items[0]).toEqual(welcomeHotbarItem);
}); });
it("given first hotbar has items but is not full, adds welcome page to first place", () => { it("given first hotbar has items but is not full, adds welcome page to first place", () => {
@ -72,7 +80,7 @@ describe("hotbar-welcome-page-migration", () => {
migration.run(store); migration.run(store);
expect(storeModel.get("hotbars")[0].items).toEqual([welcomeHotbarItem, someItem]); expect(storeModel.get("hotbars")[0].items.slice(0, 2)).toEqual([welcomeHotbarItem, someItem]);
}); });
it("given first hotbar is full, does not add welcome page", () => { it("given first hotbar is full, does not add welcome page", () => {
@ -87,7 +95,7 @@ describe("hotbar-welcome-page-migration", () => {
}); });
it("given first hotbar has already welcome page, does not add welcome page", () => { it("given first hotbar has already welcome page, does not add welcome page", () => {
const hotBarItemsWithWelcomePage = [someItem, welcomeHotbarItem, someItem]; const hotBarItemsWithWelcomePage = fillWithEmpties([someItem, welcomeHotbarItem, someItem]);
setFirstHotbarItems(store, hotBarItemsWithWelcomePage); setFirstHotbarItems(store, hotBarItemsWithWelcomePage);
migration.run(store); migration.run(store);