Handle invalid metric response properly (#464)

* catch undefined and return default empty in normalizeMetrics

* fix crash on drilldown

Signed-off-by: Sebastian Malton <smalton@mirantis.com>

Co-authored-by: Sebastian Malton <smalton@mirantis.com>

dashboard/client/components/+cluster/cluster.store.ts

@@ -82,15 +82,15 @@ export class ClusterStore extends KubeObjectStore<Cluster> {
     this.liveMetrics = await this.loadMetrics({ start, end, step, range });
   }
 
-  getMetricsValues(source: Partial<IClusterMetrics>) {
-    const metrics =
-      this.metricType === MetricType.CPU ? source.cpuUsage :
-        this.metricType === MetricType.MEMORY ? source.memoryUsage
-          : null;
-    if (!metrics) {
+  getMetricsValues(source: Partial<IClusterMetrics>): [number, string][] {
+    switch (this.metricType) {
+    case MetricType.CPU:
+      return normalizeMetrics(source.cpuUsage).data.result[0].values
+    case MetricType.MEMORY:
+      return normalizeMetrics(source.memoryUsage).data.result[0].values
+    default:
       return [];
     }
-    return normalizeMetrics(metrics).data.result[0].values;
   }
 
   resetMetrics() {

dashboard/client/components/+network-ingresses/ingress-charts.tsx

@@ -18,9 +18,9 @@ export const IngressCharts = observer(() => {
   if (!metrics) return null;
   if (isMetricsEmpty(metrics)) return <NoMetrics/>;
 
-  const values = Object.values(metrics).map(metric =>
-    normalizeMetrics(metric).data.result[0].values
-  );
+  const values = Object.values(metrics)
+    .map(normalizeMetrics)
+    .map(({ data }) => data.result[0].values);
   const [
     bytesSentSuccess,
     bytesSentFailure,

dashboard/client/components/+workloads-pods/container-charts.tsx

@@ -17,9 +17,9 @@ export const ContainerCharts = () => {
   if (!metrics) return null;
   if (isMetricsEmpty(metrics)) return <NoMetrics/>;
 
-  const values = Object.values(metrics).map(metric =>
-    normalizeMetrics(metric).data.result[0].values
-  );
+  const values = Object.values(metrics)
+    .map(normalizeMetrics)
+    .map(({ data }) => data.result[0].values);
   const [
     cpuUsage,
     cpuRequests,

dashboard/client/components/+workloads-pods/pod-charts.tsx

@@ -28,9 +28,9 @@ export const PodCharts = observer(() => {
   if (isMetricsEmpty(metrics)) return <NoMetrics/>;
 
   const options = tabId == 0 ? cpuOptions : memoryOptions;
-  const values = Object.values(metrics).map(metric =>
-    normalizeMetrics(metric).data.result[0].values
-  );
+  const values = Object.values(metrics)
+    .map(normalizeMetrics)
+    .map(({ data }) => data.result[0].values);
   const [
     cpuUsage,
     cpuRequests,