From 19150fca845c6cd4fdbe7f8abc495dbcc22eb22e Mon Sep 17 00:00:00 2001 From: Lauri Nevala Date: Mon, 23 Nov 2020 13:45:07 +0200 Subject: [PATCH] Catch errors return error response when fetching chart or chart values fails (#1478) Signed-off-by: Lauri Nevala --- src/main/routes/helm-route.ts | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/main/routes/helm-route.ts b/src/main/routes/helm-route.ts index 853f8ddded..b9a6cf513b 100644 --- a/src/main/routes/helm-route.ts +++ b/src/main/routes/helm-route.ts @@ -12,14 +12,22 @@ class HelmApiRoute extends LensApi { public async getChart(request: LensApiRequest) { const { params, query, response } = request; - const chart = await helmService.getChart(params.repo, params.chart, query.get("version")); - this.respondJson(response, chart); + try { + const chart = await helmService.getChart(params.repo, params.chart, query.get("version")); + this.respondJson(response, chart); + } catch (error) { + this.respondText(response, error, 422); + } } public async getChartValues(request: LensApiRequest) { const { params, query, response } = request; - const values = await helmService.getChartValues(params.repo, params.chart, query.get("version")); - this.respondJson(response, values); + try { + const values = await helmService.getChartValues(params.repo, params.chart, query.get("version")); + this.respondJson(response, values); + } catch (error) { + this.respondText(response, error, 422); + } } public async installChart(request: LensApiRequest) {