hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Tweak code-style

Browse Source 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
Janne Savolainen 2022-07-01 08:03:08 +03:00
parent ec509fcb29
commit 19a8a28d42
No known key found for this signature in database
GPG Key ID: 8C6CFB2FFFE8F68A
1 changed files with 67 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
src/behaviours/status-bar/status-bar-items-originating-from-extensions.test.tsx
View File

@ -33,29 +33,42 @@ describe("status-bar-items-originating-from-extensions", () => {
it("when multiple extensions with status bar items are loaded, shows items in correct order", () => { it("when multiple extensions with status bar items are loaded, shows items in correct order", () => {
const testExtension1 = getRendererExtensionFake({ const testExtension1 = getRendererExtensionFake({
id: "some-id", name: "some-name", statusBarItems: [{ id: "some-id",
name: "some-name",
statusBarItems: [
{
components: { components: {
Item: () => <div data-testid="some-testId">extension1</div>, Item: () => <div data-testid="some-testId">extension1</div>,
position: "right", position: "right",
}, },
}], },
],
}); });
const testExtension2 = getRendererExtensionFake({ const testExtension2 = getRendererExtensionFake({
id: "some-other-id", name: "some-other-name", statusBarItems: [{ id: "some-other-id",
name: "some-other-name",
statusBarItems: [
{
components: { components: {
Item: () => <div data-testid="some-testId">extension2</div>, Item: () => <div data-testid="some-testId">extension2</div>,
position: "right", position: "right",
}, },
}], },
],
}); });
applicationBuilder.extensions.renderer.enable(testExtension1, testExtension2); applicationBuilder.extensions.renderer.enable(testExtension1, testExtension2);
const actual = rendered.getByTestId("status-bar-right"); const rightSide = rendered.getByTestId("status-bar-right");
const positions = getTestStatusBarTexts(actual, ["extension1", "extension2"]);
expect(positions).toEqual(["extension2", "extension1"]); const actual = getTestStatusBarTexts(rightSide, [
"extension1",
"extension2",
]);
expect(actual).toEqual(["extension2", "extension1"]);
}); });
describe("when extension with status bar items is loaded", () => { describe("when extension with status bar items is loaded", () => {
@ -63,11 +76,14 @@ describe("status-bar-items-originating-from-extensions", () => {
beforeEach(() => { beforeEach(() => {
testExtension = getRendererExtensionFake({ testExtension = getRendererExtensionFake({
id: "some-id", name: "some-name", statusBarItems: [{ id: "some-id",
item: () => <span data-testid="some-testId" >right1</span>, name: "some-name",
statusBarItems: [
{
item: () => <span data-testid="some-testId">right1</span>,
}, },
{ {
item: () => <span data-testid="some-testId" >right2</span>, item: () => <span data-testid="some-testId">right2</span>,
}, },
{ {
components: { components: {
@ -86,7 +102,8 @@ describe("status-bar-items-originating-from-extensions", () => {
Item: () => <div data-testid="some-testId">left2</div>, Item: () => <div data-testid="some-testId">left2</div>,
position: "left", position: "left",
}, },
}], },
],
}); });
applicationBuilder.extensions.renderer.enable(testExtension); applicationBuilder.extensions.renderer.enable(testExtension);
@ -97,32 +114,37 @@ describe("status-bar-items-originating-from-extensions", () => {
}); });
it("shows right side status bar items in the correct order", () => { it("shows right side status bar items in the correct order", () => {
const actual = rendered.getByTestId("status-bar-right"); const rightSide = rendered.getByTestId("status-bar-right");
const positions = getTestStatusBarTexts(actual, ["right1", "right2", "right3"]);
expect(positions).toEqual(["right3", "right2", "right1"]); const actual = getTestStatusBarTexts(rightSide, [
"right1",
"right2",
"right3",
]);
expect(actual).toEqual(["right3", "right2", "right1"]);
}); });
it("shows left side status bar items in the correct order", () => { it("shows left side status bar items in the correct order", () => {
const actual = rendered.getByTestId("status-bar-left"); const leftSide = rendered.getByTestId("status-bar-left");
const positions = getTestStatusBarTexts(actual, ["left2", "left1"]);
expect(positions).toEqual(["left1", "left2"]); const actual = getTestStatusBarTexts(leftSide, ["left2", "left1"]);
expect(actual).toEqual(["left1", "left2"]);
}); });
it("when the extension is removed, shows there are no extension status bar items", () => { it("when the extension is removed, shows there are no extension status bar items", () => {
applicationBuilder.extensions.renderer.disable(testExtension); applicationBuilder.extensions.renderer.disable(testExtension);
const actual = rendered.queryAllByTestId("some-testId"); const actual = rendered.queryAllByTestId("some-testId");
expect(actual).toHaveLength(0); expect(actual).toHaveLength(0);
}); });
}); });
}); });
}); });
const getTestStatusBarTexts = (actual: HTMLElement, expectedTexts: string[]) => { const getTestStatusBarTexts = (actual: HTMLElement, expectedTexts: string[]) =>
return Array.from(actual.children).map(elem => elem.textContent).filter(elem => elem && expectedTexts.includes(elem)); Array.from(actual.children)
}; .map((elem) => elem.textContent)
.filter((elem) => elem && expectedTexts.includes(elem));