Enable consistent-type-imports eslint rule (#5205)

src/main/__test__/context-handler.test.ts

@@ -5,7 +5,8 @@
 
 import { UserStore } from "../../common/user-store";
 import type { ContextHandler } from "../context-handler/context-handler";
-import { PrometheusProvider, PrometheusProviderRegistry, PrometheusService } from "../prometheus";
+import type { PrometheusService } from "../prometheus";
+import { PrometheusProvider, PrometheusProviderRegistry } from "../prometheus";
 import mockFs from "mock-fs";
 import { getDiForUnitTesting } from "../getDiForUnitTesting";
 import createContextHandlerInjectable from "../context-handler/create-context-handler.injectable";

src/main/__test__/kube-auth-proxy.test.ts

@@ -38,11 +38,14 @@ jest.mock("tcp-port-used");
 import type { Cluster } from "../../common/cluster/cluster";
 import type { KubeAuthProxy } from "../kube-auth-proxy/kube-auth-proxy";
 import { broadcastMessage } from "../../common/ipc";
-import { ChildProcess, spawn } from "child_process";
+import type { ChildProcess } from "child_process";
+import { spawn } from "child_process";
 import { Kubectl } from "../kubectl/kubectl";
-import { mock, MockProxy } from "jest-mock-extended";
+import type { MockProxy } from "jest-mock-extended";
+import { mock } from "jest-mock-extended";
 import { waitUntilUsed } from "tcp-port-used";
-import { EventEmitter, Readable } from "stream";
+import type { Readable } from "stream";
+import { EventEmitter } from "stream";
 import { UserStore } from "../../common/user-store";
 import { Console } from "console";
 import { stdout, stderr } from "process";

src/main/app-paths/app-paths.injectable.ts

@@ -2,8 +2,9 @@
  * Copyright (c) OpenLens Authors. All rights reserved.
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
+import type {
+  DiContainerForSetup } from "@ogre-tools/injectable";
 import {
-  DiContainerForSetup,
   getInjectable,
 } from "@ogre-tools/injectable";
 

src/main/app-paths/get-app-paths.ts

@@ -3,7 +3,8 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 import { fromPairs } from "lodash/fp";
-import { pathNames, PathName } from "../../common/app-paths/app-path-names";
+import type { PathName } from "../../common/app-paths/app-path-names";
+import { pathNames } from "../../common/app-paths/app-path-names";
 import type { AppPaths } from "../../common/app-paths/app-path-injection-token";
 
 interface Dependencies {

src/main/app-updater.ts

@@ -3,11 +3,13 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 
-import { autoUpdater, UpdateInfo } from "electron-updater";
+import type { UpdateInfo } from "electron-updater";
+import { autoUpdater } from "electron-updater";
 import logger from "./logger";
 import { isPublishConfigured, isTestEnv } from "../common/vars";
 import { delay } from "../common/utils";
-import { areArgsUpdateAvailableToBackchannel, AutoUpdateChecking, AutoUpdateLogPrefix, AutoUpdateNoUpdateAvailable, broadcastMessage, onceCorrect, UpdateAvailableChannel, UpdateAvailableToBackchannel } from "../common/ipc";
+import type { UpdateAvailableToBackchannel } from "../common/ipc";
+import { areArgsUpdateAvailableToBackchannel, AutoUpdateChecking, AutoUpdateLogPrefix, AutoUpdateNoUpdateAvailable, broadcastMessage, onceCorrect, UpdateAvailableChannel } from "../common/ipc";
 import { once } from "lodash";
 import { ipcMain } from "electron";
 import { nextUpdateChannel } from "./utils/update-channel";

src/main/catalog-sources/kubeconfig-sync-manager/kubeconfig-sync-manager.ts

@@ -3,14 +3,17 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 
-import { action, observable, IComputedValue, computed, ObservableMap, runInAction, makeObservable, observe } from "mobx";
+import type { IComputedValue, ObservableMap } from "mobx";
+import { action, observable, computed, runInAction, makeObservable, observe } from "mobx";
 import type { CatalogEntity } from "../../../common/catalog";
 import { catalogEntityRegistry } from "../../catalog";
-import { FSWatcher, watch } from "chokidar";
+import type { FSWatcher } from "chokidar";
+import { watch } from "chokidar";
 import fs from "fs";
 import path from "path";
 import type stream from "stream";
-import { bytesToUnits, Disposer, getOrInsertWith, iter, noop } from "../../../common/utils";
+import type { Disposer } from "../../../common/utils";
+import { bytesToUnits, getOrInsertWith, iter, noop } from "../../../common/utils";
 import logger from "../../logger";
 import type { KubeConfig } from "@kubernetes/client-node";
 import { loadConfigFromString, splitConfig } from "../../../common/kube-helpers";

src/main/catalog/__tests__/catalog-entity-registry.test.ts

@@ -4,8 +4,10 @@
  */
 
 import { observable, reaction } from "mobx";
-import { WebLink, WebLinkSpec, WebLinkStatus } from "../../../common/catalog-entities";
-import { catalogCategoryRegistry, CatalogEntity, CatalogEntityMetadata } from "../../../common/catalog";
+import type { WebLinkSpec, WebLinkStatus } from "../../../common/catalog-entities";
+import { WebLink } from "../../../common/catalog-entities";
+import type { CatalogEntityMetadata } from "../../../common/catalog";
+import { catalogCategoryRegistry, CatalogEntity } from "../../../common/catalog";
 import { CatalogEntityRegistry } from "../catalog-entity-registry";
 
 class InvalidEntity extends CatalogEntity<CatalogEntityMetadata, WebLinkStatus, WebLinkSpec> {

src/main/catalog/catalog-entity-registry.ts

@@ -4,7 +4,8 @@
  */
 
 import { action, computed, type IComputedValue, type IObservableArray, makeObservable, observable } from "mobx";
-import { CatalogCategoryRegistry, catalogCategoryRegistry, CatalogEntity, CatalogEntityConstructor } from "../../common/catalog";
+import type { CatalogCategoryRegistry, CatalogEntity, CatalogEntityConstructor } from "../../common/catalog";
+import { catalogCategoryRegistry } from "../../common/catalog";
 import { iter } from "../../common/utils";
 
 export class CatalogEntityRegistry {

src/main/cluster-manager.ts

@@ -6,12 +6,13 @@
 import "../common/ipc/cluster";
 import type http from "http";
 import { action, makeObservable, observable, observe, reaction, toJS } from "mobx";
-import { Cluster } from "../common/cluster/cluster";
+import type { Cluster } from "../common/cluster/cluster";
 import logger from "./logger";
 import { apiKubePrefix } from "../common/vars";
 import { getClusterIdFromHost, Singleton } from "../common/utils";
 import { catalogEntityRegistry } from "./catalog";
-import { KubernetesCluster, KubernetesClusterPrometheusMetrics, LensKubernetesClusterStatus } from "../common/catalog-entities/kubernetes-cluster";
+import type { KubernetesClusterPrometheusMetrics } from "../common/catalog-entities/kubernetes-cluster";
+import { KubernetesCluster, LensKubernetesClusterStatus } from "../common/catalog-entities/kubernetes-cluster";
 import { ipcMainOn } from "../common/ipc";
 import { once } from "lodash";
 import { ClusterStore } from "../common/cluster-store/cluster-store";

src/main/context-handler/context-handler.ts

@@ -8,7 +8,8 @@ import { PrometheusProviderRegistry } from "../prometheus/provider-registry";
 import type { ClusterPrometheusPreferences } from "../../common/cluster-types";
 import type { Cluster } from "../../common/cluster/cluster";
 import type httpProxy from "http-proxy";
-import url, { UrlWithStringQuery } from "url";
+import type { UrlWithStringQuery } from "url";
+import url from "url";
 import { CoreV1Api } from "@kubernetes/client-node";
 import logger from "../logger";
 import type { KubeAuthProxy } from "../kube-auth-proxy/kube-auth-proxy";

src/main/create-cluster/create-cluster.injectable.ts

@@ -3,7 +3,8 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 import { getInjectable } from "@ogre-tools/injectable";
-import { Cluster, ClusterDependencies } from "../../common/cluster/cluster";
+import type { ClusterDependencies } from "../../common/cluster/cluster";
+import { Cluster } from "../../common/cluster/cluster";
 import directoryForKubeConfigsInjectable from "../../common/app-paths/directory-for-kube-configs/directory-for-kube-configs.injectable";
 import createKubeconfigManagerInjectable from "../kubeconfig-manager/create-kubeconfig-manager.injectable";
 import createKubectlInjectable from "../kubectl/create-kubectl.injectable";

src/main/initializers/init-ipc-main-handlers/init-ipc-main-handlers.ts

@@ -3,7 +3,8 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 
-import { BrowserWindow, IpcMainInvokeEvent, Menu } from "electron";
+import type { IpcMainInvokeEvent } from "electron";
+import { BrowserWindow, Menu } from "electron";
 import { clusterFrameMap } from "../../../common/cluster-frames";
 import { clusterActivateHandler, clusterSetFrameIdHandler, clusterVisibilityHandler, clusterRefreshHandler, clusterDisconnectHandler, clusterKubectlApplyAllHandler, clusterKubectlDeleteAllHandler, clusterDeleteHandler, clusterSetDeletingHandler, clusterClearDeletingHandler } from "../../../common/ipc/cluster";
 import type { ClusterId } from "../../../common/cluster-types";

src/main/ipc/dialog.ts

@@ -3,7 +3,8 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 
-import { BrowserWindow, dialog, OpenDialogOptions } from "electron";
+import type { OpenDialogOptions } from "electron";
+import { BrowserWindow, dialog } from "electron";
 
 export async function showOpenDialog(dialogOptions: OpenDialogOptions): Promise<{ canceled: boolean; filePaths: string[] }> {
   const { canceled, filePaths } = await dialog.showOpenDialog(BrowserWindow.getFocusedWindow(), dialogOptions);

src/main/k8s-request.ts

@@ -3,7 +3,8 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 
-import request, { RequestPromiseOptions } from "request-promise-native";
+import type { RequestPromiseOptions } from "request-promise-native";
+import request from "request-promise-native";
 import { apiKubePrefix } from "../common/vars";
 import type { IMetricsReqParams } from "../common/k8s-api/endpoints/metrics.api";
 import { LensProxy } from "./lens-proxy";

src/main/kube-auth-proxy/create-kube-auth-proxy.injectable.ts

@@ -3,7 +3,8 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 import { getInjectable } from "@ogre-tools/injectable";
-import { KubeAuthProxy, KubeAuthProxyDependencies } from "./kube-auth-proxy";
+import type { KubeAuthProxyDependencies } from "./kube-auth-proxy";
+import { KubeAuthProxy } from "./kube-auth-proxy";
 import type { Cluster } from "../../common/cluster/cluster";
 import path from "path";
 import selfsigned from "selfsigned";

src/main/menu/application-menu-items.injectable.ts

@@ -10,10 +10,11 @@ import { broadcastMessage } from "../../common/ipc";
 import { openBrowser } from "../../common/utils";
 import { showAbout } from "./menu";
 import windowManagerInjectable from "../window-manager.injectable";
-import {
+import type {
   BrowserWindow,
   MenuItem,
-  MenuItemConstructorOptions,
+  MenuItemConstructorOptions } from "electron";
+import {
   webContents,
 } from "electron";
 import loggerInjectable from "../../common/logger.injectable";

src/main/menu/menu.ts

@@ -2,8 +2,10 @@
  * Copyright (c) OpenLens Authors. All rights reserved.
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
-import { app, BrowserWindow, dialog, Menu } from "electron";
-import { autorun, IComputedValue } from "mobx";
+import type { BrowserWindow } from "electron";
+import { app, dialog, Menu } from "electron";
+import type { IComputedValue } from "mobx";
+import { autorun } from "mobx";
 import { appName, isWindows, productName } from "../../common/vars";
 import packageJson from "../../../package.json";
 import type { MenuItemOpts } from "./application-menu-items.injectable";

src/main/prometheus/lens.ts

@@ -3,7 +3,8 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 
-import { PrometheusProvider, PrometheusService } from "./provider-registry";
+import type { PrometheusService } from "./provider-registry";
+import { PrometheusProvider } from "./provider-registry";
 import type { CoreV1Api } from "@kubernetes/client-node";
 import { inspect } from "util";
 

src/main/prometheus/operator.ts

@@ -3,7 +3,8 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 
-import { PrometheusProvider, PrometheusService } from "./provider-registry";
+import type { PrometheusService } from "./provider-registry";
+import { PrometheusProvider } from "./provider-registry";
 import type { CoreV1Api } from "@kubernetes/client-node";
 import { inspect } from "util";
 

src/main/prometheus/stacklight.ts

@@ -3,7 +3,8 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 
-import { PrometheusProvider, PrometheusService } from "./provider-registry";
+import type { PrometheusService } from "./provider-registry";
+import { PrometheusProvider } from "./provider-registry";
 import type { CoreV1Api } from "@kubernetes/client-node";
 import { inspect } from "util";
 

src/main/protocol-handler/lens-protocol-router-main/lens-protocol-router-main.ts

@@ -9,7 +9,8 @@ import URLParse from "url-parse";
 import type { LensExtension } from "../../../extensions/lens-extension";
 import { broadcastMessage } from "../../../common/ipc";
 import { observable, when, makeObservable } from "mobx";
-import { ProtocolHandlerInvalid, RouteAttempt } from "../../../common/protocol-handler";
+import type { RouteAttempt } from "../../../common/protocol-handler";
+import { ProtocolHandlerInvalid } from "../../../common/protocol-handler";
 import { disposer, noop } from "../../../common/utils";
 import { WindowManager } from "../../window-manager";
 import type { ExtensionLoader } from "../../../extensions/extension-loader";

src/main/proxy-functions/shell-api-request/shell-api-request.ts

@@ -4,7 +4,8 @@
  */
 
 import logger from "../../logger";
-import WebSocket, { Server as WebSocketServer } from "ws";
+import type WebSocket from "ws";
+import { Server as WebSocketServer } from "ws";
 import type { ProxyApiRequestArgs } from "../types";
 import { ClusterManager } from "../../cluster-manager";
 import URLParse from "url-parse";

src/main/router/router.injectable.ts

@@ -3,7 +3,8 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 import { getInjectable, getInjectionToken } from "@ogre-tools/injectable";
-import { Route, Router } from "./router";
+import type { Route } from "./router";
+import { Router } from "./router";
 import parseRequestInjectable from "./parse-request.injectable";
 
 export const routeInjectionToken = getInjectionToken<Route<any>>({

src/main/routes/kubeconfig-route/get-service-account-route.injectable.ts

@@ -8,7 +8,8 @@ import { apiPrefix } from "../../../common/vars";
 import type { Route } from "../../router/router";
 import { routeInjectionToken } from "../../router/router.injectable";
 import type { Cluster } from "../../../common/cluster/cluster";
-import { CoreV1Api, V1Secret } from "@kubernetes/client-node";
+import type { V1Secret } from "@kubernetes/client-node";
+import { CoreV1Api } from "@kubernetes/client-node";
 
 const getServiceAccountRouteInjectable = getInjectable({
   id: "get-service-account-route",

src/main/routes/metrics/add-metrics-route.injectable.ts

@@ -7,7 +7,8 @@ import { getInjectable } from "@ogre-tools/injectable";
 import { apiPrefix } from "../../../common/vars";
 import type { LensApiRequest, Route } from "../../router/router";
 import { routeInjectionToken } from "../../router/router.injectable";
-import { ClusterMetadataKey, ClusterPrometheusMetadata } from "../../../common/cluster-types";
+import type { ClusterPrometheusMetadata } from "../../../common/cluster-types";
+import { ClusterMetadataKey } from "../../../common/cluster-types";
 import logger from "../../logger";
 import type { Cluster } from "../../../common/cluster/cluster";
 import { getMetrics } from "../../k8s-request";

src/main/routes/port-forward/functionality/create-port-forward.injectable.ts

@@ -3,7 +3,8 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 import { getInjectable } from "@ogre-tools/injectable";
-import { PortForward, PortForwardArgs } from "./port-forward";
+import type { PortForwardArgs } from "./port-forward";
+import { PortForward } from "./port-forward";
 import bundledKubectlInjectable from "../../../kubectl/bundled-kubectl.injectable";
 
 const createPortForwardInjectable = getInjectable({

src/main/routes/port-forward/functionality/port-forward.ts

@@ -4,7 +4,8 @@
  */
 import logger from "../../../logger";
 import { getPortFrom } from "../../../utils/get-port";
-import { spawn, ChildProcessWithoutNullStreams } from "child_process";
+import type { ChildProcessWithoutNullStreams } from "child_process";
+import { spawn } from "child_process";
 import * as tcpPortUsed from "tcp-port-used";
 
 const internalPortRegex = /^forwarding from (?<address>.+) ->/i;

src/main/routes/port-forward/start-port-forward-route.injectable.ts

@@ -6,7 +6,8 @@ import { getInjectable } from "@ogre-tools/injectable";
 import { routeInjectionToken } from "../../router/router.injectable";
 import type { LensApiRequest, Route } from "../../router/router";
 import { apiPrefix } from "../../../common/vars";
-import { PortForward, PortForwardArgs } from "./functionality/port-forward";
+import type { PortForwardArgs } from "./functionality/port-forward";
+import { PortForward } from "./functionality/port-forward";
 import logger from "../../logger";
 import createPortForwardInjectable from "./functionality/create-port-forward.injectable";
 

src/main/routes/static-file-route.injectable.ts

@@ -4,7 +4,8 @@
  */
 import { getInjectable } from "@ogre-tools/injectable";
 import type { LensApiRequest, Route } from "../router/router";
-import { contentTypes, SupportedFileExtension } from "../router/router-content-types";
+import type { SupportedFileExtension } from "../router/router-content-types";
+import { contentTypes } from "../router/router-content-types";
 import logger from "../logger";
 import { routeInjectionToken } from "../router/router.injectable";
 import { appName, publicPath } from "../../common/vars";
@@ -12,7 +13,8 @@ import path from "path";
 import isDevelopmentInjectable from "../../common/vars/is-development.injectable";
 import httpProxy from "http-proxy";
 import readFileBufferInjectable from "../../common/fs/read-file-buffer.injectable";
-import getAbsolutePathInjectable, { GetAbsolutePath } from "../../common/path/get-absolute-path.injectable";
+import type { GetAbsolutePath } from "../../common/path/get-absolute-path.injectable";
+import getAbsolutePathInjectable from "../../common/path/get-absolute-path.injectable";
 import type { JoinPaths } from "../../common/path/join-paths.injectable";
 import joinPathsInjectable from "../../common/path/join-paths.injectable";
 

src/main/shell-session/shell-env-modifier/terminal-shell-env-modifiers.ts

@@ -3,7 +3,8 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 
-import { computed, IComputedValue } from "mobx";
+import type { IComputedValue } from "mobx";
+import { computed } from "mobx";
 import type { ClusterId } from "../../../common/cluster-types";
 import type { LensMainExtension } from "../../../extensions/lens-main-extension";
 import { catalogEntityRegistry } from "../../catalog";

src/main/shell-session/shell-session.ts

@@ -16,7 +16,8 @@ import { UserStore } from "../../common/user-store";
 import * as pty from "node-pty";
 import { appEventBus } from "../../common/app-event-bus/event-bus";
 import logger from "../logger";
-import { TerminalChannels, TerminalMessage } from "../../renderer/api/terminal-api";
+import type { TerminalMessage } from "../../renderer/api/terminal-api";
+import { TerminalChannels } from "../../renderer/api/terminal-api";
 import { deserialize, serialize } from "v8";
 import { stat } from "fs/promises";
 

src/main/tray/tray.ts

@@ -6,7 +6,8 @@
 import path from "path";
 import packageInfo from "../../../package.json";
 import { Menu, Tray } from "electron";
-import { autorun, IComputedValue } from "mobx";
+import type { IComputedValue } from "mobx";
+import { autorun } from "mobx";
 import { showAbout } from "../menu/menu";
 import { checkForUpdates, isAutoUpdateEnabled } from "../app-updater";
 import type { WindowManager } from "../window-manager";

src/main/window-manager.ts

@@ -10,7 +10,8 @@ import windowStateKeeper from "electron-window-state";
 import { appEventBus } from "../common/app-event-bus/event-bus";
 import { ipcMainOn } from "../common/ipc";
 import { delay, iter, Singleton, openBrowser } from "../common/utils";
-import { ClusterFrameInfo, clusterFrameMap } from "../common/cluster-frames";
+import type { ClusterFrameInfo } from "../common/cluster-frames";
+import { clusterFrameMap } from "../common/cluster-frames";
 import { IpcRendererNavigationEvents } from "../renderer/navigation/events";
 import logger from "./logger";
 import { isMac, productName } from "../common/vars";