diff --git a/packages/business-features/dock/package.json b/packages/business-features/dock/package.json index b9c24b9b48..9464d6072e 100644 --- a/packages/business-features/dock/package.json +++ b/packages/business-features/dock/package.json @@ -31,6 +31,7 @@ }, "peerDependencies": { "@k8slens/feature-core": "^6.5.0-alpha.0", + "@k8slens/basic-dependency-features": "^1.0.0-alpha.0", "@k8slens/ui-components": "^1.0.0-alpha.0", "@ogre-tools/fp": "^15.1.2", "@ogre-tools/injectable": "^15.1.2", @@ -40,7 +41,8 @@ "mobx": "^6.8.0", "mobx-react": "^7.6.0", "lodash": "^4.17.21", - "react": "^17" + "react": "^17", + "react-dom": "^17" }, "devDependencies": { "@async-fn/jest": "^1.6.4", diff --git a/packages/business-features/dock/src/dock.test.tsx b/packages/business-features/dock/src/dock.test.tsx index 0c724e6d4f..a857c2c18f 100644 --- a/packages/business-features/dock/src/dock.test.tsx +++ b/packages/business-features/dock/src/dock.test.tsx @@ -1,7 +1,5 @@ import { runInAction } from "mobx"; import { createContainer, DiContainer, getInjectable } from "@ogre-tools/injectable"; -import { registerMobX } from "@ogre-tools/injectable-extension-for-mobx"; -import { registerInjectableReact } from "@ogre-tools/injectable-react"; import { renderFor } from "@k8slens/test-utils"; import { DockHost } from "./dock/dock-host"; import React from "react"; @@ -18,11 +16,8 @@ describe("DockHost, given rendered", () => { beforeEach(() => { di = createContainer("some-container"); - registerMobX(di); - registerInjectableReact(di); - runInAction(() => { - registerFeature(di, dockFeature); - }); + + registerFeature(di, dockFeature); const render = renderFor(di); diff --git a/packages/business-features/dock/src/feature.ts b/packages/business-features/dock/src/feature.ts index fb49ccd01d..ea99a2d0e0 100644 --- a/packages/business-features/dock/src/feature.ts +++ b/packages/business-features/dock/src/feature.ts @@ -1,5 +1,6 @@ import { getFeature } from "@k8slens/feature-core"; import { autoRegister } from "@ogre-tools/injectable-extension-for-auto-registration"; +import { injectableMobXFeature, injectableReactFeature } from "@k8slens/basic-dependency-features"; export const dockFeature = getFeature({ id: "dock", @@ -11,4 +12,6 @@ export const dockFeature = getFeature({ getRequireContexts: () => [require.context("./", true, /\.injectable\.(ts|tsx)$/)], }); }, + + dependencies: [injectableReactFeature, injectableMobXFeature], });