From 1b46ccd18b6be1e194763bea39ef8281ddd033d2 Mon Sep 17 00:00:00 2001
From: Janne Savolainen
Date: Thu, 19 May 2022 11:31:22 +0300
Subject: [PATCH] Make notifications unit testable in behaviours
Signed-off-by: Janne Savolainen
---
...acters-in-page-registrations.test.tsx.snap | 11 +-
.../navigate-to-extension-page.test.tsx.snap | 20 ++-
.../navigating-between-routes.test.tsx.snap | 6 +
...ation-using-application-menu.test.tsx.snap | 11 +-
.../order-of-sidebar-items.test.tsx.snap | 6 +
...-and-tab-navigation-for-core.test.tsx.snap | 21 +++
...ab-navigation-for-extensions.test.tsx.snap | 24 ++++
.../visibility-of-sidebar-items.test.tsx.snap | 6 +
...gation-using-application-menu.test.ts.snap | 11 +-
.../navigation-to-helm-charts.test.ts.snap | 3 +
.../closing-preferences.test.tsx.snap | 24 ++++
...on-to-application-preferences.test.ts.snap | 6 +
...igation-to-editor-preferences.test.ts.snap | 6 +
...tension-specific-preferences.test.tsx.snap | 9 ++
...ion-to-kubernetes-preferences.test.ts.snap | 37 +++--
...vigation-to-proxy-preferences.test.ts.snap | 6 +
...ion-to-telemetry-preferences.test.tsx.snap | 15 ++
...ation-to-terminal-preferences.test.ts.snap | 6 +
...gation-using-application-menu.test.ts.snap | 11 +-
.../navigation-using-tray.test.ts.snap | 9 +-
.../installing-update-using-tray.test.ts.snap | 54 ++++++--
...gation-using-application-menu.test.ts.snap | 11 +-
.../notifications-store.injectable.ts | 13 ++
.../notifications/notifications.store.tsx | 2 -
.../notifications/notifications.tsx | 128 +++++++++++-------
.../test-utils/get-application-builder.tsx | 4 +-
...amespaces-forbidden-handler.injectable.tsx | 4 +-
src/renderer/ipc/register-listeners.tsx | 3 +-
.../about-port-forwarding.injectable.ts | 6 +-
...notify-error-port-forwarding.injectable.ts | 6 +-
.../port-forward/port-forward-notify.tsx | 7 +-
31 files changed, 403 insertions(+), 83 deletions(-)
create mode 100644 src/renderer/components/notifications/notifications-store.injectable.ts
diff --git a/src/behaviours/__snapshots__/extension-special-characters-in-page-registrations.test.tsx.snap b/src/behaviours/__snapshots__/extension-special-characters-in-page-registrations.test.tsx.snap
index 3b43a51f66..80b0028469 100644
--- a/src/behaviours/__snapshots__/extension-special-characters-in-page-registrations.test.tsx.snap
+++ b/src/behaviours/__snapshots__/extension-special-characters-in-page-registrations.test.tsx.snap
@@ -1,11 +1,20 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
-exports[`extension special characters in page registrations renders 1`] = ``;
+exports[`extension special characters in page registrations renders 1`] = `
+
+`;
exports[`extension special characters in page registrations when navigating to route with ID having special characters renders 1`] = `
`;
diff --git a/src/behaviours/__snapshots__/navigate-to-extension-page.test.tsx.snap b/src/behaviours/__snapshots__/navigate-to-extension-page.test.tsx.snap
index edab04b903..c96763fe6e 100644
--- a/src/behaviours/__snapshots__/navigate-to-extension-page.test.tsx.snap
+++ b/src/behaviours/__snapshots__/navigate-to-extension-page.test.tsx.snap
@@ -1,12 +1,21 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
-exports[`navigate to extension page renders 1`] = ``;
+exports[`navigate to extension page renders 1`] = `
+
+`;
exports[`navigate to extension page when extension navigates to child route renders 1`] = `
`;
@@ -31,6 +40,9 @@ exports[`navigate to extension page when extension navigates to route with param
Some button
+
`;
@@ -55,6 +67,9 @@ exports[`navigate to extension page when extension navigates to route without pa
Some button
+
`;
@@ -79,5 +94,8 @@ exports[`navigate to extension page when extension navigates to route without pa
Some button
+
`;
diff --git a/src/behaviours/__snapshots__/navigating-between-routes.test.tsx.snap b/src/behaviours/__snapshots__/navigating-between-routes.test.tsx.snap
index 90ff615b2b..10e9eb2d39 100644
--- a/src/behaviours/__snapshots__/navigating-between-routes.test.tsx.snap
+++ b/src/behaviours/__snapshots__/navigating-between-routes.test.tsx.snap
@@ -8,6 +8,9 @@ exports[`navigating between routes given route with optional path parameters whe
"someOtherParameter": "some-other-value"
}
+
`;
@@ -16,5 +19,8 @@ exports[`navigating between routes given route without path parameters when navi
Some component
+
`;
diff --git a/src/behaviours/add-cluster/__snapshots__/navigation-using-application-menu.test.tsx.snap b/src/behaviours/add-cluster/__snapshots__/navigation-using-application-menu.test.tsx.snap
index d19612eac3..0fd00133aa 100644
--- a/src/behaviours/add-cluster/__snapshots__/navigation-using-application-menu.test.tsx.snap
+++ b/src/behaviours/add-cluster/__snapshots__/navigation-using-application-menu.test.tsx.snap
@@ -1,6 +1,12 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
-exports[`add-cluster - navigation using application menu renders 1`] = ``;
+exports[`add-cluster - navigation using application menu renders 1`] = `
+
+`;
exports[`add-cluster - navigation using application menu when navigating to add cluster using application menu renders 1`] = `
@@ -85,5 +91,8 @@ exports[`add-cluster - navigation using application menu when navigating to add
+
`;
diff --git a/src/behaviours/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap b/src/behaviours/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap
index 092337ec82..9af01f0969 100644
--- a/src/behaviours/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap
+++ b/src/behaviours/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap
@@ -328,6 +328,9 @@ exports[`cluster - order of sidebar items when rendered renders 1`] = `
+
`;
@@ -723,5 +726,8 @@ exports[`cluster - order of sidebar items when rendered when parent is expanded
+
`;
diff --git a/src/behaviours/cluster/__snapshots__/sidebar-and-tab-navigation-for-core.test.tsx.snap b/src/behaviours/cluster/__snapshots__/sidebar-and-tab-navigation-for-core.test.tsx.snap
index ad1f7a8d4c..06d1a1e210 100644
--- a/src/behaviours/cluster/__snapshots__/sidebar-and-tab-navigation-for-core.test.tsx.snap
+++ b/src/behaviours/cluster/__snapshots__/sidebar-and-tab-navigation-for-core.test.tsx.snap
@@ -293,6 +293,9 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
+
`;
@@ -589,6 +592,9 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
+
`;
@@ -909,6 +915,9 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
+
`;
@@ -1234,6 +1243,9 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
+
`;
@@ -1534,6 +1546,9 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
+
`;
@@ -1854,6 +1869,9 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
+
`;
@@ -2150,5 +2168,8 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
+
`;
diff --git a/src/behaviours/cluster/__snapshots__/sidebar-and-tab-navigation-for-extensions.test.tsx.snap b/src/behaviours/cluster/__snapshots__/sidebar-and-tab-navigation-for-extensions.test.tsx.snap
index be9c321cd5..19cb615cce 100644
--- a/src/behaviours/cluster/__snapshots__/sidebar-and-tab-navigation-for-extensions.test.tsx.snap
+++ b/src/behaviours/cluster/__snapshots__/sidebar-and-tab-navigation-for-extensions.test.tsx.snap
@@ -293,6 +293,9 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
+
`;
@@ -589,6 +592,9 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
+
`;
@@ -929,6 +935,9 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
+
`;
@@ -1313,6 +1322,9 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
+
`;
@@ -1697,6 +1709,9 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
+
`;
@@ -2036,6 +2051,9 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
+
`;
@@ -2376,6 +2394,9 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
+
`;
@@ -2672,5 +2693,8 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
+
`;
diff --git a/src/behaviours/cluster/__snapshots__/visibility-of-sidebar-items.test.tsx.snap b/src/behaviours/cluster/__snapshots__/visibility-of-sidebar-items.test.tsx.snap
index 4f28c6ecef..cc44f56496 100644
--- a/src/behaviours/cluster/__snapshots__/visibility-of-sidebar-items.test.tsx.snap
+++ b/src/behaviours/cluster/__snapshots__/visibility-of-sidebar-items.test.tsx.snap
@@ -261,6 +261,9 @@ exports[`cluster - visibility of sidebar items given kube resource for route is
+
`;
@@ -573,5 +576,8 @@ exports[`cluster - visibility of sidebar items given kube resource for route is
+
`;
diff --git a/src/behaviours/extensions/__snapshots__/navigation-using-application-menu.test.ts.snap b/src/behaviours/extensions/__snapshots__/navigation-using-application-menu.test.ts.snap
index 3a1b1309dd..c14ccb6160 100644
--- a/src/behaviours/extensions/__snapshots__/navigation-using-application-menu.test.ts.snap
+++ b/src/behaviours/extensions/__snapshots__/navigation-using-application-menu.test.ts.snap
@@ -1,6 +1,12 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
-exports[`extensions - navigation using application menu renders 1`] = ``;
+exports[`extensions - navigation using application menu renders 1`] = `
+
+`;
exports[`extensions - navigation using application menu when navigating to extensions using application menu renders 1`] = `
@@ -118,5 +124,8 @@ exports[`extensions - navigation using application menu when navigating to exten
+
`;
diff --git a/src/behaviours/helm-charts/__snapshots__/navigation-to-helm-charts.test.ts.snap b/src/behaviours/helm-charts/__snapshots__/navigation-to-helm-charts.test.ts.snap
index 4f1555049d..e323205008 100644
--- a/src/behaviours/helm-charts/__snapshots__/navigation-to-helm-charts.test.ts.snap
+++ b/src/behaviours/helm-charts/__snapshots__/navigation-to-helm-charts.test.ts.snap
@@ -454,5 +454,8 @@ exports[`helm-charts - navigation to Helm charts when navigating to Helm charts
+
`;
diff --git a/src/behaviours/preferences/__snapshots__/closing-preferences.test.tsx.snap b/src/behaviours/preferences/__snapshots__/closing-preferences.test.tsx.snap
index cb4973203d..740e01edbb 100644
--- a/src/behaviours/preferences/__snapshots__/closing-preferences.test.tsx.snap
+++ b/src/behaviours/preferences/__snapshots__/closing-preferences.test.tsx.snap
@@ -537,6 +537,9 @@ exports[`preferences - closing-preferences given accessing preferences directly
+
`;
@@ -679,6 +682,9 @@ exports[`preferences - closing-preferences given accessing preferences directly
+
`;
@@ -687,6 +693,9 @@ exports[`preferences - closing-preferences given accessing preferences directly
Some front page
+
`;
@@ -695,6 +704,9 @@ exports[`preferences - closing-preferences given accessing preferences directly
Some front page
+
`;
@@ -1235,6 +1247,9 @@ exports[`preferences - closing-preferences given already in a page and then navi
+
`;
@@ -1377,6 +1392,9 @@ exports[`preferences - closing-preferences given already in a page and then navi
+
`;
@@ -1519,6 +1537,9 @@ exports[`preferences - closing-preferences given already in a page and then navi
+
`;
@@ -1661,5 +1682,8 @@ exports[`preferences - closing-preferences given already in a page and then navi
+
`;
diff --git a/src/behaviours/preferences/__snapshots__/navigation-to-application-preferences.test.ts.snap b/src/behaviours/preferences/__snapshots__/navigation-to-application-preferences.test.ts.snap
index f67337e80c..57e68c4ea5 100644
--- a/src/behaviours/preferences/__snapshots__/navigation-to-application-preferences.test.ts.snap
+++ b/src/behaviours/preferences/__snapshots__/navigation-to-application-preferences.test.ts.snap
@@ -199,6 +199,9 @@ exports[`preferences - navigation to application preferences given in some child
+
`;
@@ -727,5 +730,8 @@ exports[`preferences - navigation to application preferences given in some child
+
`;
diff --git a/src/behaviours/preferences/__snapshots__/navigation-to-editor-preferences.test.ts.snap b/src/behaviours/preferences/__snapshots__/navigation-to-editor-preferences.test.ts.snap
index 4e92ac4f95..8daf6eb997 100644
--- a/src/behaviours/preferences/__snapshots__/navigation-to-editor-preferences.test.ts.snap
+++ b/src/behaviours/preferences/__snapshots__/navigation-to-editor-preferences.test.ts.snap
@@ -525,6 +525,9 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
+
`;
@@ -935,5 +938,8 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
+
`;
diff --git a/src/behaviours/preferences/__snapshots__/navigation-to-extension-specific-preferences.test.tsx.snap b/src/behaviours/preferences/__snapshots__/navigation-to-extension-specific-preferences.test.tsx.snap
index d3f42e6d63..609350c455 100644
--- a/src/behaviours/preferences/__snapshots__/navigation-to-extension-specific-preferences.test.tsx.snap
+++ b/src/behaviours/preferences/__snapshots__/navigation-to-extension-specific-preferences.test.tsx.snap
@@ -525,6 +525,9 @@ exports[`preferences - navigation to extension specific preferences given in pre
+
`;
@@ -1065,6 +1068,9 @@ exports[`preferences - navigation to extension specific preferences given in pre
+
`;
@@ -1239,5 +1245,8 @@ exports[`preferences - navigation to extension specific preferences given in pre
+
`;
diff --git a/src/behaviours/preferences/__snapshots__/navigation-to-kubernetes-preferences.test.ts.snap b/src/behaviours/preferences/__snapshots__/navigation-to-kubernetes-preferences.test.ts.snap
index 2e9b7722aa..c962cfb2ab 100644
--- a/src/behaviours/preferences/__snapshots__/navigation-to-kubernetes-preferences.test.ts.snap
+++ b/src/behaviours/preferences/__snapshots__/navigation-to-kubernetes-preferences.test.ts.snap
@@ -525,6 +525,9 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
+
`;
@@ -836,7 +839,7 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
class="flex gaps"
>
@@ -969,5 +985,8 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
+
`;
diff --git a/src/behaviours/preferences/__snapshots__/navigation-to-proxy-preferences.test.ts.snap b/src/behaviours/preferences/__snapshots__/navigation-to-proxy-preferences.test.ts.snap
index 8c6507ef0a..2718c892e7 100644
--- a/src/behaviours/preferences/__snapshots__/navigation-to-proxy-preferences.test.ts.snap
+++ b/src/behaviours/preferences/__snapshots__/navigation-to-proxy-preferences.test.ts.snap
@@ -525,6 +525,9 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
+
`;
@@ -727,5 +730,8 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
+
`;
diff --git a/src/behaviours/preferences/__snapshots__/navigation-to-telemetry-preferences.test.tsx.snap b/src/behaviours/preferences/__snapshots__/navigation-to-telemetry-preferences.test.tsx.snap
index 80f5b61bb1..0187d3573e 100644
--- a/src/behaviours/preferences/__snapshots__/navigation-to-telemetry-preferences.test.tsx.snap
+++ b/src/behaviours/preferences/__snapshots__/navigation-to-telemetry-preferences.test.tsx.snap
@@ -185,6 +185,9 @@ exports[`preferences - navigation to telemetry preferences given URL for Sentry
+
`;
@@ -713,6 +716,9 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
+
`;
@@ -1253,6 +1259,9 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
+
`;
@@ -1429,6 +1438,9 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
+
`;
@@ -1568,5 +1580,8 @@ exports[`preferences - navigation to telemetry preferences given no URL for Sent
+
`;
diff --git a/src/behaviours/preferences/__snapshots__/navigation-to-terminal-preferences.test.ts.snap b/src/behaviours/preferences/__snapshots__/navigation-to-terminal-preferences.test.ts.snap
index 5e5934c3bb..8cd1678235 100644
--- a/src/behaviours/preferences/__snapshots__/navigation-to-terminal-preferences.test.ts.snap
+++ b/src/behaviours/preferences/__snapshots__/navigation-to-terminal-preferences.test.ts.snap
@@ -525,6 +525,9 @@ exports[`preferences - navigation to terminal preferences given in preferences,
+
`;
@@ -845,5 +848,8 @@ exports[`preferences - navigation to terminal preferences given in preferences,
+
`;
diff --git a/src/behaviours/preferences/__snapshots__/navigation-using-application-menu.test.ts.snap b/src/behaviours/preferences/__snapshots__/navigation-using-application-menu.test.ts.snap
index 141279f4e4..f49e4d460a 100644
--- a/src/behaviours/preferences/__snapshots__/navigation-using-application-menu.test.ts.snap
+++ b/src/behaviours/preferences/__snapshots__/navigation-using-application-menu.test.ts.snap
@@ -1,6 +1,12 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
-exports[`preferences - navigation using application menu renders 1`] = ``;
+exports[`preferences - navigation using application menu renders 1`] = `
+
+`;
exports[`preferences - navigation using application menu when navigating to preferences using application menu renders 1`] = `
@@ -527,5 +533,8 @@ exports[`preferences - navigation using application menu when navigating to pref
+
`;
diff --git a/src/behaviours/preferences/__snapshots__/navigation-using-tray.test.ts.snap b/src/behaviours/preferences/__snapshots__/navigation-using-tray.test.ts.snap
index 0abb2bd928..398e4d4b05 100644
--- a/src/behaviours/preferences/__snapshots__/navigation-using-tray.test.ts.snap
+++ b/src/behaviours/preferences/__snapshots__/navigation-using-tray.test.ts.snap
@@ -2,7 +2,11 @@
exports[`show-about-using-tray renders 1`] = `
-
+
`;
@@ -532,6 +536,9 @@ exports[`show-about-using-tray when navigating using tray renders 1`] = `
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+