mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
Improve interface name
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
parent
c28bb4f775
commit
1baaf37c13
@ -37,7 +37,7 @@ interface Dependencies {
|
|||||||
getDirnameOfPath: GetDirnameOfPath;
|
getDirnameOfPath: GetDirnameOfPath;
|
||||||
}
|
}
|
||||||
|
|
||||||
interface SemiLoadedExtension {
|
interface ExtensionBeingActivated {
|
||||||
instance: LensExtension;
|
instance: LensExtension;
|
||||||
installedExtension: InstalledExtension;
|
installedExtension: InstalledExtension;
|
||||||
activated: Promise<void>;
|
activated: Promise<void>;
|
||||||
@ -287,7 +287,7 @@ export class ExtensionLoader {
|
|||||||
instance,
|
instance,
|
||||||
installedExtension,
|
installedExtension,
|
||||||
activated: instance.activate(),
|
activated: instance.activate(),
|
||||||
} as SemiLoadedExtension;
|
} as ExtensionBeingActivated;
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
this.dependencies.logger.error(`${logModule}: error loading extension`, { ext: extension, err });
|
this.dependencies.logger.error(`${logModule}: error loading extension`, { ext: extension, err });
|
||||||
|
|
||||||
@ -297,7 +297,7 @@ export class ExtensionLoader {
|
|||||||
.filter(isDefined);
|
.filter(isDefined);
|
||||||
}
|
}
|
||||||
|
|
||||||
protected async loadExtensions(extensions: SemiLoadedExtension[]): Promise<ExtensionLoading[]> {
|
protected async loadExtensions(extensions: ExtensionBeingActivated[]): Promise<ExtensionLoading[]> {
|
||||||
// We first need to wait until each extension's `onActivate` is resolved or rejected,
|
// We first need to wait until each extension's `onActivate` is resolved or rejected,
|
||||||
// as this might register new catalog categories. Afterwards we can safely .enable the extension.
|
// as this might register new catalog categories. Afterwards we can safely .enable the extension.
|
||||||
await Promise.all(
|
await Promise.all(
|
||||||
@ -359,7 +359,7 @@ export class ExtensionLoader {
|
|||||||
instance,
|
instance,
|
||||||
installedExtension: extension,
|
installedExtension: extension,
|
||||||
activated: instance.activate(),
|
activated: instance.activate(),
|
||||||
} as SemiLoadedExtension;
|
} as ExtensionBeingActivated;
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
this.dependencies.logger.error(`${logModule}: error loading extension`, { ext: extension, err });
|
this.dependencies.logger.error(`${logModule}: error loading extension`, { ext: extension, err });
|
||||||
}
|
}
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user