hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Add LensRendererExtension.isEnabledForCluster (#1502)

Browse Source 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
This commit is contained in:
Jari Kolehmainen 2020-11-24 16:15:14 +02:00 committed by GitHub
parent cb14d77a56
commit 1be86b34f4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 30 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/extensions/extension-loader.ts
View File

@ -1,6 +1,7 @@
import { app, ipcRenderer, remote } from "electron"; import { app, ipcRenderer, remote } from "electron";
import { action, computed, observable, reaction, toJS, when } from "mobx"; import { action, computed, observable, reaction, toJS, when } from "mobx";
import path from "path"; import path from "path";
import { getHostedCluster } from "../common/cluster-store";
import { broadcastMessage, handleRequest, requestMain, subscribeToBroadcast } from "../common/ipc"; import { broadcastMessage, handleRequest, requestMain, subscribeToBroadcast } from "../common/ipc";
import logger from "../main/logger"; import logger from "../main/logger";
import type { InstalledExtension } from "./extension-discovery"; import type { InstalledExtension } from "./extension-discovery";
@ -94,14 +95,14 @@ export class ExtensionLoader {
loadOnMain() { loadOnMain() {
logger.info(`${logModule}: load on main`); logger.info(`${logModule}: load on main`);
this.autoInitExtensions((ext: LensMainExtension) => [ this.autoInitExtensions(async (ext: LensMainExtension) => [
registries.menuRegistry.add(ext.appMenus) registries.menuRegistry.add(ext.appMenus)
]); ]);
} }
loadOnClusterManagerRenderer() { loadOnClusterManagerRenderer() {
logger.info(`${logModule}: load on main renderer (cluster manager)`); logger.info(`${logModule}: load on main renderer (cluster manager)`);
this.autoInitExtensions((ext: LensRendererExtension) => [ this.autoInitExtensions(async (ext: LensRendererExtension) => [
registries.globalPageRegistry.add(ext.globalPages, ext), registries.globalPageRegistry.add(ext.globalPages, ext),
registries.globalPageMenuRegistry.add(ext.globalPageMenus, ext), registries.globalPageMenuRegistry.add(ext.globalPageMenus, ext),
registries.appPreferenceRegistry.add(ext.appPreferences), registries.appPreferenceRegistry.add(ext.appPreferences),
@ -112,16 +113,22 @@ export class ExtensionLoader {
loadOnClusterRenderer() { loadOnClusterRenderer() {
logger.info(`${logModule}: load on cluster renderer (dashboard)`); logger.info(`${logModule}: load on cluster renderer (dashboard)`);
this.autoInitExtensions((ext: LensRendererExtension) => [ const cluster = getHostedCluster();
registries.clusterPageRegistry.add(ext.clusterPages, ext), this.autoInitExtensions(async (ext: LensRendererExtension) => {
registries.clusterPageMenuRegistry.add(ext.clusterPageMenus, ext), if (await ext.isEnabledForCluster(cluster) === false) {
registries.kubeObjectMenuRegistry.add(ext.kubeObjectMenuItems), return [];
registries.kubeObjectDetailRegistry.add(ext.kubeObjectDetailItems), }
registries.kubeObjectStatusRegistry.add(ext.kubeObjectStatusTexts) return [
]); registries.clusterPageRegistry.add(ext.clusterPages, ext),
registries.clusterPageMenuRegistry.add(ext.clusterPageMenus, ext),
registries.kubeObjectMenuRegistry.add(ext.kubeObjectMenuItems),
registries.kubeObjectDetailRegistry.add(ext.kubeObjectDetailItems),
registries.kubeObjectStatusRegistry.add(ext.kubeObjectStatusTexts)
];
});
} }
protected autoInitExtensions(register: (ext: LensExtension) => Function[]) { protected autoInitExtensions(register: (ext: LensExtension) => Promise<Function[]>) {
return reaction(() => this.toJSON(), installedExtensions => { return reaction(() => this.toJSON(), installedExtensions => {
for (const [extId, ext] of installedExtensions) { for (const [extId, ext] of installedExtensions) {
let instance = this.instances.get(extId); let instance = this.instances.get(extId);

7
src/extensions/lens-extension.ts
View File

@ -67,15 +67,16 @@ export class LensExtension {
} }
} }
async whenEnabled(handlers: () => Function[]) { async whenEnabled(handlers: () => Promise<Function[]>) {
const disposers: Function[] = []; const disposers: Function[] = [];
const unregisterHandlers = () => { const unregisterHandlers = () => {
disposers.forEach(unregister => unregister()); disposers.forEach(unregister => unregister());
disposers.length = 0; disposers.length = 0;
}; };
const cancelReaction = reaction(() => this.isEnabled, isEnabled => { const cancelReaction = reaction(() => this.isEnabled, async (isEnabled) => {
if (isEnabled) { if (isEnabled) {
disposers.push(...handlers()); const handlerDisposers = await handlers();
disposers.push(...handlerDisposers);
} else { } else {
unregisterHandlers(); unregisterHandlers();
} }

9
src/extensions/lens-renderer-extension.ts
View File

@ -1,8 +1,10 @@
import type { AppPreferenceRegistration, ClusterFeatureRegistration, KubeObjectDetailRegistration, KubeObjectMenuRegistration, KubeObjectStatusRegistration, PageMenuRegistration, PageRegistration, StatusBarRegistration, } from "./registries"; import type { AppPreferenceRegistration, ClusterFeatureRegistration, KubeObjectDetailRegistration, KubeObjectMenuRegistration, KubeObjectStatusRegistration, PageMenuRegistration, PageRegistration, StatusBarRegistration, } from "./registries";
import type { Cluster } from "../main/cluster";
import { observable } from "mobx"; import { observable } from "mobx";
import { LensExtension } from "./lens-extension"; import { LensExtension } from "./lens-extension";
import { getExtensionPageUrl } from "./registries/page-registry"; import { getExtensionPageUrl } from "./registries/page-registry";
export class LensRendererExtension extends LensExtension { export class LensRendererExtension extends LensExtension {
@observable.shallow globalPages: PageRegistration[] = []; @observable.shallow globalPages: PageRegistration[] = [];
@observable.shallow clusterPages: PageRegistration[] = []; @observable.shallow clusterPages: PageRegistration[] = [];
@ -24,4 +26,11 @@ export class LensRendererExtension extends LensExtension {
}); });
navigate(pageUrl); navigate(pageUrl);
} }
/**
* Defines if extension is enabled for a given cluster. Defaults to `true`.
*/
async isEnabledForCluster(cluster: Cluster): Promise<Boolean> {
return true;
}
} }