hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Show system roles on Roles page (#355)

Browse Source 
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
This commit is contained in:
Lauri Nevala 2020-05-09 09:06:16 +03:00 committed by GitHub
parent 5cd00bd77a
commit 1c324a3ced
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dashboard/client/components/+user-management-roles-bindings/add-role-binding-dialog.tsx
View File

@ -9,7 +9,7 @@ import { Dialog, DialogProps } from "../dialog";
import { Wizard, WizardStep } from "../wizard";
import { Select, SelectOption } from "../select";
import { SubTitle } from "../layout/sub-title";
import { IRoleBindingSubject, RoleBinding, ServiceAccount } from "../../api/endpoints";
import { IRoleBindingSubject, RoleBinding, ServiceAccount, Role } from "../../api/endpoints";
import { Icon } from "../icon";
import { Input } from "../input";
import { NamespaceSelect } from "../+namespaces/namespace-select";
@ -152,7 +152,7 @@ export class AddRoleBindingDialog extends React.Component<Props> {
};
@computed get roleOptions(): BindingSelectOption[] {
let roles = rolesStore.items.filter(KubeObject.isNonSystem);
let roles = rolesStore.items as Role[]
if (this.bindContext) {
// show only cluster-roles or roles for selected context namespace
roles = roles.filter(role => !role.getNs() || role.getNs() === this.bindContext);

16
dashboard/client/components/+user-management-roles-bindings/role-bindings.tsx
View File

@ -42,22 +42,6 @@ export class RoleBindings extends React.Component<Props> {
(binding: RoleBinding) => binding.getSubjectNames(),
]}
renderHeaderTitle={<Trans>Role Bindings</Trans>}
filterItems={[
(items: RoleBinding[]) => items.filter(KubeObject.isNonSystem),
]}
customizeHeader={({ info }) => ({
info: (
<>
{info}
<Icon
small
material="help_outline"
className="help-icon"
tooltip={<Trans>Excluded items with "system:" prefix</Trans>}
/>
</>
)
})}
renderTableHeader={[
{ title: <Trans>Name</Trans>, className: "name", sortBy: sortBy.name },
{ title: <Trans>Bindings</Trans>, className: "bindings", sortBy: sortBy.bindings },

18
dashboard/client/components/+user-management-roles/roles.tsx
View File

@ -10,8 +10,6 @@ import { rolesStore } from "./roles.store";
import { clusterRoleApi, Role, roleApi } from "../../api/endpoints";
import { KubeObjectListLayout } from "../kube-object";
import { AddRoleDialog } from "./add-role-dialog";
import { Icon } from "../icon";
import { KubeObject } from "../../api/kube-object";
import { apiManager } from "../../api/api-manager";
enum sortBy {
@ -39,23 +37,7 @@ export class Roles extends React.Component<Props> {
searchFilters={[
(role: Role) => role.getSearchFields(),
]}
filterItems={[
(items: Role[]) => items.filter(KubeObject.isNonSystem),
]}
renderHeaderTitle={<Trans>Roles</Trans>}
customizeHeader={({ info }) => ({
info: (
<>
{info}
<Icon
small
material="help_outline"
className="help-icon"
tooltip={<Trans>Excluded items with "system:" prefix</Trans>}
/>
</>
)
})}
renderTableHeader={[
{ title: <Trans>Name</Trans>, className: "name", sortBy: sortBy.name },
{ title: <Trans>Namespace</Trans>, className: "namespace", sortBy: sortBy.namespace },