From 1c55fe6167d434beb4f84675da9d7c4e607c979b Mon Sep 17 00:00:00 2001 From: DmitriyNoa Date: Mon, 31 Jan 2022 16:37:54 +0100 Subject: [PATCH] Add reaction cleanup Signed-off-by: DmitriyNoa --- src/renderer/components/dock/dock-tabs.tsx | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/renderer/components/dock/dock-tabs.tsx b/src/renderer/components/dock/dock-tabs.tsx index bcbc622011..24becc3cfb 100644 --- a/src/renderer/components/dock/dock-tabs.tsx +++ b/src/renderer/components/dock/dock-tabs.tsx @@ -101,8 +101,6 @@ export const DockTabs = ({ tabs, autoFocus, selectedTab, onChangeTab, dockStore useEffect(() => { - updateStateValues(); - // update values in store on scroll elem.current.addEventListener("scroll", updateScrollPosition); @@ -110,11 +108,12 @@ export const DockTabs = ({ tabs, autoFocus, selectedTab, onChangeTab, dockStore window.addEventListener("resize", onWindowResize); // update scroll state if tabs numbers has changed - reaction(() => dockStore.tabsNumber, updateStateValues, { fireImmediately: true }); + const tabsNumberChangeDisposer = reaction(() => dockStore.tabsNumber, updateStateValues, { fireImmediately: true }); return () => { window.removeEventListener("resize", onWindowResize); elem.current.removeEventListener("scroll", updateScrollPosition); + tabsNumberChangeDisposer(); }; }, []);