From 1f88c05e82a3f2719520c6fbf15028b8929b9cf4 Mon Sep 17 00:00:00 2001 From: Roman Date: Thu, 12 Nov 2020 08:39:50 +0200 Subject: [PATCH] Refactoring: removed kube versioned api (#1328) Signed-off-by: Roman --- src/extensions/renderer-api/k8s-api.ts | 5 +-- src/renderer/api/endpoints/crd.api.ts | 7 ++-- src/renderer/api/kube-api-versioned.ts | 56 -------------------------- src/renderer/api/kube-api.ts | 43 +++++++++++++++++--- 4 files changed, 43 insertions(+), 68 deletions(-) delete mode 100644 src/renderer/api/kube-api-versioned.ts diff --git a/src/extensions/renderer-api/k8s-api.ts b/src/extensions/renderer-api/k8s-api.ts index 4dfaff0362..2a26b49cdd 100644 --- a/src/extensions/renderer-api/k8s-api.ts +++ b/src/extensions/renderer-api/k8s-api.ts @@ -2,7 +2,6 @@ export { isAllowedResource } from "../../common/rbac" export { apiManager } from "../../renderer/api/api-manager"; export { KubeObjectStore } from "../../renderer/kube-object.store" export { KubeApi, forCluster, IKubeApiCluster } from "../../renderer/api/kube-api"; -export { VersionedKubeApi } from "../../renderer/api/kube-api-versioned"; export { KubeObject } from "../../renderer/api/kube-object"; export { Pod, podsApi, PodsApi, IPodContainer, IPodContainerStatus } from "../../renderer/api/endpoints"; export { Node, nodesApi, NodesApi } from "../../renderer/api/endpoints"; @@ -32,10 +31,10 @@ export { RoleBinding, roleBindingApi } from "../../renderer/api/endpoints"; export { ClusterRole, clusterRoleApi } from "../../renderer/api/endpoints"; export { ClusterRoleBinding, clusterRoleBindingApi } from "../../renderer/api/endpoints"; export { CustomResourceDefinition, crdApi } from "../../renderer/api/endpoints"; -export { KubeObjectStatus, KubeObjectStatusLevel} from "./kube-object-status" +export { KubeObjectStatus, KubeObjectStatusLevel } from "./kube-object-status" // stores -export type { EventStore } from "../../renderer/components/+events/event.store" +export type { EventStore } from "../../renderer/components/+events/event.store" export type { PodsStore } from "../../renderer/components/+workloads-pods/pods.store" export type { NodesStore } from "../../renderer/components/+nodes/nodes.store" export type { DeploymentStore } from "../../renderer/components/+workloads-deployments/deployments.store" diff --git a/src/renderer/api/endpoints/crd.api.ts b/src/renderer/api/endpoints/crd.api.ts index 7b561041f7..1916d71f1b 100644 --- a/src/renderer/api/endpoints/crd.api.ts +++ b/src/renderer/api/endpoints/crd.api.ts @@ -1,6 +1,6 @@ import { KubeObject } from "../kube-object"; -import { VersionedKubeApi } from "../kube-api-versioned"; import { crdResourcesURL } from "../../components/+custom-resources/crd.route"; +import { KubeApi } from "../kube-api"; type AdditionalPrinterColumnsCommon = { name: string; @@ -146,6 +146,7 @@ export class CustomResourceDefinition extends KubeObject { } } -export const crdApi = new VersionedKubeApi({ - objectConstructor: CustomResourceDefinition +export const crdApi = new KubeApi({ + objectConstructor: CustomResourceDefinition, + checkPreferredVersion: true, }); diff --git a/src/renderer/api/kube-api-versioned.ts b/src/renderer/api/kube-api-versioned.ts deleted file mode 100644 index 59c1637b29..0000000000 --- a/src/renderer/api/kube-api-versioned.ts +++ /dev/null @@ -1,56 +0,0 @@ -import { stringify } from "querystring"; -import { KubeObject } from "./kube-object"; -import { createKubeApiURL } from "./kube-api-parse"; -import { KubeApi, IKubeApiQueryParams, IKubeApiOptions } from "./kube-api"; -import { apiManager } from "./api-manager"; - -export class VersionedKubeApi extends KubeApi { - private preferredVersion?: string; - - constructor(opts: IKubeApiOptions) { - super(opts); - - this.getPreferredVersion().then(() => { - if (this.apiBase != opts.apiBase) - apiManager.registerApi(this.apiBase, this); - }); - } - - // override this property to make read-write - apiBase: string - - async getPreferredVersion() { - if (this.preferredVersion) return; - - const apiGroupVersion = await this.request.get<{ preferredVersion?: { version: string; }; }>(`${this.apiPrefix}/${this.apiGroup}`); - - if (!apiGroupVersion?.preferredVersion) return; - - this.preferredVersion = apiGroupVersion.preferredVersion.version; - - // update apiBase - this.apiBase = this.getUrl(); - } - - async list({ namespace = "" } = {}, query?: IKubeApiQueryParams): Promise { - await this.getPreferredVersion(); - return await super.list({namespace}, query); - } - async get({ name = "", namespace = "default" } = {}, query?: IKubeApiQueryParams): Promise { - await this.getPreferredVersion(); - return super.get({ name, namespace }, query); - } - - getUrl({ name = "", namespace = "" } = {}, query?: Partial) { - const { apiPrefix, apiGroup, apiVersion, apiResource, preferredVersion, isNamespaced } = this; - - const resourcePath = createKubeApiURL({ - apiPrefix: apiPrefix, - apiVersion: `${apiGroup}/${preferredVersion ?? apiVersion}`, - resource: apiResource, - namespace: isNamespaced ? namespace : undefined, - name: name, - }); - return resourcePath + (query ? `?` + stringify(this.normalizeQuery(query)) : ""); - } -} diff --git a/src/renderer/api/kube-api.ts b/src/renderer/api/kube-api.ts index bcbd283709..c3c9698cfa 100644 --- a/src/renderer/api/kube-api.ts +++ b/src/renderer/api/kube-api.ts @@ -16,6 +16,7 @@ export interface IKubeApiOptions { request?: KubeJsonApi; isNamespaced?: boolean; kind?: string; + checkPreferredVersion?: boolean; } export interface IKubeApiQueryParams { @@ -28,6 +29,12 @@ export interface IKubeApiQueryParams { fieldSelector?: string | string[]; // restrict list of objects by their fields, e.g. fieldSelector: "field=name" } +export interface IKubePreferredVersion { + preferredVersion?: { + version: string; + } +} + export interface IKubeApiCluster { id: string; } @@ -60,7 +67,7 @@ export class KubeApi { readonly apiPrefix: string readonly apiGroup: string readonly apiVersion: string - readonly apiVersionWithGroup: string + readonly apiVersionPreferred?: string; readonly apiResource: string readonly isNamespaced: boolean @@ -86,15 +93,35 @@ export class KubeApi { this.apiPrefix = apiPrefix; this.apiGroup = apiGroup; this.apiVersion = apiVersion; - this.apiVersionWithGroup = apiVersionWithGroup; this.apiResource = resource; this.request = request; this.objectConstructor = objectConstructor; + this.checkPreferredVersion(); this.parseResponse = this.parseResponse.bind(this); apiManager.registerApi(apiBase, this); } + get apiVersionWithGroup() { + return [this.apiGroup, this.apiVersionPreferred ?? this.apiVersion] + .filter(Boolean) + .join("/") + } + + protected async checkPreferredVersion() { + if (this.options.checkPreferredVersion && this.apiVersionPreferred === undefined) { + const res = await this.request.get(`${this.apiPrefix}/${this.apiGroup}`); + Object.defineProperty(this, "apiVersionPreferred", { + value: res?.preferredVersion?.version ?? null, + }); + + if (this.apiVersionPreferred) { + Object.defineProperty(this, "apiBase", { value: this.getUrl() }) + apiManager.registerApi(this.apiBase, this); + } + } + } + setResourceVersion(namespace = "", newVersion: string) { this.resourceVersions.set(namespace, newVersion); } @@ -108,11 +135,10 @@ export class KubeApi { } getUrl({ name = "", namespace = "" } = {}, query?: Partial) { - const { apiPrefix, apiVersionWithGroup, apiResource } = this; const resourcePath = createKubeApiURL({ - apiPrefix: apiPrefix, - apiVersion: apiVersionWithGroup, - resource: apiResource, + apiPrefix: this.apiPrefix, + apiVersion: this.apiVersionWithGroup, + resource: this.apiResource, namespace: this.isNamespaced ? namespace : undefined, name: name, }); @@ -156,18 +182,21 @@ export class KubeApi { } async list({ namespace = "" } = {}, query?: IKubeApiQueryParams): Promise { + await this.checkPreferredVersion(); return this.request .get(this.getUrl({ namespace }), { query }) .then(data => this.parseResponse(data, namespace)); } async get({ name = "", namespace = "default" } = {}, query?: IKubeApiQueryParams): Promise { + await this.checkPreferredVersion(); return this.request .get(this.getUrl({ namespace, name }), { query }) .then(this.parseResponse); } async create({ name = "", namespace = "default" } = {}, data?: Partial): Promise { + await this.checkPreferredVersion(); const apiUrl = this.getUrl({ namespace }); return this.request @@ -185,6 +214,7 @@ export class KubeApi { } async update({ name = "", namespace = "default" } = {}, data?: Partial): Promise { + await this.checkPreferredVersion(); const apiUrl = this.getUrl({ namespace, name }); return this.request .put(apiUrl, { data }) @@ -192,6 +222,7 @@ export class KubeApi { } async delete({ name = "", namespace = "default" }) { + await this.checkPreferredVersion(); const apiUrl = this.getUrl({ namespace, name }); return this.request.del(apiUrl) }