hendrik/lens
1
0 Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix getElectronAppPathInjectable override not returning absolute paths

Browse Source 
- Also fixes the listing-active-helm-repos-in-prefs tests

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton committed 2022-10-04 17:55:33 -04:00
1 parent 1fbe3c482b
commit 2058860412
3 files changed
+23 -23
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/features/helm-charts/__snapshots__/listing-active-helm-repositories-in-preferences.test.ts.snap
+20 -20
View File
@@ -272,7 +272,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
<input
class="input box grow"
disabled=""
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries"
placeholder="/some-electron-app-path-for-user-data/binaries"
spellcheck="false"
value=""
/>
@@ -303,7 +303,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
>
<input
class="input box grow"
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries/kubectl"
placeholder="/some-electron-app-path-for-user-data/binaries/kubectl"
spellcheck="false"
value=""
/>
@@ -850,7 +850,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
<input
class="input box grow"
disabled=""
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries"
placeholder="/some-electron-app-path-for-user-data/binaries"
spellcheck="false"
value=""
/>
@@ -881,7 +881,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
>
<input
class="input box grow"
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries/kubectl"
placeholder="/some-electron-app-path-for-user-data/binaries/kubectl"
spellcheck="false"
value=""
/>
@@ -1428,7 +1428,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
<input
class="input box grow"
disabled=""
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries"
placeholder="/some-electron-app-path-for-user-data/binaries"
spellcheck="false"
value=""
/>
@@ -1459,7 +1459,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
>
<input
class="input box grow"
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries/kubectl"
placeholder="/some-electron-app-path-for-user-data/binaries/kubectl"
spellcheck="false"
value=""
/>
@@ -1898,7 +1898,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
<input
class="input box grow"
disabled=""
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries"
placeholder="/some-electron-app-path-for-user-data/binaries"
spellcheck="false"
value=""
/>
@@ -1929,7 +1929,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
>
<input
class="input box grow"
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries/kubectl"
placeholder="/some-electron-app-path-for-user-data/binaries/kubectl"
spellcheck="false"
value=""
/>
@@ -2476,7 +2476,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
<input
class="input box grow"
disabled=""
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries"
placeholder="/some-electron-app-path-for-user-data/binaries"
spellcheck="false"
value=""
/>
@@ -2507,7 +2507,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
>
<input
class="input box grow"
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries/kubectl"
placeholder="/some-electron-app-path-for-user-data/binaries/kubectl"
spellcheck="false"
value=""
/>
@@ -2946,7 +2946,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
<input
class="input box grow"
disabled=""
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries"
placeholder="/some-electron-app-path-for-user-data/binaries"
spellcheck="false"
value=""
/>
@@ -2977,7 +2977,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
>
<input
class="input box grow"
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries/kubectl"
placeholder="/some-electron-app-path-for-user-data/binaries/kubectl"
spellcheck="false"
value=""
/>
@@ -3524,7 +3524,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
<input
class="input box grow"
disabled=""
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries"
placeholder="/some-electron-app-path-for-user-data/binaries"
spellcheck="false"
value=""
/>
@@ -3555,7 +3555,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
>
<input
class="input box grow"
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries/kubectl"
placeholder="/some-electron-app-path-for-user-data/binaries/kubectl"
spellcheck="false"
value=""
/>
@@ -4147,7 +4147,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
<input
class="input box grow"
disabled=""
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries"
placeholder="/some-electron-app-path-for-user-data/binaries"
spellcheck="false"
value=""
/>
@@ -4178,7 +4178,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
>
<input
class="input box grow"
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries/kubectl"
placeholder="/some-electron-app-path-for-user-data/binaries/kubectl"
spellcheck="false"
value=""
/>
@@ -4617,7 +4617,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
<input
class="input box grow"
disabled=""
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries"
placeholder="/some-electron-app-path-for-user-data/binaries"
spellcheck="false"
value=""
/>
@@ -4648,7 +4648,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
>
<input
class="input box grow"
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries/kubectl"
placeholder="/some-electron-app-path-for-user-data/binaries/kubectl"
spellcheck="false"
value=""
/>
@@ -5087,7 +5087,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
<input
class="input box grow"
disabled=""
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries"
placeholder="/some-electron-app-path-for-user-data/binaries"
spellcheck="false"
value=""
/>
@@ -5118,7 +5118,7 @@ exports[`listing active helm repositories in preferences when navigating to pref
>
<input
class="input box grow"
placeholder="/some-absolute-root-directory/some-electron-app-path-for-user-data/binaries/kubectl"
placeholder="/some-electron-app-path-for-user-data/binaries/kubectl"
spellcheck="false"
value=""
/>
src/features/helm-charts/listing-active-helm-repositories-in-preferences.test.ts
+2 -2
View File
@@ -10,7 +10,7 @@ import readYamlFileInjectable from "../../common/fs/read-yaml-file.injectable";
import type { AsyncFnMock } from "@async-fn/jest";
import asyncFn from "@async-fn/jest";
import type { HelmRepositoriesFromYaml } from "../../main/helm/repositories/get-active-helm-repositories/get-active-helm-repositories.injectable";
import execFileInjectable from "../../common/fs/exec-file.injectable";
import execFileInjectable, { type ExecFile } from "../../common/fs/exec-file.injectable";
import helmBinaryPathInjectable from "../../main/helm/helm-binary-path.injectable";
import loggerInjectable from "../../common/logger.injectable";
import type { Logger } from "../../common/logger";
@@ -21,7 +21,7 @@ describe("listing active helm repositories in preferences", () => {
let builder: ApplicationBuilder;
let rendered: RenderResult;
let readYamlFileMock: AsyncFnMock<ReadYamlFile>;
let execFileMock: AsyncFnMock<ReturnType<typeof execFileInjectable["instantiate"]>>;
let execFileMock: AsyncFnMock<ExecFile>;
let loggerStub: Logger;
let showErrorNotificationMock: jest.Mock;
src/main/getDiForUnitTesting.ts
+1 -1
View File
@@ -261,7 +261,7 @@ const overrideElectronFeatures = (di: DiContainer) => {
di.override(
getElectronAppPathInjectable,
() => (name: string) => `some-electron-app-path-for-${kebabCase(name)}`,
() => (name: string) => `/some-electron-app-path-for-${kebabCase(name)}`,
);
di.override(setElectronAppPathInjectable, () => () => {});