Display namespace for subject on ClusterRoleBinding details (#4242)

This commit is contained in:
Lauri Nevala authored and GitHub committed 2021-11-03 10:09:53 -04:00
1 parent 99dd3e564e
commit 205cce43c7
2 files changed
+8 -6

No files matched your search

@@ -103,12 +103,13 @@ export class ClusterRoleBindingDetails extends React.Component<Props> {
<Table selectable className="bindings box grow"> <Table selectable className="bindings box grow">
<TableHead> <TableHead>
<TableCell checkbox /> <TableCell checkbox />
<TableCell className="binding">Name</TableCell>
<TableCell className="type">Type</TableCell> <TableCell className="type">Type</TableCell>
<TableCell className="binding">Name</TableCell>
<TableCell className="ns">Namespace</TableCell>
</TableHead> </TableHead>
{ {
subjects.map((subject, i) => { subjects.map((subject, i) => {
const { kind, name } = subject; const { kind, name, namespace } = subject;
const isSelected = selectedSubjects.has(subject); const isSelected = selectedSubjects.has(subject);
return ( return (
@@ -118,8 +119,9 @@ export class ClusterRoleBindingDetails extends React.Component<Props> {
onClick={prevDefault(() => this.selectedSubjects.toggle(subject))} onClick={prevDefault(() => this.selectedSubjects.toggle(subject))}
> >
<TableCell checkbox isChecked={isSelected} /> <TableCell checkbox isChecked={isSelected} />
<TableCell className="binding">{name}</TableCell>
<TableCell className="type">{kind}</TableCell> <TableCell className="type">{kind}</TableCell>
<TableCell className="binding">{name}</TableCell>
<TableCell className="ns">{namespace || "-"}</TableCell>
</TableRow> </TableRow>
); );
}) })
@@ -99,9 +99,9 @@ export class RoleBindingDetails extends React.Component<Props> {
<Table selectable className="bindings box grow"> <Table selectable className="bindings box grow">
<TableHead> <TableHead>
<TableCell checkbox /> <TableCell checkbox />
<TableCell className="binding">Name</TableCell>
<TableCell className="type">Type</TableCell> <TableCell className="type">Type</TableCell>
<TableCell className="type">Namespace</TableCell> <TableCell className="binding">Name</TableCell>
<TableCell className="ns">Namespace</TableCell>
</TableHead> </TableHead>
{ {
subjects.map((subject, i) => { subjects.map((subject, i) => {
@@ -115,8 +115,8 @@ export class RoleBindingDetails extends React.Component<Props> {
onClick={prevDefault(() => this.selectedSubjects.toggle(subject))} onClick={prevDefault(() => this.selectedSubjects.toggle(subject))}
> >
<TableCell checkbox isChecked={isSelected} /> <TableCell checkbox isChecked={isSelected} />
<TableCell className="binding">{name}</TableCell>
<TableCell className="type">{kind}</TableCell> <TableCell className="type">{kind}</TableCell>
<TableCell className="binding">{name}</TableCell>
<TableCell className="ns">{namespace || "-"}</TableCell> <TableCell className="ns">{namespace || "-"}</TableCell>
</TableRow> </TableRow>
); );