hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Override side-effects in unit test using injectable instead of monkey patching

Browse Source 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
This commit is contained in:
Iku-turso 2022-03-29 13:49:18 +03:00 committed by Janne Savolainen
parent 504557fc62
commit 20805e27ff
No known key found for this signature in database
GPG Key ID: 8C6CFB2FFFE8F68A
1 changed files with 12 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
src/renderer/components/layout/top-bar/top-bar-win-linux.test.tsx
View File

@ -7,41 +7,31 @@ import React from "react";
import { fireEvent } from "@testing-library/react"; import { fireEvent } from "@testing-library/react";
import "@testing-library/jest-dom/extend-expect"; import "@testing-library/jest-dom/extend-expect";
import { TopBar } from "./top-bar"; import { TopBar } from "./top-bar";
import * as vars from "../../../../common/vars";
import { getDiForUnitTesting } from "../../../getDiForUnitTesting"; import { getDiForUnitTesting } from "../../../getDiForUnitTesting";
import { DiRender, renderFor } from "../../test-utils/renderFor"; import { DiRender, renderFor } from "../../test-utils/renderFor";
import directoryForUserDataInjectable from "../../../../common/app-paths/directory-for-user-data/directory-for-user-data.injectable"; import directoryForUserDataInjectable from "../../../../common/app-paths/directory-for-user-data/directory-for-user-data.injectable";
import mockFs from "mock-fs"; import mockFs from "mock-fs";
import { emitOpenAppMenuAsContextMenu, requestWindowAction } from "../../../ipc"; import { emitOpenAppMenuAsContextMenu, requestWindowAction } from "../../../ipc";
import isLinuxInjectable from "../../../../common/vars/is-linux.injectable";
const mockConfig = vars as { isWindows: boolean; isLinux: boolean }; import isMacInjectable from "../../../../common/vars/is-mac.injectable";
import isWindowsInjectable from "../../../../common/vars/is-windows.injectable";
import type { DiContainer } from "@ogre-tools/injectable";
jest.mock("../../../../common/ipc"); jest.mock("../../../../common/ipc");
jest.mock("../../../ipc"); jest.mock("../../../ipc");
jest.mock("../../../../common/vars", () => {
const { SemVer } = require("semver");
return {
...jest.requireActual<{}>("../../../../common/vars"),
__esModule: true,
isWindows: null,
isLinux: null,
appSemVer: new SemVer("1.0.0"),
};
});
describe("<TopBar/> in Windows and Linux", () => { describe("<TopBar/> in Windows and Linux", () => {
let render: DiRender; let render: DiRender;
let di: DiContainer;
beforeEach(async () => { beforeEach(() => {
const di = getDiForUnitTesting({ doGeneralOverrides: true }); di = getDiForUnitTesting({ doGeneralOverrides: true });
mockFs(); di.override(isMacInjectable, () => false);
di.override(directoryForUserDataInjectable, () => "some-directory-for-user-data"); di.override(directoryForUserDataInjectable, () => "some-directory-for-user-data");
await di.runSetups(); mockFs();
render = renderFor(di); render = renderFor(di);
}); });
@ -51,8 +41,7 @@ describe("<TopBar/> in Windows and Linux", () => {
}); });
it("shows window controls on Windows", () => { it("shows window controls on Windows", () => {
mockConfig.isWindows = true; di.override(isWindowsInjectable, () => true);
mockConfig.isLinux = false;
const { getByTestId } = render(<TopBar />); const { getByTestId } = render(<TopBar />);
@ -63,8 +52,7 @@ describe("<TopBar/> in Windows and Linux", () => {
}); });
it("shows window controls on Linux", () => { it("shows window controls on Linux", () => {
mockConfig.isWindows = false; di.override(isLinuxInjectable, () => true);
mockConfig.isLinux = true;
const { getByTestId } = render(<TopBar />); const { getByTestId } = render(<TopBar />);
@ -75,7 +63,7 @@ describe("<TopBar/> in Windows and Linux", () => {
}); });
it("triggers ipc events on click", () => { it("triggers ipc events on click", () => {
mockConfig.isWindows = true; di.override(isWindowsInjectable, () => true);
const { getByTestId } = render(<TopBar />); const { getByTestId } = render(<TopBar />);