diff --git a/src/common/routes/preferences.ts b/src/common/routes/preferences.ts index e8f36b9f1d..5207226968 100644 --- a/src/common/routes/preferences.ts +++ b/src/common/routes/preferences.ts @@ -43,11 +43,11 @@ export const installRoute: RouteProps = { }; export const extensionPageRoute: RouteProps = { - path: `${preferencesRoute.path}/extension/:extensionId?`, + path: `${preferencesRoute.path}/extension/:extensionId?/overview`, }; export const extensionReviewsRoute: RouteProps = { - path: `${extensionPageRoute.path}/reviews`, + path: `${preferencesRoute.path}/extension/:extensionId?/reviews`, }; export const preferencesURL = buildURL(preferencesRoute.path); diff --git a/src/renderer/components/+preferences/extension-page.tsx b/src/renderer/components/+preferences/extension-page.tsx index 8c4c067a5d..4fb66c6e0a 100644 --- a/src/renderer/components/+preferences/extension-page.tsx +++ b/src/renderer/components/+preferences/extension-page.tsx @@ -13,7 +13,7 @@ import { matchPath, Route, RouteProps, Switch, useParams } from "react-router"; import { MarkdownViewer } from "../markdown-viewer"; import { Tab, Tabs } from "../tabs"; import { navigate } from "../../navigation"; -import { extensionPageRoute, extensionPageURL, extensionReviewsRoute, extensionReviewsURL } from "../../../common/routes"; +import { extensionPageRoute, extensionReviewsRoute } from "../../../common/routes"; export function ExtensionPage() { const [extension, setExtension] = useState(null); @@ -50,7 +50,7 @@ export function ExtensionPage() { }, []); if (!extension || !description) { - return ; + return ; } return ( @@ -61,31 +61,26 @@ export function ExtensionPage() { navigate(url); }}> - {/* {tabs.map(({ title, routePath, url = routePath, exact }) => { - const isActive = !!matchPath(currentLocation, { path: routePath, exact }); - - return ; - })} */}
- - - - + + + +
diff --git a/src/renderer/components/+preferences/install.tsx b/src/renderer/components/+preferences/install.tsx index 8d276bb527..a16f6aa9ee 100644 --- a/src/renderer/components/+preferences/install.tsx +++ b/src/renderer/components/+preferences/install.tsx @@ -63,7 +63,7 @@ function ExtensionList({ extensions, search }: { extensions: Extension[], search )); function handleClick(extensionId: string) { - history.push(`extension/${extensionId}`); + history.push(`extension/${extensionId}/overview`); } if (!filteredExtensions.length) { diff --git a/src/renderer/components/+preferences/preferences.tsx b/src/renderer/components/+preferences/preferences.tsx index 367d939d40..3e1b993949 100644 --- a/src/renderer/components/+preferences/preferences.tsx +++ b/src/renderer/components/+preferences/preferences.tsx @@ -26,7 +26,7 @@ import { terminalURL, installURL, installRoute, - extensionPageURL, + // extensionPageURL, } from "../../../common/routes"; import { navigateWithoutHistoryChange, navigation } from "../../navigation"; import { SettingLayout } from "../layout/setting-layout"; @@ -95,7 +95,7 @@ const NonInjectedPreferences: React.FC = ({ appPreferenceItems }) - +