Fix building docs and verify:docs workflow (#7013)

* Fix building docs and verify:docs workflow

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix commands

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Signed-off-by: Sebastian Malton <sebastian@malton.name>

packages/core/src/extensions/common-api/app.ts

@@ -11,26 +11,17 @@ import isWindowsInjectable from "../../common/vars/is-windows.injectable";
 import { asLegacyGlobalFunctionForExtensionApi } from "../as-legacy-globals-for-extension-api/as-legacy-global-function-for-extension-api";
 import { getLegacyGlobalDiForExtensionApi } from "../as-legacy-globals-for-extension-api/legacy-global-di-for-extension-api";
 import getEnabledExtensionsInjectable from "./get-enabled-extensions/get-enabled-extensions.injectable";
-import type { UserPreferenceExtensionItems } from "./user-preferences";
-import { Preferences } from "./user-preferences";
 import { slackUrl, issuesTrackerUrl } from "../../common/vars";
 import { buildVersionInjectionToken } from "../../common/vars/build-semantic-version.injectable";
+import { asLegacyGlobalForExtensionApi } from "../as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api";
+import userStoreInjectable from "../../common/user-store/user-store.injectable";
 
-export interface AppExtensionItems {
-  readonly Preferences: UserPreferenceExtensionItems;
-  readonly version: string;
-  readonly appName: string;
-  readonly slackUrl: string;
-  readonly issuesTrackerUrl: string;
-  readonly isSnap: boolean;
-  readonly isWindows: boolean;
-  readonly isMac: boolean;
-  readonly isLinux: boolean;
-  getEnabledExtensions: () => string[];
-}
+const userStore = asLegacyGlobalForExtensionApi(userStoreInjectable);
 
-export const App: AppExtensionItems = {
-  Preferences,
+export const App = {
+  Preferences: {
+    getKubectlPath: () => userStore.kubectlBinariesPath,
+  },
   getEnabledExtensions: asLegacyGlobalFunctionForExtensionApi(getEnabledExtensionsInjectable),
   get version() {
     const di = getLegacyGlobalDiForExtensionApi();
@@ -64,4 +55,4 @@ export const App: AppExtensionItems = {
   },
   slackUrl,
   issuesTrackerUrl,
-};
+} as const;

packages/core/src/extensions/common-api/catalog.ts

@@ -3,6 +3,7 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 
+import type { KubernetesClusterCategory } from "../../common/catalog-entities/kubernetes-cluster";
 import kubernetesClusterCategoryInjectable from "../../common/catalog/categories/kubernetes-cluster.injectable";
 import { asLegacyGlobalForExtensionApi } from "../as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api";
 
@@ -12,6 +13,10 @@ export {
   WebLink,
 } from "../../common/catalog-entities";
 
+export type {
+  KubernetesClusterCategory,
+};
+
 export const kubernetesClusterCategory = asLegacyGlobalForExtensionApi(kubernetesClusterCategoryInjectable);
 
 export type {
@@ -23,6 +28,7 @@ export type {
   WebLinkStatusPhase,
   KubernetesClusterStatusPhase,
   KubernetesClusterStatus,
+  GeneralEntitySpec,
 } from "../../common/catalog-entities";
 
 export * from "../../common/catalog/catalog-entity";

packages/core/src/extensions/common-api/event-bus.ts

@@ -5,7 +5,14 @@
 
 import appEventBusInjectable from "../../common/app-event-bus/app-event-bus.injectable";
 import { asLegacyGlobalForExtensionApi } from "../as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api";
+import type { AppEvent } from "../../common/app-event-bus/event-bus";
+import type { EventEmitter, EventEmitterCallback, EventEmitterOptions } from "../../common/event-emitter";
 
-export type { AppEvent } from "../../common/app-event-bus/event-bus";
+export type {
+  AppEvent,
+  EventEmitter,
+  EventEmitterCallback,
+  EventEmitterOptions,
+};
 
 export const appEventBus = asLegacyGlobalForExtensionApi(appEventBusInjectable);

packages/core/src/extensions/common-api/index.ts

@@ -13,6 +13,8 @@ import * as Types from "./types";
 import * as Proxy from "./proxy";
 import loggerInjectable from "../../common/logger.injectable";
 import { asLegacyGlobalForExtensionApi } from "../as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api";
+import type { Logger } from "../../common/logger";
+import type { LensExtension, LensExtensionManifest } from "../lens-extension";
 
 const logger = asLegacyGlobalForExtensionApi(loggerInjectable);
 
@@ -25,4 +27,7 @@ export {
   Util,
   logger,
   Proxy,
+  Logger,
+  LensExtension,
+  LensExtensionManifest,
 };

packages/core/src/extensions/common-api/stores.ts

@@ -3,4 +3,10 @@
  * Licensed under MIT License. See LICENSE in root directory for more information.
  */
 
-export { ExtensionStore } from "../extension-store";
+import type { BaseStoreParams } from "../../common/base-store/base-store";
+import { ExtensionStore } from "../extension-store";
+
+export {
+  BaseStoreParams,
+  ExtensionStore,
+};

packages/core/src/extensions/common-api/user-preferences.ts

@@ -1,19 +0,0 @@
-/**
- * Copyright (c) OpenLens Authors. All rights reserved.
- * Licensed under MIT License. See LICENSE in root directory for more information.
- */
-
-import userStoreInjectable from "../../common/user-store/user-store.injectable";
-import { asLegacyGlobalForExtensionApi } from "../as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api";
-export interface UserPreferenceExtensionItems {
-  /**
-   * Get the configured kubectl binaries path.
-   */
-  getKubectlPath: () => string | undefined;
-}
-
-const userStore = asLegacyGlobalForExtensionApi(userStoreInjectable);
-
-export const Preferences: UserPreferenceExtensionItems = {
-  getKubectlPath: () => userStore.kubectlBinariesPath,
-};

packages/core/src/extensions/common-api/utils.ts

@@ -9,20 +9,9 @@ import { asLegacyGlobalFunctionForExtensionApi } from "../as-legacy-globals-for-
 import { getLegacyGlobalDiForExtensionApi } from "../as-legacy-globals-for-extension-api/legacy-global-di-for-extension-api";
 import { Singleton } from "../../common/utils";
 import { prevDefault, stopPropagation } from "../../renderer/utils/prevDefault";
-import type { IClassName } from "../../renderer/utils/cssNames";
 import { cssNames } from "../../renderer/utils/cssNames";
 
-export interface UtilsExtensionItems {
-  Singleton: typeof Singleton;
-  prevDefault: <E extends React.SyntheticEvent | Event, R>(callback: (evt: E) => R) => (evt: E) => R;
-  stopPropagation: (evt: Event | React.SyntheticEvent) => void;
-  cssNames: (...classNames: IClassName[]) => string;
-  openExternal: (url: string) => Promise<void>;
-  openBrowser: (url: string) => Promise<void>;
-  getAppVersion: () => string;
-}
-
-export const Util: UtilsExtensionItems = {
+export const Util = {
   Singleton,
   prevDefault,
   stopPropagation,
@@ -34,4 +23,4 @@ export const Util: UtilsExtensionItems = {
 
     return di.inject(buildVersionInjectable).get();
   },
-};
+} as const;

packages/core/src/extensions/lens-extension.ts

@@ -32,7 +32,12 @@ export interface LensExtensionManifest extends PackageJson {
 export const lensExtensionDependencies = Symbol("lens-extension-dependencies");
 export const Disposers = Symbol("disposers");
 
-export class LensExtension<Dependencies extends LensExtensionDependencies = LensExtensionDependencies> {
+export class LensExtension<
+  /**
+   * @ignore
+   */
+  Dependencies extends LensExtensionDependencies = LensExtensionDependencies,
+> {
   readonly id: LensExtensionId;
   readonly manifest: LensExtensionManifest;
   readonly manifestPath: string;
@@ -50,6 +55,9 @@ export class LensExtension<Dependencies extends LensExtensionDependencies = Lens
     return this._isEnabled;
   }
 
+  /**
+   * @ignore
+   */
   [Disposers] = disposer();
 
   constructor({ id, manifest, manifestPath, isBundled }: InstalledExtension) {
@@ -72,6 +80,9 @@ export class LensExtension<Dependencies extends LensExtensionDependencies = Lens
     return this.manifest.description;
   }
 
+  /**
+   * @ignore
+   */
   readonly [lensExtensionDependencies]!: Dependencies;
 
   /**