From 21221d8b372d2983c14cb8cd5b5bc0ddf6cba080 Mon Sep 17 00:00:00 2001
From: Sebastian Malton <sebastian@malton.name>
Date: Thu, 5 May 2022 09:27:59 -0400
Subject: [PATCH] use more descriptive name for local test mocks

Signed-off-by: Sebastian Malton <sebastian@malton.name>
---
 src/common/__tests__/hotbar-store.test.ts    | 12 ++++++------
 src/main/__test__/kubeconfig-manager.test.ts |  8 ++++----
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/common/__tests__/hotbar-store.test.ts b/src/common/__tests__/hotbar-store.test.ts
index 0b5b74ff01..93563c97ee 100644
--- a/src/common/__tests__/hotbar-store.test.ts
+++ b/src/common/__tests__/hotbar-store.test.ts
@@ -42,7 +42,7 @@ describe("HotbarStore", () => {
   let testCluster: CatalogEntity;
   let minikubeCluster: CatalogEntity;
   let awsCluster: CatalogEntity;
-  let logger: jest.Mocked<Logger>;
+  let loggerMock: jest.Mocked<Logger>;
 
   beforeEach(async () => {
     di = getDiForUnitTesting({ doGeneralOverrides: true });
@@ -91,7 +91,7 @@ describe("HotbarStore", () => {
 
     di.override(hasCategoryForEntityInjectable, () => () => true);
 
-    logger = {
+    loggerMock = {
       warn: jest.fn(),
       debug: jest.fn(),
       error: jest.fn(),
@@ -99,7 +99,7 @@ describe("HotbarStore", () => {
       silly: jest.fn(),
     };
 
-    di.override(loggerInjectable, () => logger);
+    di.override(loggerInjectable, () => loggerMock);
 
     const catalogEntityRegistry = di.inject(catalogEntityRegistryInjectable);
     const catalogCatalogEntity = di.inject(catalogCatalogEntityInjectable);
@@ -219,13 +219,13 @@ describe("HotbarStore", () => {
         hotbarStore.setActiveHotbar("hottest");
 
         hotbarStore.addToHotbar(testCluster, -1);
-        expect(logger.error).toBeCalledWith("[HOTBAR-STORE]: cannot pin entity to hotbar outside of index range", anyObject());
+        expect(loggerMock.error).toBeCalledWith("[HOTBAR-STORE]: cannot pin entity to hotbar outside of index range", anyObject());
 
         hotbarStore.addToHotbar(testCluster, 12);
-        expect(logger.error).toBeCalledWith("[HOTBAR-STORE]: cannot pin entity to hotbar outside of index range", anyObject());
+        expect(loggerMock.error).toBeCalledWith("[HOTBAR-STORE]: cannot pin entity to hotbar outside of index range", anyObject());
 
         hotbarStore.addToHotbar(testCluster, 13);
-        expect(logger.error).toBeCalledWith("[HOTBAR-STORE]: cannot pin entity to hotbar outside of index range", anyObject());
+        expect(loggerMock.error).toBeCalledWith("[HOTBAR-STORE]: cannot pin entity to hotbar outside of index range", anyObject());
       });
 
       it("throws an error if getId is invalid or returns not a string", () => {
diff --git a/src/main/__test__/kubeconfig-manager.test.ts b/src/main/__test__/kubeconfig-manager.test.ts
index f21fa70e06..a7616c6d40 100644
--- a/src/main/__test__/kubeconfig-manager.test.ts
+++ b/src/main/__test__/kubeconfig-manager.test.ts
@@ -27,14 +27,14 @@ describe("kubeconfig manager tests", () => {
   let clusterFake: Cluster;
   let createKubeconfigManager: (cluster: Cluster) => KubeconfigManager | undefined;
   let di: DiContainer;
-  let logger: jest.Mocked<Logger>;
+  let loggerMock: jest.Mocked<Logger>;
 
   beforeEach(async () => {
     di = getDiForUnitTesting({ doGeneralOverrides: true });
 
     di.override(directoryForTempInjectable, () => "some-directory-for-temp");
 
-    logger = {
+    loggerMock = {
       warn: jest.fn(),
       debug: jest.fn(),
       error: jest.fn(),
@@ -42,7 +42,7 @@ describe("kubeconfig manager tests", () => {
       silly: jest.fn(),
     };
 
-    di.override(loggerInjectable, () => logger);
+    di.override(loggerInjectable, () => loggerMock);
 
     mockFs({
       "minikube-config.yml": JSON.stringify({
@@ -104,7 +104,7 @@ describe("kubeconfig manager tests", () => {
 
     assert(kubeConfManager, "should actually create one");
 
-    expect(logger.error).not.toBeCalled();
+    expect(loggerMock.error).not.toBeCalled();
     expect(await kubeConfManager.getPath()).toBe(`some-directory-for-temp${path.sep}kubeconfig-foo`);
     // this causes an intermittent "ENXIO: no such device or address, read" error
     //    const file = await fse.readFile(await kubeConfManager.getPath());