Make asking of boolean value from user not require explicit ID for question

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
This commit is contained in:
Iku-tursoandJanne Savolainen committed 2022-05-23 14:56:57 +03:00
1 parent ff20645bbc
commit 21e05d935b
6 files changed
+45 -40

No files matched your search

@@ -392,7 +392,7 @@ exports[`installing update using tray when started when user checks for updates
>
<div
class="flex column gaps"
data-testid="ask-boolean-install-update"
data-testid="ask-boolean-some-irrelevant-random-id"
>
<b>
Update Available
@@ -407,14 +407,14 @@ Lens should restart automatically, if it doesn't please restart manually. Instal
>
<button
class="Button light"
data-testid="ask-boolean-install-update-button-yes"
data-testid="ask-boolean-some-irrelevant-random-id-button-yes"
type="button"
>
Yes
</button>
<button
class="Button active outlined"
data-testid="ask-boolean-install-update-button-no"
data-testid="ask-boolean-some-irrelevant-random-id-button-no"
type="button"
>
No
@@ -427,7 +427,7 @@ Lens should restart automatically, if it doesn't please restart manually. Instal
>
<i
class="Icon close material interactive focusable"
data-testid="close-notification-for-ask-boolean-for-install-update"
data-testid="close-notification-for-ask-boolean-for-some-irrelevant-random-id"
tabindex="0"
>
<span
@@ -184,7 +184,6 @@ describe("installing update", () => {
it("asks user to install update immediately", () => {
expect(askBooleanMock).toHaveBeenCalledWith({
id: "install-update",
title: "Update Available",
question:
"Version some-version of Lens IDE is available and ready to be installed. Would you like to update now?\n\n" +