From 23cd50ee95cc8f6064d2c3ffb8ed66f3212ef77f Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Tue, 26 Apr 2022 09:11:14 -0400 Subject: [PATCH] cleanup internal-commands Signed-off-by: Sebastian Malton --- .../internal-commands.injectable.tsx | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/renderer/components/command-palette/registered-commands/internal-commands.injectable.tsx b/src/renderer/components/command-palette/registered-commands/internal-commands.injectable.tsx index 6d10064f02..66f59df706 100644 --- a/src/renderer/components/command-palette/registered-commands/internal-commands.injectable.tsx +++ b/src/renderer/components/command-palette/registered-commands/internal-commands.injectable.tsx @@ -203,13 +203,10 @@ function getInternalCommands(dependencies: Dependencies): CommandRegistration[] id: "entity.viewSettings", title: ({ entity }) => `${entity.kind}/${entity.getName()}: View Settings`, action: ({ entity }) => dependencies.navigateToEntitySettings(entity.getId()), - isActive: ({ entity }) => { - if (!entity) { - return false; - } - - return dependencies.getEntitySettingItems(entity.kind, entity.apiVersion, entity.metadata.source).length > 0; - }, + isActive: ({ entity }) => ( + entity + && dependencies.getEntitySettingItems(entity.kind, entity.apiVersion, entity.metadata.source).length > 0 + ), }, { id: "cluster.openTerminal", @@ -254,7 +251,6 @@ const internalCommandsInjectable = getInjectable({ .getInstance() .getItemsForKind, createTerminalTab: di.inject(createTerminalTabInjectable), - navigateToPreferences: di.inject(navigateToPreferencesInjectable), navigateToHelmCharts: di.inject(navigateToHelmChartsInjectable), navigateToHelmReleases: di.inject(navigateToHelmReleasesInjectable),